Skip to content

[Merged by Bors] - feat: port Algebra.Order.Monoid.WithZero#851

Closed
zeramorphic wants to merge 16 commits intomasterfrom
Algebra.Order.Monoid.WithZero
Closed

[Merged by Bors] - feat: port Algebra.Order.Monoid.WithZero#851
zeramorphic wants to merge 16 commits intomasterfrom
Algebra.Order.Monoid.WithZero

Conversation

@zeramorphic
Copy link
Copy Markdown
Collaborator

@zeramorphic zeramorphic commented Dec 4, 2022

mathlib3 SHA: dad7ecf9a1feae63e6e49f07619b7087403fb8d4

Ports Algebra.Order.Monoid.WithZero.[Defs, Basic].

I'm planning to wait until leanprover-community/mathlib3#17820 is approved before doing a final refactor to move lemmas where they're needed.

@zeramorphic zeramorphic added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 4, 2022
Signed-off-by: thirdsgames <thirdsgames2018@gmail.com>
Signed-off-by: thirdsgames <thirdsgames2018@gmail.com>
Signed-off-by: thirdsgames <thirdsgames2018@gmail.com>
@zeramorphic zeramorphic marked this pull request as ready for review December 4, 2022 20:41
@zeramorphic zeramorphic added awaiting-review and removed WIP Work in progress labels Dec 4, 2022
Signed-off-by: thirdsgames <thirdsgames2018@gmail.com>
@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 6, 2022
@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 6, 2022
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Copy link
Copy Markdown
Collaborator Author

zeramorphic commented Dec 6, 2022

I've removed ZeroLEOneClass from Algebra.Order.Monoid.WithOne.Defs as indicated by leanprover-community/mathlib3#17820.

Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Copy link
Copy Markdown
Collaborator Author

A couple of build errors arose from the merge commit, which are now fixed.

Signed-off-by: zeramorphic <zeramorphic@proton.me>
@ChrisHughes24
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 6, 2022
bors bot pushed a commit that referenced this pull request Dec 6, 2022
mathlib3 SHA: dad7ecf9a1feae63e6e49f07619b7087403fb8d4

Ports Algebra.Order.Monoid.WithZero.[Defs, Basic].

- [x] depends on #841
- [x] depends on leanprover-community/mathlib3#17820

I'm planning to wait until leanprover-community/mathlib3#17820 is approved before doing a final refactor to move lemmas where they're needed.

Co-authored-by: thirdsgames <thirdsgames2018@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: zeramorphic <zeramorphic@proton.me>
@bors
Copy link
Copy Markdown

bors bot commented Dec 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Order.Monoid.WithZero [Merged by Bors] - feat: port Algebra.Order.Monoid.WithZero Dec 6, 2022
@bors bors bot closed this Dec 6, 2022
@bors bors bot deleted the Algebra.Order.Monoid.WithZero branch December 6, 2022 14:16
bors bot pushed a commit to leanprover-community/mathlib3 that referenced this pull request Dec 7, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.divisibility.units`: leanprover-community/mathlib4#848
* `algebra.group.type_tags`: leanprover-community/mathlib4#832
* `algebra.group_with_zero.divisibility`: leanprover-community/mathlib4#870
* `algebra.hom.equiv.basic`: leanprover-community/mathlib4#835
* `algebra.order.group.defs`: leanprover-community/mathlib4#869
* `algebra.order.monoid.basic`: leanprover-community/mathlib4#872
* `algebra.order.monoid.cancel.basic`: leanprover-community/mathlib4#883
* `algebra.order.monoid.with_zero.defs`: leanprover-community/mathlib4#851
* `algebra.order.monoid.with_zero.basic`: leanprover-community/mathlib4#851
* `algebra.ring.divisibility`: leanprover-community/mathlib4#864
* `data.list.defs`: leanprover-community/mathlib4#803
* `data.sigma.order`: leanprover-community/mathlib4#887
* `group_theory.group_action.defs`: leanprover-community/mathlib4#854
* `order.heyting.boundary`: leanprover-community/mathlib4#844
* `order.hom.basic`: leanprover-community/mathlib4#804
* `order.symm_diff`: leanprover-community/mathlib4#842



Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants