[Merged by Bors] - feat: port data.list.defs#803
Closed
arienmalec wants to merge 48 commits intomasterfrom
Closed
Conversation
1 task
arienmalec
commented
Dec 1, 2022
Contributor
Author
arienmalec
left a comment
There was a problem hiding this comment.
For this one, we should also remove the nolint annotation. For nthd I deliberately retained the l and n names for doc purposes. For inth we can just remove the nolint
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kim-em
reviewed
Dec 2, 2022
kbuzzard
reviewed
Dec 3, 2022
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
kbuzzard
approved these changes
Dec 5, 2022
| def chooseX : ∀ l : List α, ∀ _ : ∃ a, a ∈ l ∧ p a, { a // a ∈ l ∧ p a } | ||
| | [], hp => False.elim (Exists.elim hp fun a h => not_mem_nil a h.left) | ||
| | l :: ls, hp => | ||
| if pl : p l then ⟨l, ⟨mem_cons.mpr <| Or.inl rfl, pl⟩⟩ |
Member
There was a problem hiding this comment.
aargh here we are being bitten by the fact that List.mem_cons is not rfl like it was in Lean 3 :-( It's not hard to imagine this issue showing up again and again...
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
kim-em
reviewed
Dec 6, 2022
kim-em
reviewed
Dec 6, 2022
kim-em
reviewed
Dec 6, 2022
kim-em
reviewed
Dec 6, 2022
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
Port of `data.list.defs`, mostly consists of appropriate `#align`s to map `mathlib` `List` functions to the appropriate definitions in `Std4` Based on 1fc36cc9c8264e6e81253f88be7fb2cb6c92d76a Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
Port of `data.list.defs`, mostly consists of appropriate `#align`s to map `mathlib` `List` functions to the appropriate definitions in `Std4` Based on 1fc36cc9c8264e6e81253f88be7fb2cb6c92d76a Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
thing copied from mathlib3port: 1fc36cc9c8264e6e81253f88be7fb2cb6c92d76a - [x] Depends on: #803 (for `list.traverse`) Co-authored-by: Arien Malec <arien.malec@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: arienmalec <arien.malec@gmail.com>
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 7, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.divisibility.units`: leanprover-community/mathlib4#848 * `algebra.group.type_tags`: leanprover-community/mathlib4#832 * `algebra.group_with_zero.divisibility`: leanprover-community/mathlib4#870 * `algebra.hom.equiv.basic`: leanprover-community/mathlib4#835 * `algebra.order.group.defs`: leanprover-community/mathlib4#869 * `algebra.order.monoid.basic`: leanprover-community/mathlib4#872 * `algebra.order.monoid.cancel.basic`: leanprover-community/mathlib4#883 * `algebra.order.monoid.with_zero.defs`: leanprover-community/mathlib4#851 * `algebra.order.monoid.with_zero.basic`: leanprover-community/mathlib4#851 * `algebra.ring.divisibility`: leanprover-community/mathlib4#864 * `data.list.defs`: leanprover-community/mathlib4#803 * `data.sigma.order`: leanprover-community/mathlib4#887 * `group_theory.group_action.defs`: leanprover-community/mathlib4#854 * `order.heyting.boundary`: leanprover-community/mathlib4#844 * `order.hom.basic`: leanprover-community/mathlib4#804 * `order.symm_diff`: leanprover-community/mathlib4#842 Co-authored-by: Johan Commelin <johan@commelin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
data.list.defs, mostly consists of appropriate#aligns to mapmathlibListfunctions to the appropriate definitions inStd4Based on 1fc36cc9c8264e6e81253f88be7fb2cb6c92d76a