[Merged by Bors] - feat: port Order.Heyting.Boundary#844
Closed
[Merged by Bors] - feat: port Order.Heyting.Boundary#844
Conversation
Contributor
Author
|
Should I rename |
Member
|
bors merge |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
mathlib SHA: 70d50ecfd4900dd6d328da39ab7ebd516abe4025 Porting notes: 1. Needed to fix the proof of `boundary_le_boundary_sup_sup_boundary_inf_left` as simp produced a different term than in mathlib3 2. The `scoped` notation doesn't automatically introduce the notation into the current scope. ~~3. The lint error seems like a bug. Can anyone confirm?~~ Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
mathlib SHA: 70d50ecfd4900dd6d328da39ab7ebd516abe4025 Porting notes: 1. Needed to fix the proof of `boundary_le_boundary_sup_sup_boundary_inf_left` as simp produced a different term than in mathlib3 2. The `scoped` notation doesn't automatically introduce the notation into the current scope. ~~3. The lint error seems like a bug. Can anyone confirm?~~ Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Build failed (retrying...):
|
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
mathlib SHA: 70d50ecfd4900dd6d328da39ab7ebd516abe4025 Porting notes: 1. Needed to fix the proof of `boundary_le_boundary_sup_sup_boundary_inf_left` as simp produced a different term than in mathlib3 2. The `scoped` notation doesn't automatically introduce the notation into the current scope. ~~3. The lint error seems like a bug. Can anyone confirm?~~ Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 7, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.divisibility.units`: leanprover-community/mathlib4#848 * `algebra.group.type_tags`: leanprover-community/mathlib4#832 * `algebra.group_with_zero.divisibility`: leanprover-community/mathlib4#870 * `algebra.hom.equiv.basic`: leanprover-community/mathlib4#835 * `algebra.order.group.defs`: leanprover-community/mathlib4#869 * `algebra.order.monoid.basic`: leanprover-community/mathlib4#872 * `algebra.order.monoid.cancel.basic`: leanprover-community/mathlib4#883 * `algebra.order.monoid.with_zero.defs`: leanprover-community/mathlib4#851 * `algebra.order.monoid.with_zero.basic`: leanprover-community/mathlib4#851 * `algebra.ring.divisibility`: leanprover-community/mathlib4#864 * `data.list.defs`: leanprover-community/mathlib4#803 * `data.sigma.order`: leanprover-community/mathlib4#887 * `group_theory.group_action.defs`: leanprover-community/mathlib4#854 * `order.heyting.boundary`: leanprover-community/mathlib4#844 * `order.hom.basic`: leanprover-community/mathlib4#804 * `order.symm_diff`: leanprover-community/mathlib4#842 Co-authored-by: Johan Commelin <johan@commelin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib SHA: 70d50ecfd4900dd6d328da39ab7ebd516abe4025
Porting notes:
boundary_le_boundary_sup_sup_boundary_inf_leftas simp produced a different term than in mathlib3scopednotation doesn't automatically introduce the notation into the current scope.3. The lint error seems like a bug. Can anyone confirm?