Skip to content

[Merged by Bors] - feat: port Order.RelIso.Basic#772

Closed
ChrisHughes24 wants to merge 13 commits intomasterfrom
rel_iso_basic
Closed

[Merged by Bors] - feat: port Order.RelIso.Basic#772
ChrisHughes24 wants to merge 13 commits intomasterfrom
rel_iso_basic

Conversation

@ChrisHughes24
Copy link
Copy Markdown
Member

@ChrisHughes24 ChrisHughes24 commented Nov 28, 2022

SHA 76171581280d5b5d1e2d1f4f37e5420357bdc636

Finished the port

@ChrisHughes24 ChrisHughes24 added the WIP Work in progress label Nov 28, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 28, 2022

Could you please satisfy the style linter (long lines) and make sure everything is imported in Mathlib.lean.

@kim-em kim-em added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 28, 2022
@ChrisHughes24 ChrisHughes24 added awaiting-review and removed WIP Work in progress awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 29, 2022
@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor

Can you take a look at the lean lint errors too?

/- The `docBlame` linter reports:
DEFINITIONS ARE MISSING DOCUMENTATION STRINGS: -/
-- Mathlib.Order.RelIso.Basic
#check RelHom.toFun.{u_1, u_2} /- definition missing documentation string -/
#check RelHom.map_rel'.{u_1, u_2} /- definition missing documentation string -/
#check term_→r_ /- definition missing documentation string -/
#check RelHomClass.map_rel.{u_1, u_2, u_3} /- definition missing documentation string -/
#check RelEmbedding.map_rel_iff'.{u_1, u_2} /- definition missing documentation string -/
#check term_↪r_ /- definition missing documentation string -/
#check RelIso.map_rel_iff'.{u_1, u_2} /- definition missing documentation string -/
#check term_≃r_ /- definition missing documentation string -/

/- The `simpNF` linter reports:
SOME SIMP LEMMAS ARE NOT IN SIMP-NORMAL FORM.
see note [simp-normal form] for tips how to debug this.
https://leanprover-community.github.io/mathlib_docs/notes.html#simp-normal%20form -/
-- Mathlib.Order.RelIso.Basic
#check RelEmbedding.inj.{u_2, u_1} /- simp can prove this:
  by simp only [EmbeddingLike.apply_eq_iff_eq]
One of the lemmas above could be a duplicate.
If that's not the case try reordering lemmas or adding @[priority].
 -/
#check RelIso.eq_iff_eq.{u_2, u_1} /- simp can prove this:
  by simp only [EmbeddingLike.apply_eq_iff_eq]
One of the lemmas above could be a duplicate.
If that's not the case try reordering lemmas or adding @[priority].
 -/

/- The `synTaut` linter reports:
THE FOLLOWING DECLARATIONS ARE SYNTACTIC TAUTOLOGIES. This usually means that they are of the form `∀ a b ... z, e₁ = e₂` where `e₁` and `e₂` are identical expressions. We call declarations of this form syntactic tautologies. Such lemmas are (mostly) useless and sometimes introduced unintentionally when proving basic facts using `rfl`, when elaboration results in a different term than the user intended. You should check that the declaration really says what you think it does. -/
-- Mathlib.Order.RelIso.Basic
#check RelEmbedding.to_rel_hom_eq_coe.{u_2, u_1} /- LHS equals RHS syntactically -/
#check RelEmbedding.coe_fn_to_embedding.{u_2, u_1} /- LHS equals RHS syntactically -/
#check RelIso.to_rel_embedding_eq_coe.{u_2, u_1} /- LHS equals RHS syntactically -/
#check RelIso.coe_coe_fn.{u_2, u_1} /- LHS equals RHS syntactically -/

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Nov 29, 2022
@digama0 digama0 changed the title feat port:(Order/RelIso/Basic) feat: port Order.RelIso.Basic Nov 29, 2022
@ChrisHughes24 ChrisHughes24 added awaiting-review mathlib-port This is a port of a theory file from mathlib. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 29, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 29, 2022

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Nov 29, 2022

✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Nov 29, 2022
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, IMO

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 30, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 30, 2022
bors bot pushed a commit that referenced this pull request Nov 30, 2022
SHA 19091d8f2e537e76a81d1608e011dd4d03f94642

Finished the port

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link
Copy Markdown

bors bot commented Nov 30, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.RelIso.Basic [Merged by Bors] - feat: port Order.RelIso.Basic Nov 30, 2022
@bors bors bot closed this Nov 30, 2022
@bors bors bot deleted the rel_iso_basic branch November 30, 2022 20:31
bors bot pushed a commit to leanprover-community/mathlib3 that referenced this pull request Dec 1, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.field.defs`: leanprover-community/mathlib4#668
* `algebra.group.commute`: leanprover-community/mathlib4#750
* `algebra.group_with_zero.commute`: leanprover-community/mathlib4#762
* `algebra.group_with_zero.semiconj`: leanprover-community/mathlib4#757
* `algebra.group_with_zero.units.basic`: leanprover-community/mathlib4#735
* `algebra.hom.embedding`: leanprover-community/mathlib4#764
* `algebra.order.monoid.cancel.defs`: leanprover-community/mathlib4#774
* `algebra.order.monoid.canonical.defs`: leanprover-community/mathlib4#778
* `algebra.order.monoid.defs`: leanprover-community/mathlib4#771
* `algebra.order.monoid.min_max`: leanprover-community/mathlib4#763
* `algebra.order.monoid.order_dual`: leanprover-community/mathlib4#786
* `algebra.order.sub.defs`: leanprover-community/mathlib4#732
* `algebra.regular.basic`: leanprover-community/mathlib4#758
* `algebra.ring.commute`: leanprover-community/mathlib4#759
* `algebra.ring.regular`: leanprover-community/mathlib4#795
* `algebra.ring.semiconj`: leanprover-community/mathlib4#751
* `control.applicative`: leanprover-community/mathlib4#798
* `control.functor`: leanprover-community/mathlib4#612
* `control.monad.basic`: leanprover-community/mathlib4#752
* `data.countable.defs`: leanprover-community/mathlib4#736
* `data.int.units`: leanprover-community/mathlib4#807
* `data.nat.basic`: leanprover-community/mathlib4#729
* `data.nat.psub`: leanprover-community/mathlib4#806
* `data.nat.units`: leanprover-community/mathlib4#805
* `data.pi.algebra`: leanprover-community/mathlib4#564
* `data.prod.lex`: leanprover-community/mathlib4#783
* `logic.embedding.basic`: leanprover-community/mathlib4#700
* `logic.equiv.option`: leanprover-community/mathlib4#674
* `order.bounded_order`: leanprover-community/mathlib4#697
* `order.with_bot`: leanprover-community/mathlib4#776
* `order.disjoint`: leanprover-community/mathlib4#773
* `order.min_max`: leanprover-community/mathlib4#728
* `order.prop_instances`: leanprover-community/mathlib4#792
* `order.rel_iso.basic`: leanprover-community/mathlib4#772
@alexjbest
Copy link
Copy Markdown
Member

Sorry but what is SHA 19091d8f2e537e76a81d1608e011dd4d03f94642 @ChrisHughes24 it makes my ./scripts/port_status.py complain that 19091d8f2e537e76a81d1608e011dd4d03f94642..HEAD is not a valid range

@ChrisHughes24
Copy link
Copy Markdown
Member Author

Sorry I made a mistake and used the commit hash for the mathlib3port repo. The SHA should be 76171581280d5b5d1e2d1f4f37e5420357bdc636 There was one other PR where I made this mistake. I'll check it

bors bot pushed a commit that referenced this pull request Dec 6, 2022
mathlib3 git sha 62a5626868683c104774de8d85b9855234ac807c

- [x] depends on: #772 
- [x] depends on: #838

Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants