[Merged by Bors] - feat: port Order.RelIso.Basic#772
[Merged by Bors] - feat: port Order.RelIso.Basic#772ChrisHughes24 wants to merge 13 commits intomasterfrom
Conversation
|
Could you please satisfy the style linter (long lines) and make sure everything is imported in |
|
Can you take a look at the lean lint errors too? /- The `docBlame` linter reports:
DEFINITIONS ARE MISSING DOCUMENTATION STRINGS: -/
-- Mathlib.Order.RelIso.Basic
#check RelHom.toFun.{u_1, u_2} /- definition missing documentation string -/
#check RelHom.map_rel'.{u_1, u_2} /- definition missing documentation string -/
#check term_→r_ /- definition missing documentation string -/
#check RelHomClass.map_rel.{u_1, u_2, u_3} /- definition missing documentation string -/
#check RelEmbedding.map_rel_iff'.{u_1, u_2} /- definition missing documentation string -/
#check term_↪r_ /- definition missing documentation string -/
#check RelIso.map_rel_iff'.{u_1, u_2} /- definition missing documentation string -/
#check term_≃r_ /- definition missing documentation string -/
/- The `simpNF` linter reports:
SOME SIMP LEMMAS ARE NOT IN SIMP-NORMAL FORM.
see note [simp-normal form] for tips how to debug this.
https://leanprover-community.github.io/mathlib_docs/notes.html#simp-normal%20form -/
-- Mathlib.Order.RelIso.Basic
#check RelEmbedding.inj.{u_2, u_1} /- simp can prove this:
by simp only [EmbeddingLike.apply_eq_iff_eq]
One of the lemmas above could be a duplicate.
If that's not the case try reordering lemmas or adding @[priority].
-/
#check RelIso.eq_iff_eq.{u_2, u_1} /- simp can prove this:
by simp only [EmbeddingLike.apply_eq_iff_eq]
One of the lemmas above could be a duplicate.
If that's not the case try reordering lemmas or adding @[priority].
-/
/- The `synTaut` linter reports:
THE FOLLOWING DECLARATIONS ARE SYNTACTIC TAUTOLOGIES. This usually means that they are of the form `∀ a b ... z, e₁ = e₂` where `e₁` and `e₂` are identical expressions. We call declarations of this form syntactic tautologies. Such lemmas are (mostly) useless and sometimes introduced unintentionally when proving basic facts using `rfl`, when elaboration results in a different term than the user intended. You should check that the declaration really says what you think it does. -/
-- Mathlib.Order.RelIso.Basic
#check RelEmbedding.to_rel_hom_eq_coe.{u_2, u_1} /- LHS equals RHS syntactically -/
#check RelEmbedding.coe_fn_to_embedding.{u_2, u_1} /- LHS equals RHS syntactically -/
#check RelIso.to_rel_embedding_eq_coe.{u_2, u_1} /- LHS equals RHS syntactically -/
#check RelIso.coe_coe_fn.{u_2, u_1} /- LHS equals RHS syntactically -/ |
|
bors d+ |
|
✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Scott Morrison <scott@tqft.net>
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
This is good to go, IMO
|
bors merge |
SHA 19091d8f2e537e76a81d1608e011dd4d03f94642 Finished the port Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded:
|
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.field.defs`: leanprover-community/mathlib4#668 * `algebra.group.commute`: leanprover-community/mathlib4#750 * `algebra.group_with_zero.commute`: leanprover-community/mathlib4#762 * `algebra.group_with_zero.semiconj`: leanprover-community/mathlib4#757 * `algebra.group_with_zero.units.basic`: leanprover-community/mathlib4#735 * `algebra.hom.embedding`: leanprover-community/mathlib4#764 * `algebra.order.monoid.cancel.defs`: leanprover-community/mathlib4#774 * `algebra.order.monoid.canonical.defs`: leanprover-community/mathlib4#778 * `algebra.order.monoid.defs`: leanprover-community/mathlib4#771 * `algebra.order.monoid.min_max`: leanprover-community/mathlib4#763 * `algebra.order.monoid.order_dual`: leanprover-community/mathlib4#786 * `algebra.order.sub.defs`: leanprover-community/mathlib4#732 * `algebra.regular.basic`: leanprover-community/mathlib4#758 * `algebra.ring.commute`: leanprover-community/mathlib4#759 * `algebra.ring.regular`: leanprover-community/mathlib4#795 * `algebra.ring.semiconj`: leanprover-community/mathlib4#751 * `control.applicative`: leanprover-community/mathlib4#798 * `control.functor`: leanprover-community/mathlib4#612 * `control.monad.basic`: leanprover-community/mathlib4#752 * `data.countable.defs`: leanprover-community/mathlib4#736 * `data.int.units`: leanprover-community/mathlib4#807 * `data.nat.basic`: leanprover-community/mathlib4#729 * `data.nat.psub`: leanprover-community/mathlib4#806 * `data.nat.units`: leanprover-community/mathlib4#805 * `data.pi.algebra`: leanprover-community/mathlib4#564 * `data.prod.lex`: leanprover-community/mathlib4#783 * `logic.embedding.basic`: leanprover-community/mathlib4#700 * `logic.equiv.option`: leanprover-community/mathlib4#674 * `order.bounded_order`: leanprover-community/mathlib4#697 * `order.with_bot`: leanprover-community/mathlib4#776 * `order.disjoint`: leanprover-community/mathlib4#773 * `order.min_max`: leanprover-community/mathlib4#728 * `order.prop_instances`: leanprover-community/mathlib4#792 * `order.rel_iso.basic`: leanprover-community/mathlib4#772
|
Sorry but what is SHA |
|
Sorry I made a mistake and used the commit hash for the mathlib3port repo. The SHA should be 76171581280d5b5d1e2d1f4f37e5420357bdc636 There was one other PR where I made this mistake. I'll check it |
mathlib3 git sha 62a5626868683c104774de8d85b9855234ac807c - [x] depends on: #772 - [x] depends on: #838 Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Gabriel Ebner <gebner@gebner.org>
SHA 76171581280d5b5d1e2d1f4f37e5420357bdc636
Finished the port