[Merged by Bors] - port logic.embedding.basic#700
Closed
Conversation
Member
|
@kbuzzard Instructions page says to make a commit with |
urkud
reviewed
Nov 24, 2022
Member
Author
|
Thanks Yury for working on this when I was asleep! I've added the commit from the mathlib3port README. This has been marked "awaiting review" but I left several TODOs in the text which are still there. |
Member
|
@kbuzzard I see 1 TODO that is still there (about |
Member
Author
|
I've added the Trans instance. This was what I was told was the appropriate replacement for the |
Mathlib/Logic/Embedding/Basic.lean
Outdated
| /-- Convert an `α ≃ β` to `α ↪ β`. | ||
|
|
||
| This is also available as a coercion `equiv.coe_embedding`. | ||
| The explicit `equiv.to_embedding` version is preferred though, since the coercion can have issues |
Contributor
There was a problem hiding this comment.
Case needs fixing (twice)
urkud
reviewed
Nov 27, 2022
urkud
reviewed
Nov 27, 2022
urkud
reviewed
Nov 27, 2022
urkud
reviewed
Nov 27, 2022
urkud
reviewed
Nov 27, 2022
urkud
reviewed
Nov 27, 2022
urkud
reviewed
Nov 27, 2022
urkud
reviewed
Nov 27, 2022
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
kim-em
reviewed
Nov 27, 2022
kim-em
reviewed
Nov 27, 2022
kim-em
reviewed
Nov 27, 2022
kim-em
reviewed
Nov 27, 2022
kim-em
reviewed
Nov 27, 2022
kim-em
reviewed
Nov 27, 2022
kim-em
reviewed
Nov 27, 2022
kim-em
reviewed
Nov 27, 2022
Contributor
|
bros merge |
|
👊 |
Contributor
|
Um, okay. :-) bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
From mathlib3port: e50b8c261b0a000b806ec0e1356b41945eda61f7 Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Scott Morrison <scott@tqft.net> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 1, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.field.defs`: leanprover-community/mathlib4#668 * `algebra.group.commute`: leanprover-community/mathlib4#750 * `algebra.group_with_zero.commute`: leanprover-community/mathlib4#762 * `algebra.group_with_zero.semiconj`: leanprover-community/mathlib4#757 * `algebra.group_with_zero.units.basic`: leanprover-community/mathlib4#735 * `algebra.hom.embedding`: leanprover-community/mathlib4#764 * `algebra.order.monoid.cancel.defs`: leanprover-community/mathlib4#774 * `algebra.order.monoid.canonical.defs`: leanprover-community/mathlib4#778 * `algebra.order.monoid.defs`: leanprover-community/mathlib4#771 * `algebra.order.monoid.min_max`: leanprover-community/mathlib4#763 * `algebra.order.monoid.order_dual`: leanprover-community/mathlib4#786 * `algebra.order.sub.defs`: leanprover-community/mathlib4#732 * `algebra.regular.basic`: leanprover-community/mathlib4#758 * `algebra.ring.commute`: leanprover-community/mathlib4#759 * `algebra.ring.regular`: leanprover-community/mathlib4#795 * `algebra.ring.semiconj`: leanprover-community/mathlib4#751 * `control.applicative`: leanprover-community/mathlib4#798 * `control.functor`: leanprover-community/mathlib4#612 * `control.monad.basic`: leanprover-community/mathlib4#752 * `data.countable.defs`: leanprover-community/mathlib4#736 * `data.int.units`: leanprover-community/mathlib4#807 * `data.nat.basic`: leanprover-community/mathlib4#729 * `data.nat.psub`: leanprover-community/mathlib4#806 * `data.nat.units`: leanprover-community/mathlib4#805 * `data.pi.algebra`: leanprover-community/mathlib4#564 * `data.prod.lex`: leanprover-community/mathlib4#783 * `logic.embedding.basic`: leanprover-community/mathlib4#700 * `logic.equiv.option`: leanprover-community/mathlib4#674 * `order.bounded_order`: leanprover-community/mathlib4#697 * `order.with_bot`: leanprover-community/mathlib4#776 * `order.disjoint`: leanprover-community/mathlib4#773 * `order.min_max`: leanprover-community/mathlib4#728 * `order.prop_instances`: leanprover-community/mathlib4#792 * `order.rel_iso.basic`: leanprover-community/mathlib4#772
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From mathlib3port: e50b8c261b0a000b806ec0e1356b41945eda61f7