Skip to content

[Merged by Bors] - feat: amalgamated products of groups#6803

Closed
ChrisHughes24 wants to merge 159 commits intomasterfrom
AmalgamatedProductChris
Closed

[Merged by Bors] - feat: amalgamated products of groups#6803
ChrisHughes24 wants to merge 159 commits intomasterfrom
AmalgamatedProductChris

Conversation

@ChrisHughes24 ChrisHughes24 added the WIP Work in progress label Aug 26, 2023
@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 26, 2023
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 27, 2023
@riccardobrasca
Copy link
Copy Markdown
Member

I am not very familiar with the mathematics, can you explain a little bit what is the point of the main theorem?

@ChrisHughes24
Copy link
Copy Markdown
Member Author

I am not very familiar with the mathematics, can you explain a little bit what is the point of the main theorem?

There's a normal form (and reduced form) for words in the amalgamated product. The main application of this is that it implies the injectivity of the maps into the amalgamated product and the theorem inf_of_range_eq_base_range.

Other than that, I don't directly know any applications, but the similar result about reduced forms for HNNExtensions is used to prove things like the decision procedure for groups presented by a single relation.

So I suppose it's useful to know this reduced form theorem, because then you know a lot about which words are equal to each other, and which words are in the base subgroup and things like this, but I couldn't say anything more concrete.

Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maths look great, I would just be happy to see more documentation (featuring prominently the word "amalgamated product" here and there, because it's the name I know for these objects, not the categorical ones pushouts or coproducts, but I realize it's a question of personal taste or personal culture -- but it would be good to make sure that anyone with any culture can find this with a good old grep).

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Nov 8, 2023
ChrisHughes24 and others added 7 commits November 14, 2023 10:59
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@ChrisHughes24
Copy link
Copy Markdown
Member Author

The maths look great, I would just be happy to see more documentation (featuring prominently the word "amalgamated product" here and there, because it's the name I know for these objects, not the categorical ones pushouts or coproducts, but I realize it's a question of personal taste or personal culture -- but it would be good to make sure that anyone with any culture can find this with a good old grep).

I chose the word pushout, because as far as I know, the phrase amalgamated product only refers to the case when all maps in the diagram are injective. This is basically the interesting case, but the construction works the rest of the time.

@ChrisHughes24 ChrisHughes24 added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 14, 2023
@sgouezel
Copy link
Copy Markdown
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 14, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 14, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 14, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: amalgamated products of groups [Merged by Bors] - feat: amalgamated products of groups Nov 14, 2023
@mathlib-bors mathlib-bors bot closed this Nov 14, 2023
@mathlib-bors mathlib-bors bot deleted the AmalgamatedProductChris branch November 14, 2023 16:01
alexkeizer pushed a commit that referenced this pull request Nov 17, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
alexkeizer pushed a commit that referenced this pull request Nov 21, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
grunweg pushed a commit that referenced this pull request Dec 15, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants