Skip to content

[Merged by Bors] - feat: Binary coproducts of Monoids#6828

Closed
ChrisHughes24 wants to merge 14 commits intomasterfrom
BinaryFreeProdChris
Closed

[Merged by Bors] - feat: Binary coproducts of Monoids#6828
ChrisHughes24 wants to merge 14 commits intomasterfrom
BinaryFreeProdChris

Conversation

@ChrisHughes24
Copy link
Copy Markdown
Member

@ChrisHughes24 ChrisHughes24 commented Aug 28, 2023


I put it in SpecificGroups where maybe CoprodI should be moved as well.

Open in Gitpod

@ChrisHughes24 ChrisHughes24 added the WIP Work in progress label Aug 28, 2023
@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 28, 2023
@ChrisHughes24 ChrisHughes24 added awaiting-review and removed WIP Work in progress labels Aug 29, 2023
@ChrisHughes24 ChrisHughes24 removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 31, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file looks good to me. But I think SpecificGroups is meant for constructions/definitions of well-known "specific" (typically finite) groups.

Constructions like quotient groups, products, coproducts, etc... can just go into GroupTheory, I think. So I suggest moving the file one level up.

@ChrisHughes24
Copy link
Copy Markdown
Member Author

The file looks good to me. But I think SpecificGroups is meant for constructions/definitions of well-known "specific" (typically finite) groups.

Constructions like quotient groups, products, coproducts, etc... can just go into GroupTheory, I think. So I suggest moving the file one level up.

done

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Sep 4, 2023
bors bot pushed a commit that referenced this pull request Sep 4, 2023
@bors
Copy link
Copy Markdown

bors bot commented Sep 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Binary coproducts of Monoids [Merged by Bors] - feat: Binary coproducts of Monoids Sep 4, 2023
@bors bors bot closed this Sep 4, 2023
@bors bors bot deleted the BinaryFreeProdChris branch September 4, 2023 17:35
ebab pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants