Skip to content

[Merged by Bors] - perf: change one instance in coprods of groups#7292

Closed
ChrisHughes24 wants to merge 1 commit intomasterfrom
CoprodInstanceCH
Closed

[Merged by Bors] - perf: change one instance in coprods of groups#7292
ChrisHughes24 wants to merge 1 commit intomasterfrom
CoprodInstanceCH

Conversation

@ChrisHughes24
Copy link
Copy Markdown
Member


This fixed a simp failure in #6803 . If it is defined like this, then there is no need to unfold Con.monoid when checking defeq.

Open in Gitpod

@mattrobball
Copy link
Copy Markdown
Contributor

mattrobball commented Sep 21, 2023

Two other possibilities:

  • reducible (not sure how much you have to make it though)
  • { Con.monoid _ with } should do what you did manually

@ChrisHughes24
Copy link
Copy Markdown
Member Author

ChrisHughes24 commented Sep 21, 2023

Two other possibilities:

  • reducible (not sure how much you have to make it though)
  • { Con.monoid _ with } should do what you did manually

{ Con.monoid _ with } doesn't do the same thing, because it doesn't use the existing MulOneClass instance to fill in the Mul and One fields, so you still have to unfold Con.monoid to check the defeq. This approach does not fix the simp failure.
I think Con.monoid should already be reducible since it's an instance.

@mattrobball
Copy link
Copy Markdown
Contributor

mattrobball commented Sep 21, 2023

It looks like leanprover/lean4#2478 will fix the timeouts in #6803 without modifying the instance (it was probably unifying against something that was improperly unfolded to start with). There is #7257 to test out yourself in case I merged something oddly.

@ChrisHughes24
Copy link
Copy Markdown
Member Author

I did try merging my amalgamated products PR into #7257. It seemed to fix the timeout at the end, but not the simp failure nearer the start of the file. It still failed to simplify inl 1 to 1.

@sgouezel
Copy link
Copy Markdown
Contributor

sgouezel commented Oct 4, 2023

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Oct 4, 2023
bors bot pushed a commit that referenced this pull request Oct 4, 2023
@bors
Copy link
Copy Markdown

bors bot commented Oct 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title perf: change one instance in coprods of groups [Merged by Bors] - perf: change one instance in coprods of groups Oct 4, 2023
@bors bors bot closed this Oct 4, 2023
@bors bors bot deleted the CoprodInstanceCH branch October 4, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants