[Merged by Bors] - feat(GroupTheory/CoprodI): add various things#6900
Closed
ChrisHughes24 wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - feat(GroupTheory/CoprodI): add various things#6900ChrisHughes24 wants to merge 7 commits intomasterfrom
ChrisHughes24 wants to merge 7 commits intomasterfrom
Conversation
9 tasks
jcommelin
approved these changes
Sep 6, 2023
Mathlib/GroupTheory/CoprodI.lean
Outdated
| instance : MulAction (CoprodI M) (Word M) := | ||
| MulAction.ofEndHom (lift fun _ => MulAction.toEndHom) | ||
|
|
||
| theorem smul_def (i) (w : Word M) (m : M i) : |
Member
There was a problem hiding this comment.
In the LHS m occurs before w. Do you think it makes sense to also place m before w in the list of arguments?
|
✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
The main changes made here were - Adding a `cons` constructor to make a new word where the underlying list is just `cons`. Use this to simplify the definition of `rcons` - Defining a `consRecOn` induction principle and use this to simpllify the definition of `equivPairAux`, allowing me to delete the private def `mkAux` - Some lemmas about being an element of `rcons` and `smul`
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
ebab
pushed a commit
that referenced
this pull request
Sep 11, 2023
The main changes made here were - Adding a `cons` constructor to make a new word where the underlying list is just `cons`. Use this to simplify the definition of `rcons` - Defining a `consRecOn` induction principle and use this to simpllify the definition of `equivPairAux`, allowing me to delete the private def `mkAux` - Some lemmas about being an element of `rcons` and `smul`
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
The main changes made here were - Adding a `cons` constructor to make a new word where the underlying list is just `cons`. Use this to simplify the definition of `rcons` - Defining a `consRecOn` induction principle and use this to simpllify the definition of `equivPairAux`, allowing me to delete the private def `mkAux` - Some lemmas about being an element of `rcons` and `smul`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main changes made here were
consconstructor to make a new word where the underlying list is justcons. Use this to simplify the definition ofrconsconsRecOninduction principle and use this to simpllify the definition ofequivPairAux, allowing me to delete the private defmkAuxrconsandsmulThe main motivation for this PR is the work on Amalgamated Products of Groups in #6803