[Merged by Bors] - perf(GroupTheory/CoprodI): Get rid of one use of with in an instance#6830
Closed
ChrisHughes24 wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - perf(GroupTheory/CoprodI): Get rid of one use of with in an instance#6830ChrisHughes24 wants to merge 2 commits intomasterfrom
ChrisHughes24 wants to merge 2 commits intomasterfrom
Conversation
Member
ChrisHughes24
commented
Aug 28, 2023
mattrobball
reviewed
Aug 30, 2023
Contributor
mattrobball
left a comment
There was a problem hiding this comment.
Why not delete the toInv and toMonoid fields? Lean will do the inferInstance as part of its passes in building the structure instance.
Member
Author
Done |
9 tasks
bors bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
…6830) Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
ebab
pushed a commit
that referenced
this pull request
Sep 11, 2023
…6830) Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
…6830) Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.