[Merged by Bors] - feat(NumberTheory): IsDiscreteValuationRing (v.adicCompletionIntegers K)#27117
Closed
pechersky wants to merge 14 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(NumberTheory): IsDiscreteValuationRing (v.adicCompletionIntegers K)#27117pechersky wants to merge 14 commits intoleanprover-community:masterfrom
IsDiscreteValuationRing (v.adicCompletionIntegers K)#27117pechersky wants to merge 14 commits intoleanprover-community:masterfrom
Conversation
for both the base valuation and the one on the extension
helper lemma to get access to prop-style properties of valuation integer ring
This reverts commit 9ad20ac.
…ingleton` and general DenselyOrdered API and instances needed for showing that valuations mapping into Zm0 are discrete and thus DVR
for proving that it is not densely ordered for PIR -> DVR for valuations
simplifies coercions and golfs existing instance
…s K)` as well as the base ring that is not completed the proofs are basically identical which means there is some missing API but this is the shortest route to getting local fields ready and showing that `K_v` is locally compact
PR summary 0775e914be
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.NumberField.FinitePlaces | 2809 | 2816 | +7 (+0.25%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.NumberField.FinitePlaces Mathlib.NumberTheory.NumberField.ProductFormula |
7 |
Declarations diff
+ instance : IsDiscreteValuationRing (v.adicCompletionIntegers K)
+ instance : IsDiscreteValuationRing (v.valuation K).integer
+ instance : IsPrincipalIdealRing (v.adicCompletionIntegers K) := by
+ instance : IsPrincipalIdealRing (v.valuation K).integer := by
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
IsDiscreteValuationRing (v.adicCompletionIntegers K)
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
…ial (#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in #27112. Together, it is used in #27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Collaborator
|
This pull request has conflicts, please merge |
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Jul 16, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Collaborator
Collaborator
|
This pull request has conflicts, please merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 1, 2025
…s K)` (#27117) as well as the base ring that is not completed the proofs are basically identical which means there is some missing API but this is the shortest route to getting local fields ready and showing that `K_v` is locally compact
Contributor
|
Pull request successfully merged into master. Build succeeded: |
IsDiscreteValuationRing (v.adicCompletionIntegers K)IsDiscreteValuationRing (v.adicCompletionIntegers K)
CBirkbeck
pushed a commit
to CBirkbeck/mathlib4
that referenced
this pull request
Sep 8, 2025
…s K)` (leanprover-community#27117) as well as the base ring that is not completed the proofs are basically identical which means there is some missing API but this is the shortest route to getting local fields ready and showing that `K_v` is locally compact
yuanyi-350
pushed a commit
to yuanyi-350/yuanyi_mathlib4
that referenced
this pull request
Sep 10, 2025
…s K)` (leanprover-community#27117) as well as the base ring that is not completed the proofs are basically identical which means there is some missing API but this is the shortest route to getting local fields ready and showing that `K_v` is locally compact
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Oct 2, 2025
…s K)` (leanprover-community#27117) as well as the base ring that is not completed the proofs are basically identical which means there is some missing API but this is the shortest route to getting local fields ready and showing that `K_v` is locally compact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as well as the base ring that is not completed
the proofs are basically identical
which means there is some missing API
but this is the shortest route to
getting local fields ready
and showing that
K_vis locally compactInt.set_denselyOrdered_iff_subsingleton#27112