Skip to content

[Merged by Bors] - chore(RingTheory/ValuationSubring): valuationSubring_integers#27111

Closed
pechersky wants to merge 3 commits intoleanprover-community:masterfrom
pechersky:val-subring-integers
Closed

[Merged by Bors] - chore(RingTheory/ValuationSubring): valuationSubring_integers#27111
pechersky wants to merge 3 commits intoleanprover-community:masterfrom
pechersky:val-subring-integers

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

helper lemma to get access to prop-style properties of valuation integer ring


Open in Gitpod

for both the base valuation and the one on the extension
helper lemma to get access to prop-style properties of valuation integer ring
@pechersky pechersky added easy < 20s of review time. See the lifecycle page for guidelines. t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields, etc) labels Jul 14, 2025
@github-actions
Copy link
Copy Markdown

PR summary d17cce2246

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ valuationSubring.integers

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adamtopaz
Copy link
Copy Markdown
Contributor

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jul 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jul 14, 2025
helper lemma to get access to prop-style properties of valuation integer ring
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/ValuationSubring): valuationSubring_integers [Merged by Bors] - chore(RingTheory/ValuationSubring): valuationSubring_integers Jul 14, 2025
@mathlib-bors mathlib-bors bot closed this Jul 14, 2025
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Jul 16, 2025
…over-community#27111)

helper lemma to get access to prop-style properties of valuation integer ring
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
…over-community#27111)

helper lemma to get access to prop-style properties of valuation integer ring
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
…over-community#27111)

helper lemma to get access to prop-style properties of valuation integer ring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants