feat(GroupTheory/ArchimedeanDensely) Int.set_denselyOrdered_iff_subsingleton#27112
Closed
pechersky wants to merge 24 commits intoleanprover-community:masterfrom
Closed
feat(GroupTheory/ArchimedeanDensely) Int.set_denselyOrdered_iff_subsingleton#27112pechersky wants to merge 24 commits intoleanprover-community:masterfrom
Int.set_denselyOrdered_iff_subsingleton#27112pechersky wants to merge 24 commits intoleanprover-community:masterfrom
Conversation
…ingleton` and general DenselyOrdered API and instances needed for showing that valuations mapping into Zm0 are discrete and thus DVR
PR summary b440801025Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Thanks! Some questions below
Contributor
Author
|
In thinking about it, these lemmas are really about linear LocallyFiniteOrder. I have generalizations which also help golf. Will push them tomorrow. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
…ial (#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in #27112. Together, it is used in #27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
A helper lemma, in the style of `denselyOrdered_iff_of_orderIsoClass` but slightly weaker (needs LinearOrder), but works to transport across order-dual types like WithBot (X^od) to WithBot X
…orders are trivial
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Jul 16, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
This reverts commit 843e33b.
4 tasks
Collaborator
|
This pull request has conflicts, please merge |
Collaborator
|
This pull request has conflicts, please merge |
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Collaborator
|
This PR/issue depends on: |
Contributor
Author
|
Superseded by #27172 |
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and general DenselyOrdered API and instances
needed for showing that valuations mapping into Zm0 are discrete and thus DVR