[Merged by Bors] - feat(Algebra/GroupWithZero/Range): MonoidWithZeroHom.(m)range_nontrivial#27114
Closed
pechersky wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(Algebra/GroupWithZero/Range): MonoidWithZeroHom.(m)range_nontrivial#27114pechersky wants to merge 2 commits intoleanprover-community:masterfrom
pechersky wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
for proving that it is not densely ordered for PIR -> DVR for valuations
PR summary d17cce2246Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Closed
4 tasks
YaelDillies
approved these changes
Jul 14, 2025
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Your PR description is a bit cryptic. Mind expanding?
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
…ial (#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in #27112. Together, it is used in #27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Jul 16, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
…ial (leanprover-community#27114) for proving that it is not densely ordered for PIR -> DVR for valuations Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in leanprover-community#27112. Together, it is used in leanprover-community#27117 to show that a Zm0-valued valuation's subring is a DVR. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for proving that it is not densely ordered
for PIR -> DVR for valuations
Since this is a nontrivial set, then it can't be densely ordered when the codomain is Zm0, as shown in #27112. Together, it is used in #27117 to show that a Zm0-valued valuation's subring is a DVR.