Skip to content

[Merged by Bors] - feat(Valued): FaithfulSMul to completion#27116

Closed
pechersky wants to merge 4 commits intoleanprover-community:masterfrom
pechersky:valued-faithful-smul-adic
Closed

[Merged by Bors] - feat(Valued): FaithfulSMul to completion#27116
pechersky wants to merge 4 commits intoleanprover-community:masterfrom
pechersky:valued-faithful-smul-adic

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

@pechersky pechersky commented Jul 14, 2025

simplifies coercions and golfs existing instance

Open in Gitpod

@pechersky
feat(Valued): FaithfulSMul to completion
8074dd8 
simplifies coercions and golfs existing instance
@pechersky pechersky added t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-analysis Analysis (normed *, calculus) t-algebra Algebra (groups, rings, fields, etc) labels Jul 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 14, 2025 •
edited
Loading

PR summary b440801025

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ algebraMap_adicCompletionIntegers_apply
+ instance [FaithfulSMul R K] : FaithfulSMul R (v.adicCompletionIntegers K) := by
+ instance {R : Type*} [CommSemiring R] [Algebra R K] [UniformContinuousConstSMul R K]

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@pechersky pechersky mentioned this pull request Jul 14, 2025
Closed
4 tasks
mariainesdff
mariainesdff reviewed Aug 7, 2025
View reviewed changes
@mariainesdff
Copy link
Copy Markdown
Contributor

mariainesdff commented Aug 7, 2025

Thanks!
maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 7, 2025

🚀 Pull request has been placed on the maintainer queue by mariainesdff.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 7, 2025
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Aug 7, 2025

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 7, 2025

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Aug 7, 2025
@pechersky @mariainesdff
Update Mathlib/RingTheory/DedekindDomain/AdicValuation.lean
237d14c 
Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
@pechersky
Copy link
Copy Markdown
Contributor Author

pechersky commented Aug 7, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 7, 2025
@pechersky
feat(Valued): FaithfulSMul to completion (#27116)
cd9f3f6 
simplifies coercions and golfs existing instance




Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 7, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Valued): FaithfulSMul to completion [Merged by Bors] - feat(Valued): FaithfulSMul to completion Aug 7, 2025
@mathlib-bors mathlib-bors bot closed this Aug 7, 2025
staroperator pushed a commit to staroperator/mathlib4 that referenced this pull request Aug 8, 2025
@pechersky @staroperator
feat(Valued): FaithfulSMul to completion (leanprover-community#27116)
de5fc1e 
simplifies coercions and golfs existing instance




Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@pechersky @Paul-Lez
feat(Valued): FaithfulSMul to completion (leanprover-community#27116)
5135460 
simplifies coercions and golfs existing instance




Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@pechersky @Paul-Lez
feat(Valued): FaithfulSMul to completion (leanprover-community#27116)
2a64ff0 
simplifies coercions and golfs existing instance




Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariainesdff mariainesdff mariainesdff left review comments

Assignees

@mariainesdff mariainesdff

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc) t-analysis Analysis (normed *, calculus) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pechersky @mariainesdff @ocfnash