Skip to content

[Merged by Bors] - chore(*): add @[fun_prop]#22183

Closed
urkud wants to merge 2 commits intomasterfrom
YK-fun-prop
Closed

[Merged by Bors] - chore(*): add @[fun_prop]#22183
urkud wants to merge 2 commits intomasterfrom
YK-fun-prop

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Feb 22, 2025

Also use fun_prop here and there to golf proofs.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 22, 2025

PR summary 2c8cb1167d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.01)
Current number Change Type
3362 -1 porting notes
104 -1 adaptation notes

Current commit 2c8cb1167d
Reference commit 8d0660f3c5

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@[fun_prop]
theorem Continuous.vsub {f g : α → P} (hf : Continuous f) (hg : Continuous g) :
Continuous (f -ᵥ g) :=
Continuous (fun x ↦ f x -ᵥ g x) :=
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This form works better with fun_prop.

Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks for doing this!


@[continuity]
@[continuity, fun_prop]
theorem continuous_arccos : Continuous arccos :=
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add the ContinuousAt version?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun_prop can use Continuous to prove ContinuousAt. I'll add the usual dot notation lemmas in another PR (added to my TODO list).

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 22, 2025

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 22, 2025
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Feb 22, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 22, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 22, 2025
Also use `fun_prop` here and there to golf proofs.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(*): add @[fun_prop] [Merged by Bors] - chore(*): add @[fun_prop] Feb 22, 2025
@mathlib-bors mathlib-bors bot closed this Feb 22, 2025
@mathlib-bors mathlib-bors bot deleted the YK-fun-prop branch February 22, 2025 15:02
Julian added a commit that referenced this pull request Feb 22, 2025
* origin/master:
  chore(*): add `@[fun_prop]` (#22183)
  chore(RingTheory): generalize universes for `isUnramified_iff_map_eq` (#22185)
  chore(Algebra/GroupPower/IterateHom): move all lemmas earlier (#22132)
  feat(Probability): ae filter and integrability wrt a composition of kernel and measure (#22074)
  feat(CategoryTheory): forgetting the group structure on the codomain of left-exact functors (#21973)
  feat(CategoryTheory): embeddings for opposites of Grothendieck abelian categories (#22182)
  feat(CategoryTheory): `AsSmall C` is abelian (#22184)
  feat(CategoryTheory): explicit argument versions of `epi_comp` and `mono_comp` (#22181)
  feat(Topology/Instances/EReal/Lemmas): add lemmas about limsup and multiplication (#21833)
  feat: basic structural lemmas about finite crystallographic root pairings. (#21932)
  Rename `Mem𝓛p` to `MemLp` (#22164)
  feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types (#21518)
  feat(CategoryTheory): Grothendieck abelian categories have enough injectives (#20079)
  chore: deprecate Finite.cast_card_eq_mk (#22161)
  feat(CategoryTheory/Limits/Fubini): relax `HasLimits` hypotheses (#20570)
  chore(Algebra/Order/Monoid/Unbundled/WithTop): golf, clean up (#22109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants