Skip to content

[Merged by Bors] - feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types#21518

Closed
Timeroot wants to merge 3 commits intomasterfrom
dep_arrowProdEquivProdArrow
Closed

[Merged by Bors] - feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types#21518
Timeroot wants to merge 3 commits intomasterfrom
dep_arrowProdEquivProdArrow

Conversation

@Timeroot
Copy link
Copy Markdown
Collaborator

@Timeroot Timeroot commented Feb 6, 2025

This meant the order of arguments had to change a bit, but besides that I think this is strictly more flexible without sacrificing meaningful usability. Also added @[simps].

Upstreamed from quantumInfo


Open in Gitpod

@Timeroot Timeroot added the t-logic Logic (model theory, etc) label Feb 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2025

PR summary eb6fe6de6f

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.MeasureTheory.MeasurableSpace.Embedding 684 687 +3 (+0.44%)
Import changes for all files
Files Import difference
3 files Mathlib.MeasureTheory.MeasurableSpace.CountablyGenerated Mathlib.MeasureTheory.MeasurableSpace.Embedding Mathlib.MeasureTheory.MeasurableSpace.Prod
3

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.01)
Current number Change Type
107 -1 adaptation notes

Current commit eb6fe6de6f
Reference commit 1021444ee8

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Timeroot Timeroot marked this pull request as ready for review February 6, 2025 17:29
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Feb 21, 2025

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 21, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 21, 2025
…#21518)

This meant the order of arguments had to change a bit, but besides that I think this is strictly more flexible without sacrificing meaningful usability. Also added `@[simps]`.

Upstreamed from quantumInfo



Co-authored-by: Alex Meiburg <timeroot.alex@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types [Merged by Bors] - feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types Feb 21, 2025
@mathlib-bors mathlib-bors bot closed this Feb 21, 2025
@mathlib-bors mathlib-bors bot deleted the dep_arrowProdEquivProdArrow branch February 21, 2025 17:52
Julian added a commit that referenced this pull request Feb 22, 2025
* origin/master:
  chore(*): add `@[fun_prop]` (#22183)
  chore(RingTheory): generalize universes for `isUnramified_iff_map_eq` (#22185)
  chore(Algebra/GroupPower/IterateHom): move all lemmas earlier (#22132)
  feat(Probability): ae filter and integrability wrt a composition of kernel and measure (#22074)
  feat(CategoryTheory): forgetting the group structure on the codomain of left-exact functors (#21973)
  feat(CategoryTheory): embeddings for opposites of Grothendieck abelian categories (#22182)
  feat(CategoryTheory): `AsSmall C` is abelian (#22184)
  feat(CategoryTheory): explicit argument versions of `epi_comp` and `mono_comp` (#22181)
  feat(Topology/Instances/EReal/Lemmas): add lemmas about limsup and multiplication (#21833)
  feat: basic structural lemmas about finite crystallographic root pairings. (#21932)
  Rename `Mem𝓛p` to `MemLp` (#22164)
  feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types (#21518)
  feat(CategoryTheory): Grothendieck abelian categories have enough injectives (#20079)
  chore: deprecate Finite.cast_card_eq_mk (#22161)
  feat(CategoryTheory/Limits/Fubini): relax `HasLimits` hypotheses (#20570)
  chore(Algebra/Order/Monoid/Unbundled/WithTop): golf, clean up (#22109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants