[Merged by Bors] - chore(Algebra/GroupPower/IterateHom): move all lemmas earlier#22132
Closed
YaelDillies wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore(Algebra/GroupPower/IterateHom): move all lemmas earlier#22132YaelDillies wants to merge 3 commits intomasterfrom
YaelDillies wants to merge 3 commits intomasterfrom
Conversation
All lemmas in this file belong earlier. This finally gets rid of the `Algebra.GroupPower` folder, notorious for having caused imports increases in the algebra library.
PR summary bee20fd977
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.GroupPower.IterateHom | 324 | 0 | -324 (-100.00%) |
| Mathlib.Algebra.Group.Basic | 105 | 107 | +2 (+1.90%) |
| Mathlib.Algebra.Group.Commute.Basic | 109 | 111 | +2 (+1.83%) |
| Mathlib.Algebra.Regular.Pow | 468 | 462 | -6 (-1.28%) |
| Mathlib.GroupTheory.Perm.Basic | 389 | 385 | -4 (-1.03%) |
| Mathlib.Data.Set.Pointwise.Iterate | 451 | 448 | -3 (-0.67%) |
| Mathlib.Algebra.CharP.Lemmas | 793 | 791 | -2 (-0.25%) |
| Mathlib.Algebra.Module.LinearMap.End | 447 | 446 | -1 (-0.22%) |
| Mathlib.Algebra.AddConstMap.Basic | 641 | 640 | -1 (-0.16%) |
| Mathlib.Algebra.Algebra.Bilinear | 793 | 792 | -1 (-0.13%) |
| Mathlib.GroupTheory.FixedPointFree | 961 | 960 | -1 (-0.10%) |
| Mathlib.Dynamics.Circle.RotationNumber.TranslationNumber | 1336 | 1335 | -1 (-0.07%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 3158 files with changed transitive imports taking up over 138998 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
+ mul_left_iterate_apply_one
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type |
|---|---|---|
| 3362 | -1 | porting notes |
Current commit bee20fd977
Reference commit 4fba8dcf8e
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Closed
1 task
eric-wieser
reviewed
Feb 20, 2025
eric-wieser
reviewed
Feb 20, 2025
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Can you elaborate on why the GroupPower folder was a bad idea, rather than saying it is notorious for having been one? I believe you, but let's leave a useful message for future readers.
One explanation might be that npow is part of the definition of Group itself, so moving results about it downstream don't make any sense any more. Another explanation is that GroupPower was created when this was not the case.
Vierkantor
approved these changes
Feb 22, 2025
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
Agreed with Eric: the numbers look good but I'd like a bit more motivation for why this file specifically.
Contributor
Author
|
I've added motivation in the PR description already (the cf) |
Contributor
|
Ah, I see! I didn't notice that you meaant the motivation is explained there. I agree then with what it says, but maybe in case others are confused could you make it a bit clearer that te motiation is the same as in #11855? bors d+ |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Clarified! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2025
All lemmas in this file belong earlier. This finally gets rid of the `Algebra.GroupPower` folder, notorious for having caused imports increases in the algebra library (see #11855 for full motivation).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Julian
added a commit
that referenced
this pull request
Feb 22, 2025
* origin/master: chore(*): add `@[fun_prop]` (#22183) chore(RingTheory): generalize universes for `isUnramified_iff_map_eq` (#22185) chore(Algebra/GroupPower/IterateHom): move all lemmas earlier (#22132) feat(Probability): ae filter and integrability wrt a composition of kernel and measure (#22074) feat(CategoryTheory): forgetting the group structure on the codomain of left-exact functors (#21973) feat(CategoryTheory): embeddings for opposites of Grothendieck abelian categories (#22182) feat(CategoryTheory): `AsSmall C` is abelian (#22184) feat(CategoryTheory): explicit argument versions of `epi_comp` and `mono_comp` (#22181) feat(Topology/Instances/EReal/Lemmas): add lemmas about limsup and multiplication (#21833) feat: basic structural lemmas about finite crystallographic root pairings. (#21932) Rename `Mem𝓛p` to `MemLp` (#22164) feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types (#21518) feat(CategoryTheory): Grothendieck abelian categories have enough injectives (#20079) chore: deprecate Finite.cast_card_eq_mk (#22161) feat(CategoryTheory/Limits/Fubini): relax `HasLimits` hypotheses (#20570) chore(Algebra/Order/Monoid/Unbundled/WithTop): golf, clean up (#22109)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All lemmas in this file belong earlier. This finally gets rid of the
Algebra.GroupPowerfolder, notorious for having caused imports increases in the algebra library (see #11855 for full motivation).