Skip to content

[Merged by Bors] - chore: deprecate Finite.cast_card_eq_mk#22161

Closed
fpvandoorn wants to merge 2 commits intomasterfrom
cast_card_eq_mk-dep
Closed

[Merged by Bors] - chore: deprecate Finite.cast_card_eq_mk#22161
fpvandoorn wants to merge 2 commits intomasterfrom
cast_card_eq_mk-dep

Conversation

@fpvandoorn
Copy link
Copy Markdown
Member

@fpvandoorn fpvandoorn commented Feb 21, 2025

(the noshake is necessary)


Open in Gitpod

@fpvandoorn fpvandoorn added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Feb 21, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 21, 2025

PR summary 6a71e24a9b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Feb 21, 2025
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 21, 2025
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Feb 21, 2025

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 21, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 21, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: deprecate Finite.cast_card_eq_mk [Merged by Bors] - chore: deprecate Finite.cast_card_eq_mk Feb 21, 2025
@mathlib-bors mathlib-bors bot closed this Feb 21, 2025
@mathlib-bors mathlib-bors bot deleted the cast_card_eq_mk-dep branch February 21, 2025 16:35
Julian added a commit that referenced this pull request Feb 22, 2025
* origin/master:
  chore(*): add `@[fun_prop]` (#22183)
  chore(RingTheory): generalize universes for `isUnramified_iff_map_eq` (#22185)
  chore(Algebra/GroupPower/IterateHom): move all lemmas earlier (#22132)
  feat(Probability): ae filter and integrability wrt a composition of kernel and measure (#22074)
  feat(CategoryTheory): forgetting the group structure on the codomain of left-exact functors (#21973)
  feat(CategoryTheory): embeddings for opposites of Grothendieck abelian categories (#22182)
  feat(CategoryTheory): `AsSmall C` is abelian (#22184)
  feat(CategoryTheory): explicit argument versions of `epi_comp` and `mono_comp` (#22181)
  feat(Topology/Instances/EReal/Lemmas): add lemmas about limsup and multiplication (#21833)
  feat: basic structural lemmas about finite crystallographic root pairings. (#21932)
  Rename `Mem𝓛p` to `MemLp` (#22164)
  feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types (#21518)
  feat(CategoryTheory): Grothendieck abelian categories have enough injectives (#20079)
  chore: deprecate Finite.cast_card_eq_mk (#22161)
  feat(CategoryTheory/Limits/Fubini): relax `HasLimits` hypotheses (#20570)
  chore(Algebra/Order/Monoid/Unbundled/WithTop): golf, clean up (#22109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants