[Merged by Bors] - chore(Algebra/Order/Monoid/Unbundled/WithTop): golf, clean up#22109
Closed
YaelDillies wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore(Algebra/Order/Monoid/Unbundled/WithTop): golf, clean up#22109YaelDillies wants to merge 4 commits intomasterfrom
YaelDillies wants to merge 4 commits intomasterfrom
Conversation
* Shorten proofs * Make the `WithBot` and `WithTop` sections analogous * Avoid relying on the defeq `(WithTop α)ᵒᵈ = WithBot αᵒᵈ` * Pull more implicit variables to `variable` statements * Stick to the convention that `a b : α` and `x y : WithBot α` This is a follow-up to #21274.
4 tasks
PR summary 62656212bf
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Monoid.Unbundled.WithTop | 213 | 215 | +2 (+0.94%) |
| Mathlib.Algebra.Order.AddGroupWithTop | 230 | 232 | +2 (+0.87%) |
Import changes for all files
| Files | Import difference |
|---|---|
4 filesMathlib.Algebra.Order.PUnit Mathlib.Algebra.Order.SuccPred.WithBot Mathlib.RingTheory.HahnSeries.Addition Mathlib.RingTheory.HahnSeries.Basic |
-2 |
9 filesMathlib.Algebra.BigOperators.WithTop Mathlib.Algebra.Order.Ring.WithTop Mathlib.Combinatorics.SimpleGraph.Diam Mathlib.Combinatorics.SimpleGraph.Metric Mathlib.Data.ENat.Basic Mathlib.Data.ENat.Lattice Mathlib.NumberTheory.Padics.PadicVal.Defs Mathlib.Order.Height Mathlib.RingTheory.Multiplicity |
-1 |
5 filesMathlib.Algebra.Order.AddGroupWithTop Mathlib.Algebra.Order.Monoid.Unbundled.WithTop Mathlib.Algebra.Order.Monoid.WithTop Mathlib.Algebra.Order.Sub.WithTop Mathlib.Data.Nat.Cast.WithTop |
2 |
Declarations diff
+ addLECancellable_coe
+ addLECancellable_iff_ne_bot
+ addLECancellable_of_lt_bot
+ addLECancellable_of_ne_bot
++ add_left_inj
++ add_right_inj
++-- add_le_add_iff_left
++-- add_le_add_iff_right
++-- add_left_cancel
++-- add_left_cancel_iff
++-- add_lt_add_iff_left
++-- add_lt_add_iff_right
++-- add_lt_add_left
++-- add_lt_add_right
++-- add_right_cancel
++-- add_right_cancel_iff
++-- le_of_add_le_add_left
++-- le_of_add_le_add_right
-+-+ addLeftMono
-+-+ addLeftReflectLT
-+-+ addRightMono
-+-+ addRightReflectLT
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
* Shorten proofs * Make the `WithBot` and `WithTop` sections analogous * Avoid relying on the defeq `(WithTop α)ᵒᵈ = WithBot αᵒᵈ` * Pull more implicit variables to `variable` statements * Stick to the convention that `a b : α` and `x y : WithBot α` This is a follow-up to #21274.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Julian
added a commit
that referenced
this pull request
Feb 22, 2025
* origin/master: chore(*): add `@[fun_prop]` (#22183) chore(RingTheory): generalize universes for `isUnramified_iff_map_eq` (#22185) chore(Algebra/GroupPower/IterateHom): move all lemmas earlier (#22132) feat(Probability): ae filter and integrability wrt a composition of kernel and measure (#22074) feat(CategoryTheory): forgetting the group structure on the codomain of left-exact functors (#21973) feat(CategoryTheory): embeddings for opposites of Grothendieck abelian categories (#22182) feat(CategoryTheory): `AsSmall C` is abelian (#22184) feat(CategoryTheory): explicit argument versions of `epi_comp` and `mono_comp` (#22181) feat(Topology/Instances/EReal/Lemmas): add lemmas about limsup and multiplication (#21833) feat: basic structural lemmas about finite crystallographic root pairings. (#21932) Rename `Mem𝓛p` to `MemLp` (#22164) feat(Logic/Equiv): Upgrade arrowProdEquivProdArrow to dependent types (#21518) feat(CategoryTheory): Grothendieck abelian categories have enough injectives (#20079) chore: deprecate Finite.cast_card_eq_mk (#22161) feat(CategoryTheory/Limits/Fubini): relax `HasLimits` hypotheses (#20570) chore(Algebra/Order/Monoid/Unbundled/WithTop): golf, clean up (#22109)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithBotandWithTopsections analogous(WithTop α)ᵒᵈ = WithBot αᵒᵈvariablestatementsa b : αandx y : WithBot αThis is a follow-up to #21274.