Skip to content

[Merged by Bors] - fix(MathlibTest/TransImports): stop inspecting the Lean package#21492

Closed
adomani wants to merge 1 commit intomasterfrom
adomani/unlink_trans_imports_and_lean_imports
Closed

[Merged by Bors] - fix(MathlibTest/TransImports): stop inspecting the Lean package#21492
adomani wants to merge 1 commit intomasterfrom
adomani/unlink_trans_imports_and_lean_imports

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Feb 6, 2025

This makes it more robust to changes to lean internals.

Zulip


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2025

PR summary f17f068cfc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adomani adomani marked this pull request as ready for review February 6, 2025 06:52
@eric-wieser eric-wieser changed the title fix: TransImports test no longer use Lean fix(MathlibTest/TransImports): stop inspecting the Lean package Feb 6, 2025
@eric-wieser
Copy link
Copy Markdown
Member

bors d+

I tweaked the description

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 6, 2025

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 6, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 6, 2025

Thanks for the better description!

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 6, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 6, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(MathlibTest/TransImports): stop inspecting the Lean package [Merged by Bors] - fix(MathlibTest/TransImports): stop inspecting the Lean package Feb 6, 2025
@mathlib-bors mathlib-bors bot closed this Feb 6, 2025
@mathlib-bors mathlib-bors bot deleted the adomani/unlink_trans_imports_and_lean_imports branch February 6, 2025 21:26
Julian added a commit that referenced this pull request Feb 7, 2025
* origin/master:
  chore: update Mathlib dependencies 2025-02-06 (#21523)
  fix(MathlibTest/TransImports): stop inspecting the `Lean` package (#21492)
  style(Mathlib/Computability/Halting): `RePred` to `REPred` (#21216)
  feat(Data/Set/Card): add `ncard_le_encard` (#21467)
  feat(Order): lemmas for `Order.succ` and `Order.pred` in `Fin` (#21437)
  feat(LinearAlgebra/LinearIndependent): linear independence + subsingletons (#21511)
  feat: for continuous linear maps in a normed ring, `flip mul = mul` (#21507)
  chore(GroupTheory/Commutator): don't import `Ring` (#21296)
  chore(Data/Complex/Abs): add `protected` to results that already exists in root namespace (#21454)
  chore(*): `erw`s that can now become `rw`s (#21510)
  chore: allow create-adaptation-pr.sh to continue when bump branch already exists (#21486)
  feat(CategoryTheory): equivalence between `Ind C` and left exact functors from `C` to `Type` (#21430)
  chore: add test to TCSynth.lean (#21499)
  feat: the category of ind-objects satisfies the AB5 axiom (#21350)
  refactor(RepresentationTheory): `ConcreteCategory` instances for `Rep` (#21465)
  chore: split Mathlib.Order.Filter.Basic (#21403)
  chore: update Mathlib dependencies 2025-02-06 (#21487)
  chore(Cache): Add support for $MATHLIB_CACHE_DIR (#21480)
  feat(CategoryTheory): a closed monoidal category is an ordinary enriched category over itself (#21436)
  feat(AlgebraicTopology): notation X ^[n] for cosimplicial objects (#21485)
  chore: upgrade dependencies manually (#21484)
  refactor(Analysis/Normed): `ConcreteCategory` refactor for `SemiNormedGrp` (#21477)
  refactor(LinearAlgebra): `ConcreteCategory` instance for `QuadraticModuleCat` (#21471)
  refactor(MeasureTheory): `ConcreteCategory` instance for `MeasCat` (#21468)
  refactor(Topology/Category): clean up remaining uses of `HasForget` (#21458)
  refactor(CategoryTheory): `ConcreteCategory` instances for pointed types (#21470)
  feat(CategoryTheory/Action): `ConcreteCategory` instances for `Action` (#21462)
  feat(CategoryTheory): `ConcreteCategory` instance for `DifferentialObject` (#21464)
  feat(Analysis/Normed/Group/SeparationQuotient): add normed lifts and `mk` (#18178)
  chore: rename `encard_le_card` to `encard_le_encard` (#21426)
  feat: add theorem about the norm of cross products (#20920)
  feat(Data/Matroid/Circuit): circuit elimination and finitary matroids (#21172)
  feat(LinearAlgebra/ExteriorPower): add iMulti_family definition for product of a family of vectors (#21397)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants