Skip to content

[Merged by Bors] - feat(Data/Matroid/Circuit): circuit elimination and finitary matroids#21172

Closed
apnelson1 wants to merge 7 commits intomasterfrom
matroid_circuit_elimination
Closed

[Merged by Bors] - feat(Data/Matroid/Circuit): circuit elimination and finitary matroids#21172
apnelson1 wants to merge 7 commits intomasterfrom
matroid_circuit_elimination

Conversation

@apnelson1
Copy link
Copy Markdown
Collaborator

@apnelson1 apnelson1 commented Jan 28, 2025

We add various version of the circuit elimination axiom, and some lemmas about finitary matroids.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 28, 2025 •
edited
Loading

PR summary b844cb025b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Circuit.elimination
+ Circuit.finite
+ Circuit.strong_elimination
+ Circuit.strong_multi_elimination
+ Circuit.strong_multi_elimination_insert
+ Circuit.strong_multi_elimination_set
+ exists_circuit_of_mem_closure
+ exists_mem_finite_closure_of_mem_closure
+ exists_subset_finite_closure_of_subset_closure
+ finitary_iff_forall_circuit_finite
+ mem_closure_iff_exists_circuit

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jan 28, 2025
madvorak
madvorak approved these changes Jan 28, 2025
View reviewed changes
madvorak
madvorak approved these changes Jan 28, 2025
View reviewed changes
b-mehta
b-mehta reviewed Jan 28, 2025
View reviewed changes
b-mehta
b-mehta reviewed Jan 28, 2025
View reviewed changes
b-mehta
b-mehta reviewed Jan 28, 2025
View reviewed changes
b-mehta
b-mehta reviewed Jan 28, 2025
View reviewed changes
b-mehta
b-mehta reviewed Jan 29, 2025
View reviewed changes
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 30, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 30, 2025
@apnelson1 apnelson1 mentioned this pull request Jan 30, 2025
Closed
mathlib-bors bot pushed a commit that referenced this pull request Jan 30, 2025
@apnelson1
feat(Data/Set/Lattice): insert distributivity with iUnion/iInter (#21267
628c424 
)

From discussion in #21172
mathlib-bors bot pushed a commit that referenced this pull request Jan 31, 2025
@apnelson1
feat(Data/Set/Lattice): insert distributivity with iUnion/iInter (#21267
2c45190 
)

From discussion in #21172
@apnelson1 apnelson1 mentioned this pull request Feb 1, 2025
Closed
jt496 pushed a commit that referenced this pull request Feb 3, 2025
@apnelson1 @jt496
feat(Data/Set/Lattice): insert distributivity with iUnion/iInter (#21267
93a1cdd 
)

From discussion in #21172
mathlib-bors bot pushed a commit that referenced this pull request Feb 5, 2025
@apnelson1
feat(Data/Set/Lattice): iUnion + insertion (#21322)
8827be0 
Another distributivity lemma with iUnion and insertions, needed for #21172. 

This could maybe be `@[simp]`
@b-mehta
Copy link
Copy Markdown
Contributor

b-mehta commented Feb 5, 2025

Thank you!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 5, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 5, 2025
@apnelson1
feat(Data/Matroid/Circuit): circuit elimination and finitary matroids (…
3ebd28c 
…#21172)

We add various version of the circuit elimination axiom, and some lemmas about finitary matroids.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 5, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Matroid/Circuit): circuit elimination and finitary matroids [Merged by Bors] - feat(Data/Matroid/Circuit): circuit elimination and finitary matroids Feb 5, 2025
@mathlib-bors mathlib-bors bot closed this Feb 5, 2025
@mathlib-bors mathlib-bors bot deleted the matroid_circuit_elimination branch February 5, 2025 21:34
Julian added a commit that referenced this pull request Feb 7, 2025
@Julian
Merge remote-tracking branch 'origin/master' into bhargava-factorial
53aa24b 
* origin/master:
  chore: update Mathlib dependencies 2025-02-06 (#21523)
  fix(MathlibTest/TransImports): stop inspecting the `Lean` package (#21492)
  style(Mathlib/Computability/Halting): `RePred` to `REPred` (#21216)
  feat(Data/Set/Card): add `ncard_le_encard` (#21467)
  feat(Order): lemmas for `Order.succ` and `Order.pred` in `Fin` (#21437)
  feat(LinearAlgebra/LinearIndependent): linear independence + subsingletons (#21511)
  feat: for continuous linear maps in a normed ring, `flip mul = mul` (#21507)
  chore(GroupTheory/Commutator): don't import `Ring` (#21296)
  chore(Data/Complex/Abs): add `protected` to results that already exists in root namespace (#21454)
  chore(*): `erw`s that can now become `rw`s (#21510)
  chore: allow create-adaptation-pr.sh to continue when bump branch already exists (#21486)
  feat(CategoryTheory): equivalence between `Ind C` and left exact functors from `C` to `Type` (#21430)
  chore: add test to TCSynth.lean (#21499)
  feat: the category of ind-objects satisfies the AB5 axiom (#21350)
  refactor(RepresentationTheory): `ConcreteCategory` instances for `Rep` (#21465)
  chore: split Mathlib.Order.Filter.Basic (#21403)
  chore: update Mathlib dependencies 2025-02-06 (#21487)
  chore(Cache): Add support for $MATHLIB_CACHE_DIR (#21480)
  feat(CategoryTheory): a closed monoidal category is an ordinary enriched category over itself (#21436)
  feat(AlgebraicTopology): notation X ^[n] for cosimplicial objects (#21485)
  chore: upgrade dependencies manually (#21484)
  refactor(Analysis/Normed): `ConcreteCategory` refactor for `SemiNormedGrp` (#21477)
  refactor(LinearAlgebra): `ConcreteCategory` instance for `QuadraticModuleCat` (#21471)
  refactor(MeasureTheory): `ConcreteCategory` instance for `MeasCat` (#21468)
  refactor(Topology/Category): clean up remaining uses of `HasForget` (#21458)
  refactor(CategoryTheory): `ConcreteCategory` instances for pointed types (#21470)
  feat(CategoryTheory/Action): `ConcreteCategory` instances for `Action` (#21462)
  feat(CategoryTheory): `ConcreteCategory` instance for `DifferentialObject` (#21464)
  feat(Analysis/Normed/Group/SeparationQuotient): add normed lifts and `mk` (#18178)
  chore: rename `encard_le_card` to `encard_le_encard` (#21426)
  feat: add theorem about the norm of cross products (#20920)
  feat(Data/Matroid/Circuit): circuit elimination and finitary matroids (#21172)
  feat(LinearAlgebra/ExteriorPower): add iMulti_family definition for product of a family of vectors (#21397)
pfaffelh pushed a commit that referenced this pull request Feb 7, 2025
@apnelson1
feat(Data/Set/Lattice): iUnion + insertion (#21322)
3cc1973 
Another distributivity lemma with iUnion and insertions, needed for #21172. 

This could maybe be `@[simp]`
pfaffelh pushed a commit that referenced this pull request Feb 7, 2025
@apnelson1
feat(Data/Matroid/Circuit): circuit elimination and finitary matroids (…
25ec4f2 
…#21172)

We add various version of the circuit elimination axiom, and some lemmas about finitary matroids.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b-mehta b-mehta b-mehta left review comments

+1 more reviewer

@madvorak madvorak madvorak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apnelson1 @b-mehta @madvorak @leanprover-community-bot-assistant