[Merged by Bors] - refactor(Topology/Category): clean up remaining uses of HasForget#21458
Closed
Vierkantor wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - refactor(Topology/Category): clean up remaining uses of HasForget#21458Vierkantor wants to merge 3 commits intomasterfrom
HasForget#21458Vierkantor wants to merge 3 commits intomasterfrom
Conversation
This PR upgrades the remaining usage of `HasForget` in the folder `Mathlib/Topology/Category`, upgrading to `ConcreteCategory`. I made a `Hom` structure for `UniformSpaceCat` but not for the other concrete categories, since it was the only category to actually need some disambiguating between categorical homs and uniformly continuous maps.
PR summary 582c7ad057
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.Category.Born | 597 | 595 | -2 (-0.34%) |
| Mathlib.Topology.Category.UniformSpace | 814 | 812 | -2 (-0.25%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Topology.Category.Born Mathlib.Topology.Category.UniformSpace |
-2 |
Declarations diff
+ Hom
+ Hom.hom
+ concreteCategory
+ instance (R S : TopCommRingCat.{u}) : FunLike { f : R →+* S // Continuous f } R S
+ instance : ConcreteCategory Born (LocallyBoundedMap · ·)
+ instance : ConcreteCategory Compactum (· ⟶ ·)
+ instance : ConcreteCategory TopCommRingCat.{u} fun R S => { f : R →+* S // Continuous f }
+ instance : ConcreteCategory UniformSpaceCat ({ f : · → · // UniformContinuous f })
+ instance : LargeCategory.{u} UniformSpaceCat.{u}
+ instance {X Y : Compactum} : FunLike (X ⟶ Y) X Y
+ ofHom
++ hom_comp
++ hom_id
++ hom_ofHom
++ instFunLike
+++--- of
- forgetCommRing
- forgetTopologicalRing
- forgetTopologicalSpace
- hasForget
- instance (X : Born) : Bornology X
- instance (X : UniformSpaceCat) : UniformSpace ((forget _).obj X)
- instance (X Y : UniformSpaceCat) : CoeFun (X ⟶ Y) fun _ => X → Y
- instance (x : UniformSpaceCat) : UniformSpace x
- instance : BundledHom @LocallyBoundedMap
- instance : HasForget Born
- instance : HasForget Compactum where forget := forget
- instance : HasForget TopCommRingCat.{u}
- instance : HasForget UniformSpaceCat
- instance : UnbundledHom @UniformContinuous
- instance {X Y : Compactum} : CoeFun (X ⟶ Y) fun _ => X → Y
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Decrease in tech debt: (relative, absolute) = (2.50, 0.00)
| Current number | Change | Type |
|---|---|---|
| 4187 | -4 | porting notes |
| 1381 | -2 | erw |
Current commit 582c7ad057
Reference commit 86986e5d50
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
…21458) This PR upgrades the remaining usage of `HasForget` in the folder `Mathlib/Topology/Category`, upgrading to `ConcreteCategory`. I made a `Hom` structure for `UniformSpaceCat` but not for the other concrete categories, since it was the only category to actually need some disambiguating between categorical homs and uniformly continuous maps.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
HasForgetHasForget
Julian
added a commit
that referenced
this pull request
Feb 7, 2025
* origin/master: chore: update Mathlib dependencies 2025-02-06 (#21523) fix(MathlibTest/TransImports): stop inspecting the `Lean` package (#21492) style(Mathlib/Computability/Halting): `RePred` to `REPred` (#21216) feat(Data/Set/Card): add `ncard_le_encard` (#21467) feat(Order): lemmas for `Order.succ` and `Order.pred` in `Fin` (#21437) feat(LinearAlgebra/LinearIndependent): linear independence + subsingletons (#21511) feat: for continuous linear maps in a normed ring, `flip mul = mul` (#21507) chore(GroupTheory/Commutator): don't import `Ring` (#21296) chore(Data/Complex/Abs): add `protected` to results that already exists in root namespace (#21454) chore(*): `erw`s that can now become `rw`s (#21510) chore: allow create-adaptation-pr.sh to continue when bump branch already exists (#21486) feat(CategoryTheory): equivalence between `Ind C` and left exact functors from `C` to `Type` (#21430) chore: add test to TCSynth.lean (#21499) feat: the category of ind-objects satisfies the AB5 axiom (#21350) refactor(RepresentationTheory): `ConcreteCategory` instances for `Rep` (#21465) chore: split Mathlib.Order.Filter.Basic (#21403) chore: update Mathlib dependencies 2025-02-06 (#21487) chore(Cache): Add support for $MATHLIB_CACHE_DIR (#21480) feat(CategoryTheory): a closed monoidal category is an ordinary enriched category over itself (#21436) feat(AlgebraicTopology): notation X ^[n] for cosimplicial objects (#21485) chore: upgrade dependencies manually (#21484) refactor(Analysis/Normed): `ConcreteCategory` refactor for `SemiNormedGrp` (#21477) refactor(LinearAlgebra): `ConcreteCategory` instance for `QuadraticModuleCat` (#21471) refactor(MeasureTheory): `ConcreteCategory` instance for `MeasCat` (#21468) refactor(Topology/Category): clean up remaining uses of `HasForget` (#21458) refactor(CategoryTheory): `ConcreteCategory` instances for pointed types (#21470) feat(CategoryTheory/Action): `ConcreteCategory` instances for `Action` (#21462) feat(CategoryTheory): `ConcreteCategory` instance for `DifferentialObject` (#21464) feat(Analysis/Normed/Group/SeparationQuotient): add normed lifts and `mk` (#18178) chore: rename `encard_le_card` to `encard_le_encard` (#21426) feat: add theorem about the norm of cross products (#20920) feat(Data/Matroid/Circuit): circuit elimination and finitary matroids (#21172) feat(LinearAlgebra/ExteriorPower): add iMulti_family definition for product of a family of vectors (#21397)
pfaffelh
pushed a commit
that referenced
this pull request
Feb 7, 2025
…21458) This PR upgrades the remaining usage of `HasForget` in the folder `Mathlib/Topology/Category`, upgrading to `ConcreteCategory`. I made a `Hom` structure for `UniformSpaceCat` but not for the other concrete categories, since it was the only category to actually need some disambiguating between categorical homs and uniformly continuous maps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the remaining usage of
HasForgetin the folderMathlib/Topology/Category, upgrading toConcreteCategory.I made a
Homstructure forUniformSpaceCatbut not for the other concrete categories, since it was the only category to actually need some disambiguating between categorical homs and uniformly continuous maps.