Skip to content

[Merged by Bors] - refactor(RepresentationTheory): ConcreteCategory instances for Rep#21465

Closed
Vierkantor wants to merge 8 commits intomasterfrom
ConcreteCategory-Rep
Closed

[Merged by Bors] - refactor(RepresentationTheory): ConcreteCategory instances for Rep#21465
Vierkantor wants to merge 8 commits intomasterfrom
ConcreteCategory-Rep

Conversation

@Vierkantor
Copy link
Copy Markdown
Contributor

This PR promotes the existing HasForget instances for Rep and FDRep to ConcreteCategory. A little bit of cleanup was possible!


Open in Gitpod

…eCategory`

This removes the remaining references to `HasForget` in the folder `Mathlib/Algebra/Category`, upgrading all instances to `ConcreteCategory`.
Alongside the existing `HasForget` instances, allow deriving `ConcreteCategory (Action V G)` if `V` is a concrete category.
@Vierkantor Vierkantor added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-category-theory Category theory t-algebra Algebra (groups, rings, fields, etc) labels Feb 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2025

PR summary 4f315f1b6a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : ConcreteCategory (FDRep k G) (Action.HomSubtype _ _) := inferInstance
++-- of
- instance : HasForget (FDRep k G) := inferInstance

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
4122 -1 porting notes
1373 -1 erw

Current commit 4f315f1b6a
Reference commit 0504e9a5dd

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 5, 2025
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 5, 2025
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Feb 5, 2025

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 5, 2025

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 5, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 6, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@Vierkantor
Copy link
Copy Markdown
Contributor Author

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 6, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2025
#21465)

This PR promotes the existing `HasForget` instances for `Rep` and `FDRep` to `ConcreteCategory`. A little bit of cleanup was possible!
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 6, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(RepresentationTheory): ConcreteCategory instances for Rep [Merged by Bors] - refactor(RepresentationTheory): ConcreteCategory instances for Rep Feb 6, 2025
@mathlib-bors mathlib-bors bot closed this Feb 6, 2025
@mathlib-bors mathlib-bors bot deleted the ConcreteCategory-Rep branch February 6, 2025 10:22
Julian added a commit that referenced this pull request Feb 7, 2025
* origin/master:
  chore: update Mathlib dependencies 2025-02-06 (#21523)
  fix(MathlibTest/TransImports): stop inspecting the `Lean` package (#21492)
  style(Mathlib/Computability/Halting): `RePred` to `REPred` (#21216)
  feat(Data/Set/Card): add `ncard_le_encard` (#21467)
  feat(Order): lemmas for `Order.succ` and `Order.pred` in `Fin` (#21437)
  feat(LinearAlgebra/LinearIndependent): linear independence + subsingletons (#21511)
  feat: for continuous linear maps in a normed ring, `flip mul = mul` (#21507)
  chore(GroupTheory/Commutator): don't import `Ring` (#21296)
  chore(Data/Complex/Abs): add `protected` to results that already exists in root namespace (#21454)
  chore(*): `erw`s that can now become `rw`s (#21510)
  chore: allow create-adaptation-pr.sh to continue when bump branch already exists (#21486)
  feat(CategoryTheory): equivalence between `Ind C` and left exact functors from `C` to `Type` (#21430)
  chore: add test to TCSynth.lean (#21499)
  feat: the category of ind-objects satisfies the AB5 axiom (#21350)
  refactor(RepresentationTheory): `ConcreteCategory` instances for `Rep` (#21465)
  chore: split Mathlib.Order.Filter.Basic (#21403)
  chore: update Mathlib dependencies 2025-02-06 (#21487)
  chore(Cache): Add support for $MATHLIB_CACHE_DIR (#21480)
  feat(CategoryTheory): a closed monoidal category is an ordinary enriched category over itself (#21436)
  feat(AlgebraicTopology): notation X ^[n] for cosimplicial objects (#21485)
  chore: upgrade dependencies manually (#21484)
  refactor(Analysis/Normed): `ConcreteCategory` refactor for `SemiNormedGrp` (#21477)
  refactor(LinearAlgebra): `ConcreteCategory` instance for `QuadraticModuleCat` (#21471)
  refactor(MeasureTheory): `ConcreteCategory` instance for `MeasCat` (#21468)
  refactor(Topology/Category): clean up remaining uses of `HasForget` (#21458)
  refactor(CategoryTheory): `ConcreteCategory` instances for pointed types (#21470)
  feat(CategoryTheory/Action): `ConcreteCategory` instances for `Action` (#21462)
  feat(CategoryTheory): `ConcreteCategory` instance for `DifferentialObject` (#21464)
  feat(Analysis/Normed/Group/SeparationQuotient): add normed lifts and `mk` (#18178)
  chore: rename `encard_le_card` to `encard_le_encard` (#21426)
  feat: add theorem about the norm of cross products (#20920)
  feat(Data/Matroid/Circuit): circuit elimination and finitary matroids (#21172)
  feat(LinearAlgebra/ExteriorPower): add iMulti_family definition for product of a family of vectors (#21397)
pfaffelh pushed a commit that referenced this pull request Feb 7, 2025
#21465)

This PR promotes the existing `HasForget` instances for `Rep` and `FDRep` to `ConcreteCategory`. A little bit of cleanup was possible!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants