[Merged by Bors] - feat(Order): lemmas for Order.succ and Order.pred in Fin#21437
Closed
[Merged by Bors] - feat(Order): lemmas for Order.succ and Order.pred in Fin#21437
Order.succ and Order.pred in Fin#21437Conversation
PR summary 8ca0c3169f
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.Fin.SuccPred | 394 | 387 | -7 (-1.78%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Data.Fin.SuccPred |
-7 |
Mathlib.Combinatorics.SimpleGraph.Hasse |
-1 |
Declarations diff
+ eq_castSucc_of_ne_last
+ orderPred_apply
+ orderPred_eq
+ orderPred_succ
+ orderPred_zero
+ orderSucc_apply
+ orderSucc_castSucc
+ orderSucc_eq
+ orderSucc_last
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Closed
3 tasks
eric-wieser
reviewed
Feb 5, 2025
eric-wieser
reviewed
Feb 5, 2025
eric-wieser
reviewed
Feb 6, 2025
Contributor
|
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
The `SuccOrder` and `PredOrder` instances are redefined on `Fin n`, and equational lemmas are provided. The lemma `Fin.exists_castSucc_eq_of_ne_last` is renamed `Fin.eq_castSucc_of_ne_last` (for consistency with `Fin.eq_succ_of_ne_zero`).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Order.succ and Order.pred in FinOrder.succ and Order.pred in Fin
riccardobrasca
added a commit
that referenced
this pull request
Feb 6, 2025
The `SuccOrder` and `PredOrder` instances are redefined on `Fin n`, and equational lemmas are provided. The lemma `Fin.exists_castSucc_eq_of_ne_last` is renamed `Fin.eq_castSucc_of_ne_last` (for consistency with `Fin.eq_succ_of_ne_zero`). --- <!-- The text above the `---` will become the commit message when your PR is merged. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. To indicate co-authors, include lines at the bottom of the commit message (that is, before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (that is, before the `---`) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [](https://gitpod.io/from-referrer/)
Julian
added a commit
that referenced
this pull request
Feb 7, 2025
* origin/master: chore: update Mathlib dependencies 2025-02-06 (#21523) fix(MathlibTest/TransImports): stop inspecting the `Lean` package (#21492) style(Mathlib/Computability/Halting): `RePred` to `REPred` (#21216) feat(Data/Set/Card): add `ncard_le_encard` (#21467) feat(Order): lemmas for `Order.succ` and `Order.pred` in `Fin` (#21437) feat(LinearAlgebra/LinearIndependent): linear independence + subsingletons (#21511) feat: for continuous linear maps in a normed ring, `flip mul = mul` (#21507) chore(GroupTheory/Commutator): don't import `Ring` (#21296) chore(Data/Complex/Abs): add `protected` to results that already exists in root namespace (#21454) chore(*): `erw`s that can now become `rw`s (#21510) chore: allow create-adaptation-pr.sh to continue when bump branch already exists (#21486) feat(CategoryTheory): equivalence between `Ind C` and left exact functors from `C` to `Type` (#21430) chore: add test to TCSynth.lean (#21499) feat: the category of ind-objects satisfies the AB5 axiom (#21350) refactor(RepresentationTheory): `ConcreteCategory` instances for `Rep` (#21465) chore: split Mathlib.Order.Filter.Basic (#21403) chore: update Mathlib dependencies 2025-02-06 (#21487) chore(Cache): Add support for $MATHLIB_CACHE_DIR (#21480) feat(CategoryTheory): a closed monoidal category is an ordinary enriched category over itself (#21436) feat(AlgebraicTopology): notation X ^[n] for cosimplicial objects (#21485) chore: upgrade dependencies manually (#21484) refactor(Analysis/Normed): `ConcreteCategory` refactor for `SemiNormedGrp` (#21477) refactor(LinearAlgebra): `ConcreteCategory` instance for `QuadraticModuleCat` (#21471) refactor(MeasureTheory): `ConcreteCategory` instance for `MeasCat` (#21468) refactor(Topology/Category): clean up remaining uses of `HasForget` (#21458) refactor(CategoryTheory): `ConcreteCategory` instances for pointed types (#21470) feat(CategoryTheory/Action): `ConcreteCategory` instances for `Action` (#21462) feat(CategoryTheory): `ConcreteCategory` instance for `DifferentialObject` (#21464) feat(Analysis/Normed/Group/SeparationQuotient): add normed lifts and `mk` (#18178) chore: rename `encard_le_card` to `encard_le_encard` (#21426) feat: add theorem about the norm of cross products (#20920) feat(Data/Matroid/Circuit): circuit elimination and finitary matroids (#21172) feat(LinearAlgebra/ExteriorPower): add iMulti_family definition for product of a family of vectors (#21397)
pfaffelh
pushed a commit
that referenced
this pull request
Feb 7, 2025
The `SuccOrder` and `PredOrder` instances are redefined on `Fin n`, and equational lemmas are provided. The lemma `Fin.exists_castSucc_eq_of_ne_last` is renamed `Fin.eq_castSucc_of_ne_last` (for consistency with `Fin.eq_succ_of_ne_zero`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SuccOrderandPredOrderinstances are redefined onFin n, and equational lemmas are provided.The lemma
Fin.exists_castSucc_eq_of_ne_lastis renamedFin.eq_castSucc_of_ne_last(for consistency withFin.eq_succ_of_ne_zero).