Skip to content

[Merged by Bors] - chore(CategoryTheory): rename ConcreteCategory to HasForget#20809

Closed
Vierkantor wants to merge 1 commit intomasterfrom
rename-HasForget
Closed

[Merged by Bors] - chore(CategoryTheory): rename ConcreteCategory to HasForget#20809
Vierkantor wants to merge 1 commit intomasterfrom
rename-HasForget

Conversation

@Vierkantor
Copy link
Copy Markdown
Contributor

This is the first step towards a concrete category redesign, as outlined in this Zulip post: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Concrete.20category.20class.20redesign/near/493903980

This commit was generated by find-and-replacing ConcreteCategory and concreteCategory with HasForget and hasForget respectively, making sure not to touch imports. I did not look too closely at the changes, since we should be going over everything during the redesign anyway.

ConcreteCategory is now temporarily an alias for HasForget, with a deprecation warning.

The ConcreteCategory namespace itself was not renamed, since we'll eventually be redoing those results for the new ConcreteCategory class.


Open in Gitpod

This is the first step towards a concrete category redesign, as outlined in this Zulip post: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Concrete.20category.20class.20redesign/near/493903980

This commit was generated by find-and-replacing `ConcreteCategory` and `concreteCategory` with `HasForget` and `hasForget` respectively, making sure not to touch imports. I did not look too closely at the changes, since we should be going over everything during the redesign anyway.

`ConcreteCategory` is now temporarily an alias for `HasForget`, with a deprecation warning.

The `ConcreteCategory` namespace itself was not renamed, since we'll be redoing those results for the new `ConcreteCategory` class.
@Vierkantor Vierkantor added the t-category-theory Category theory label Jan 17, 2025
@github-actions
Copy link
Copy Markdown

PR summary fb21cb025c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ FullSubcategory.hasForget
+ HasForget
+ HasForget.hasCoeToSort
+ HasForget.instFunLike
+ HasForget.types
+ InducedCategory.hasForget
+ exact_iff_of_hasForget
+ groupWithZeroHasForget
+ hasForgetFintype
+ hasForgetOfDifferentialObjects
+ instance (x : SimplexCategory) : Fintype (HasForget.forget.obj x)
+ instance : HasCoeToSort X := HasForget.hasCoeToSort X
+ instance : HasForget (ContAction V G)
+ instance : HasForget (DiscreteContAction V G)
+ instance : HasForget (FDRep k G) := inferInstance
+ instance : HasForget (FGModuleCat R) := by
+ instance : HasForget (GradedObject β C) where forget := total β C ⋙ forget C
+ instance : HasForget BddDistLat
+ instance : HasForget BddLat
+ instance : HasForget BoolAlg
+ instance : HasForget BoolRing
+ instance : HasForget Born
+ instance : HasForget Compactum where forget := forget
+ instance : HasForget CompleteLat := by
+ instance : HasForget DistLat
+ instance : HasForget FinTopCat
+ instance : HasForget FiniteGrp := InducedCategory.hasForget FiniteGrp.toGrp
+ instance : HasForget Frm := by
+ instance : HasForget HeytAlg := by
+ instance : HasForget Lat
+ instance : HasForget LinOrd
+ instance : HasForget MeasCat := by
+ instance : HasForget NonemptyFinLinOrd
+ instance : HasForget PartOrd
+ instance : HasForget Preord
+ instance : HasForget ProfiniteGrp
+ instance : HasForget SemiNormedGrp := by
+ instance : HasForget SemilatInfCat
+ instance : HasForget SemilatSupCat
+ instance : HasForget TopCommRingCat.{u}
+ instance : HasForget UniformSpaceCat
+ instance : HasForget ωCPO := by unfold ωCPO; infer_instance
+ instance : HasForget.{0} SimplexCategory
+ instance : HasForget.{u} CommRingCat
+ instance : HasForget.{u} CommSemiRingCat
+ instance : HasForget.{u} DeltaGenerated.{u}
+ instance : HasForget.{u} RingCat
+ instance : HasForget.{u} SemiNormedGrp₁
+ instance : HasForget.{u} SemiRingCat
+ instance : HasForget.{u} Sequential.{u}
+ instance : HasForget.{v} (AlgebraCat.{v} R)
+ instance : HasForget.{w} CompactlyGenerated.{u, w}
+ instance [HasForget C] [PreservesColimitsOfShape (Discrete WalkingPair) (forget C)]
+ instance [HasForget V] : HasForget (Action V G)
+ instance {D : Type w} [Category.{w'} D] [HasForget.{max u v} D]
+ moduleHasForget
+++ instHasForget
++++++++++++++++++++ hasForget
- ConcreteCategory.hasCoeToSort
- ConcreteCategory.instFunLike
- ConcreteCategory.types
- FullSubcategory.concreteCategory
- InducedCategory.concreteCategory
- concreteCategoryFintype
- concreteCategoryOfDifferentialObjects
- exact_iff_of_concreteCategory
- groupWithZeroConcreteCategory
- instance (x : SimplexCategory) : Fintype (ConcreteCategory.forget.obj x)
- instance : ConcreteCategory (ContAction V G)
- instance : ConcreteCategory (DiscreteContAction V G)
- instance : ConcreteCategory (FDRep k G) := inferInstance
- instance : ConcreteCategory (FGModuleCat R) := by
- instance : ConcreteCategory (GradedObject β C) where forget := total β C ⋙ forget C
- instance : ConcreteCategory BddDistLat
- instance : ConcreteCategory BddLat
- instance : ConcreteCategory BoolAlg
- instance : ConcreteCategory BoolRing
- instance : ConcreteCategory Born
- instance : ConcreteCategory Compactum where forget := forget
- instance : ConcreteCategory CompleteLat := by
- instance : ConcreteCategory DistLat
- instance : ConcreteCategory FinTopCat
- instance : ConcreteCategory FiniteGrp := InducedCategory.concreteCategory FiniteGrp.toGrp
- instance : ConcreteCategory Frm := by
- instance : ConcreteCategory HeytAlg := by
- instance : ConcreteCategory Lat
- instance : ConcreteCategory LinOrd
- instance : ConcreteCategory MeasCat := by
- instance : ConcreteCategory NonemptyFinLinOrd
- instance : ConcreteCategory PartOrd
- instance : ConcreteCategory Preord
- instance : ConcreteCategory ProfiniteGrp
- instance : ConcreteCategory SemiNormedGrp := by
- instance : ConcreteCategory SemilatInfCat
- instance : ConcreteCategory SemilatSupCat
- instance : ConcreteCategory TopCommRingCat.{u}
- instance : ConcreteCategory UniformSpaceCat
- instance : ConcreteCategory ωCPO := by unfold ωCPO; infer_instance
- instance : ConcreteCategory.{0} SimplexCategory
- instance : ConcreteCategory.{u} CommRingCat
- instance : ConcreteCategory.{u} CommSemiRingCat
- instance : ConcreteCategory.{u} DeltaGenerated.{u}
- instance : ConcreteCategory.{u} RingCat
- instance : ConcreteCategory.{u} SemiNormedGrp₁
- instance : ConcreteCategory.{u} SemiRingCat
- instance : ConcreteCategory.{u} Sequential.{u}
- instance : ConcreteCategory.{v} (AlgebraCat.{v} R)
- instance : ConcreteCategory.{w} CompactlyGenerated.{u, w}
- instance : HasCoeToSort X := ConcreteCategory.hasCoeToSort X
- instance [ConcreteCategory C] [PreservesColimitsOfShape (Discrete WalkingPair) (forget C)]
- instance [ConcreteCategory V] : ConcreteCategory (Action V G)
- instance {D : Type w} [Category.{w'} D] [ConcreteCategory.{max u v} D]
- moduleConcreteCategory
--- instConcreteCategory
-------------------- concreteCategory

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Vierkantor Vierkantor changed the title chore(CategoryTheory): rename HasForget to ConcreteCategory chore(CategoryTheory): rename ConcreteCategory to HasForget Jan 17, 2025
Copy link
Copy Markdown
Contributor

@mattrobball mattrobball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through and looks clean. Thanks!

@mattrobball
Copy link
Copy Markdown
Contributor

bors merge p=9001

mathlib-bors bot pushed a commit that referenced this pull request Jan 17, 2025
This is the first step towards a concrete category redesign, as outlined in this Zulip post: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Concrete.20category.20class.20redesign/near/493903980

This commit was generated by find-and-replacing `ConcreteCategory` and `concreteCategory` with `HasForget` and `hasForget` respectively, making sure not to touch imports. I did not look too closely at the changes, since we should be going over everything during the redesign anyway.

`ConcreteCategory` is now temporarily an alias for `HasForget`, with a deprecation warning.

The `ConcreteCategory` namespace itself was not renamed, since we'll eventually be redoing those results for the new `ConcreteCategory` class.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 17, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory): rename ConcreteCategory to HasForget [Merged by Bors] - chore(CategoryTheory): rename ConcreteCategory to HasForget Jan 17, 2025
@mathlib-bors mathlib-bors bot closed this Jan 17, 2025
@mathlib-bors mathlib-bors bot deleted the rename-HasForget branch January 17, 2025 14:16
Julian added a commit that referenced this pull request Jan 20, 2025
* polynomial-sequences: (149 commits)
  Aha, here's how to get Lean to stop showing S.elems' in the infoview.
  Try satisfying the linter gods again.
  Probably enough initial tidying to send the PR.
  Kill more temporary names.
  Touch more natDegree.
  Does protected satisfy the docstring linter?
  Bit shorter.
  More
  Quiet linters.
  Remove redundant imports.
  Copyright header and more twiddling.
  Rename lemma to 'degree_smul_of_leadingCoeff_rightRegular' and split out
  feat(Polynomial): polynomial sequences are bases for R[X]
  chore(Dynamics/PeriodicPts): don't import `MonoidWithZero` (#20765)
  chore(Associated): split out `Ring` results (#20737)
  feat(AlgebraicGeometry): flat morphisms of schemes (#19790)
  feat(AlgebraicGeometry): scheme-theoretic fibre (#19427)
  chore: split Mathlib.Analysis.Asymptotics.Asymptotics (#20785)
  doc: typo (#20829)
  feat(CategoryTheory): condition for an induced functor between comma categories to be final  (#20139)
  feat(1000.yaml): allow statements of theorems also (#20637)
  feat(Algebra/Homology/Embedding): homology of truncGE' (#19570)
  chore: cleanup many porting notes in Combinatorics (#20823)
  chore: eliminate porting notes about `deriving Fintype` (#20820)
  feat(Algebra/Lie): a Lie algebra is solvable iff it is solvable after faithfully flat base change (#20808)
  feat: define bases of root pairings (#20667)
  feat(Tactic): basic ConcreteCategory support for elementwise (#20811)
  feat(CategoryTheory): define unbundled `ConcreteCategory` class  (#20810)
  chore(CategoryTheory): rename `ConcreteCategory` to `HasForget` (#20809)
  feat: `CommSemiring (NonemptyInterval ℚ≥0)` (#20783)
  chore(yaml_check.py): re-format (#20807)
  feat: elementary estimate for Real.log (#20766)
  feat: definition of linear topologies (#14990)
  feat(RingTheory): flatness over a semiring (#19115)
  feat(Algebra/Homology/Embedding): the canonical truncation truncLE (#19550)
  feat(Algebra/Homology/Embedding): API for the homology of an extension of homological complex (#19203)
  feat(Algebra/Ring): `RingEquiv.piUnique` (#20794)
  feat(RingTheory/LocalRing): add instance `Unique (MaximalSpectrum R)` for a local ring `R` (#20801)
  chore(GroupExtension/Defs): define `Section` and redefine `Splitting` (#20802)
  chore: restore `def` to `adicCompletion` (#20796)
  refactor: rename `UniqueContinuousFunctionalCalculus` to `ContinuousMap.UniqueHom` (#20643)
  feat(Algebra/Homology/Embedding): the morphism from a complex to its `truncGE` truncation (#19544)
  chore(Mathlib/Computability/TuringMachine): split file (#20790)
  feat(Data/Finset/Card): add `InjOn` and `SurjOn` versions of finset cardinality lemmas (#20753)
  feat(Order/WellFoundedSet): add convenience constructors for IsWF and IsPWO for WellFoundedLT types (#20752)
  feat(Set/Finite): a set is finite if its image and fibers are finite (#20751)
  chore: cleanup .gitignore files (#20795)
  feat(Topology/Group/Profinite):  Profinite group is limit of finite group (#16992)
  feat(Combinatorics/SimpleGraph): vertices in cycles (#20602)
  CI: merge `bot_fix_style` actions (#20789)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants