[Merged by Bors] - feat(1000.yaml): allow statements of theorems also#20637
Closed
[Merged by Bors] - feat(1000.yaml): allow statements of theorems also#20637
Conversation
There are three prominent examples of such statements in mathlib: FLT, the Riemann hypothesis and the Poincaré conjecture. Only the last is currently in the 1000+ theorems list
PR summary 8c1dcde923Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Ruben-VandeVelde
approved these changes
Jan 10, 2025
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Seems reasonable to me, and it might be a fun project to formalize a bunch of the missing statements in Archive. (Can we include theorems from Archive?)
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Contributor
Author
|
Yes, archive theorems are fine. If you spot some theorem which is formalised and missing from this list, please go ahead. (And if you spot an easy theorem on that list, that is also welcome. There is definitely some low-hanging fruit. Not all of it might be interesting for mathlib, but for the archive - I don't see why not.) |
While at it, pring errors to stderr and use four-space indentation.
alreadydone
reviewed
Jan 10, 2025
Contributor
alreadydone
left a comment
There was a problem hiding this comment.
Q776578 Artin--Wedderburn has a statement here.
Q172298 Lasker--Noether is Ideal.isPrimary_decomposition_pairwise_ne_radical
Contributor
Author
|
@alreadydone Thanks; added to the file! |
This was referenced Jan 17, 2025
bryangingechen
pushed a commit
to leanprover-community/leanprover-community.github.io
that referenced
this pull request
Jan 18, 2025
And display these on the generated webpage as well. I don't expect the list of theorems with just a statement to grow large, but for some results, this could be useful. Accompanies leanprover-community/mathlib4#20637; it's better to merge this PR first.
Collaborator
|
This PR/issue depends on: |
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Contributor
|
Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 18, 2025
There are three prominent examples of such statements in mathlib: FLT, the Riemann hypothesis and the Poincaré conjecture. Only the last is currently in the 1000+ theorems list. Add some statements of theorems. While at it, also comment on some more, and add a few more entries. Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Julian
added a commit
that referenced
this pull request
Jan 20, 2025
* polynomial-sequences: (149 commits) Aha, here's how to get Lean to stop showing S.elems' in the infoview. Try satisfying the linter gods again. Probably enough initial tidying to send the PR. Kill more temporary names. Touch more natDegree. Does protected satisfy the docstring linter? Bit shorter. More Quiet linters. Remove redundant imports. Copyright header and more twiddling. Rename lemma to 'degree_smul_of_leadingCoeff_rightRegular' and split out feat(Polynomial): polynomial sequences are bases for R[X] chore(Dynamics/PeriodicPts): don't import `MonoidWithZero` (#20765) chore(Associated): split out `Ring` results (#20737) feat(AlgebraicGeometry): flat morphisms of schemes (#19790) feat(AlgebraicGeometry): scheme-theoretic fibre (#19427) chore: split Mathlib.Analysis.Asymptotics.Asymptotics (#20785) doc: typo (#20829) feat(CategoryTheory): condition for an induced functor between comma categories to be final (#20139) feat(1000.yaml): allow statements of theorems also (#20637) feat(Algebra/Homology/Embedding): homology of truncGE' (#19570) chore: cleanup many porting notes in Combinatorics (#20823) chore: eliminate porting notes about `deriving Fintype` (#20820) feat(Algebra/Lie): a Lie algebra is solvable iff it is solvable after faithfully flat base change (#20808) feat: define bases of root pairings (#20667) feat(Tactic): basic ConcreteCategory support for elementwise (#20811) feat(CategoryTheory): define unbundled `ConcreteCategory` class (#20810) chore(CategoryTheory): rename `ConcreteCategory` to `HasForget` (#20809) feat: `CommSemiring (NonemptyInterval ℚ≥0)` (#20783) chore(yaml_check.py): re-format (#20807) feat: elementary estimate for Real.log (#20766) feat: definition of linear topologies (#14990) feat(RingTheory): flatness over a semiring (#19115) feat(Algebra/Homology/Embedding): the canonical truncation truncLE (#19550) feat(Algebra/Homology/Embedding): API for the homology of an extension of homological complex (#19203) feat(Algebra/Ring): `RingEquiv.piUnique` (#20794) feat(RingTheory/LocalRing): add instance `Unique (MaximalSpectrum R)` for a local ring `R` (#20801) chore(GroupExtension/Defs): define `Section` and redefine `Splitting` (#20802) chore: restore `def` to `adicCompletion` (#20796) refactor: rename `UniqueContinuousFunctionalCalculus` to `ContinuousMap.UniqueHom` (#20643) feat(Algebra/Homology/Embedding): the morphism from a complex to its `truncGE` truncation (#19544) chore(Mathlib/Computability/TuringMachine): split file (#20790) feat(Data/Finset/Card): add `InjOn` and `SurjOn` versions of finset cardinality lemmas (#20753) feat(Order/WellFoundedSet): add convenience constructors for IsWF and IsPWO for WellFoundedLT types (#20752) feat(Set/Finite): a set is finite if its image and fibers are finite (#20751) chore: cleanup .gitignore files (#20795) feat(Topology/Group/Profinite): Profinite group is limit of finite group (#16992) feat(Combinatorics/SimpleGraph): vertices in cycles (#20602) CI: merge `bot_fix_style` actions (#20789) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three prominent examples of such statements in mathlib: FLT, the Riemann hypothesis and the Poincaré conjecture. Only the last is currently in the 1000+ theorems list.
Add some statements of theorems. While at it, also comment on some more, and add a few more entries.