[Merged by Bors] - chore(Mathlib/Computability/TuringMachine): split file#20790
Closed
BoltonBailey wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - chore(Mathlib/Computability/TuringMachine): split file#20790BoltonBailey wants to merge 5 commits intomasterfrom
BoltonBailey wants to merge 5 commits intomasterfrom
Conversation
|
messageFile.md |
|
messageFile.md |
|
messageFile.md |
|
messageFile.md |
Contributor
|
A comment from the peanut gallery: if you merge master, the summary comment should work again (and the |
grunweg
reviewed
Jan 16, 2025
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks, makes sense to me.
I wonder if the module docstring of the new file should be extended further. (I am aware that this is the tedious part of splitting files.)
maintainer delegate?
Mathlib/Computability/Tape.lean
Outdated
| /-! | ||
| # Turing machine tapes | ||
|
|
||
| This file defines a the notion of a Turing machine tape, and the operations on it. A tape is a |
| import Mathlib.Order.Basic | ||
| import Mathlib.Tactic.ApplyFun | ||
| import Mathlib.Data.List.GetD | ||
| import Mathlib.Computability.Tape |
Contributor
There was a problem hiding this comment.
Can you insert this import alphabetically, please?
Contributor
There was a problem hiding this comment.
(I'd prefer that we don't bother asking for changes to import order in review, it adds impedance to already unfun work, for what I think is very little benefit. Contributors may adjust import order if they like, but it is generally so inconsistent across the library that we should plan that eventually bots will deal with this.)
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
This PR splits `Mathlib/Computability/TuringMachine` by moving to a new file the initial 600 or so lines, which deal with the definition of the tape data structure that a Turing machine uses. This reduces the size of this large file to less than 2100 lines. Co-authored-by: Kim Morrison <kim@tqft.net>
|
messageFile.md |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Julian
added a commit
that referenced
this pull request
Jan 20, 2025
* polynomial-sequences: (149 commits) Aha, here's how to get Lean to stop showing S.elems' in the infoview. Try satisfying the linter gods again. Probably enough initial tidying to send the PR. Kill more temporary names. Touch more natDegree. Does protected satisfy the docstring linter? Bit shorter. More Quiet linters. Remove redundant imports. Copyright header and more twiddling. Rename lemma to 'degree_smul_of_leadingCoeff_rightRegular' and split out feat(Polynomial): polynomial sequences are bases for R[X] chore(Dynamics/PeriodicPts): don't import `MonoidWithZero` (#20765) chore(Associated): split out `Ring` results (#20737) feat(AlgebraicGeometry): flat morphisms of schemes (#19790) feat(AlgebraicGeometry): scheme-theoretic fibre (#19427) chore: split Mathlib.Analysis.Asymptotics.Asymptotics (#20785) doc: typo (#20829) feat(CategoryTheory): condition for an induced functor between comma categories to be final (#20139) feat(1000.yaml): allow statements of theorems also (#20637) feat(Algebra/Homology/Embedding): homology of truncGE' (#19570) chore: cleanup many porting notes in Combinatorics (#20823) chore: eliminate porting notes about `deriving Fintype` (#20820) feat(Algebra/Lie): a Lie algebra is solvable iff it is solvable after faithfully flat base change (#20808) feat: define bases of root pairings (#20667) feat(Tactic): basic ConcreteCategory support for elementwise (#20811) feat(CategoryTheory): define unbundled `ConcreteCategory` class (#20810) chore(CategoryTheory): rename `ConcreteCategory` to `HasForget` (#20809) feat: `CommSemiring (NonemptyInterval ℚ≥0)` (#20783) chore(yaml_check.py): re-format (#20807) feat: elementary estimate for Real.log (#20766) feat: definition of linear topologies (#14990) feat(RingTheory): flatness over a semiring (#19115) feat(Algebra/Homology/Embedding): the canonical truncation truncLE (#19550) feat(Algebra/Homology/Embedding): API for the homology of an extension of homological complex (#19203) feat(Algebra/Ring): `RingEquiv.piUnique` (#20794) feat(RingTheory/LocalRing): add instance `Unique (MaximalSpectrum R)` for a local ring `R` (#20801) chore(GroupExtension/Defs): define `Section` and redefine `Splitting` (#20802) chore: restore `def` to `adicCompletion` (#20796) refactor: rename `UniqueContinuousFunctionalCalculus` to `ContinuousMap.UniqueHom` (#20643) feat(Algebra/Homology/Embedding): the morphism from a complex to its `truncGE` truncation (#19544) chore(Mathlib/Computability/TuringMachine): split file (#20790) feat(Data/Finset/Card): add `InjOn` and `SurjOn` versions of finset cardinality lemmas (#20753) feat(Order/WellFoundedSet): add convenience constructors for IsWF and IsPWO for WellFoundedLT types (#20752) feat(Set/Finite): a set is finite if its image and fibers are finite (#20751) chore: cleanup .gitignore files (#20795) feat(Topology/Group/Profinite): Profinite group is limit of finite group (#16992) feat(Combinatorics/SimpleGraph): vertices in cycles (#20602) CI: merge `bot_fix_style` actions (#20789) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits
Mathlib/Computability/TuringMachineby moving to a new file the initial 600 or so lines, which deal with the definition of the tape data structure that a Turing machine uses.This reduces the size of this large file to less than 2100 lines.