Kindle: Add wifi selector by notmarek · Pull Request #12056 · koreader/koreader

notmarek · 2024-06-20T15:20:40Z

#12040, this is not final, i still need to add https://github.com/notmarek/openlipclua to the base, and i have no idea how to go about it

This change is

…#12038) This prevents the current directory from appearing in the listing.

notmarek · 2024-06-20T18:41:22Z

Found a bug where my lipc handle commits suicide 😅 probably a bug in my underlying library

Closes koreader#12005.

Screenshot dialog could not be interacted with in Text editor. Closes koreader#12066.

We can't actually tell whether anything happened, good or bad, so don't let it kill the potentially in-progress attempt. We lose the notifications if you force the scan list via a long-press, but that's another kettle of fish... None of this was really designed for an async backend ;).

It gets a biiit clunkier ;).

notmarek · 2024-06-22T08:00:42Z

Whatever magic you did @NiLuJe seems to have fixed it, i assume it has to do with not letting enableWifi abort the connection since that's the only thing i didn't try, thanks!

NiLuJe · 2024-06-22T08:03:26Z

I have a bunch of other changes to test, FWIW, because there's some stupidity left-over from #10669 that ties into that very change ;).

(It's also not really Kindle-specific, I'm pretty sure that scan window leads to funky stuff pretty much everywhere...).

notmarek · 2024-06-22T08:07:31Z

Oh btw for password = network.known == "yes" and "HIDDEN", should i actually pull the password or is that a bad idea?

NiLuJe · 2024-06-22T08:34:34Z

Oh btw for password = network.known == "yes" and "HIDDEN", should i actually pull the password or is that a bad idea?

I think you're supposed to, yeah. I'm pretty sure we only use that to pre-fill the password input field; and we will save that in plaintext, FWIW.

koreader/koreader-base#1828 koreader/koreader-base#1830 koreader/koreader-base#1831 koreader/koreader-base#1833 (fix koreader#12062) koreader/koreader-base#1832 koreader/koreader-base#1835 koreader/koreader-base#1834 koreader/koreader-base#1837 koreader/koreader-base#1838

Long time no update. A lot of changes.

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

NiLuJe · 2024-06-25T19:51:03Z

(Commit history archived in the kindle-wifi-ui-openlipc branch ;).

mergen3107 · 2024-06-28T15:35:57Z

@notmarek
Is this UI supposed to show up only when there were no network connections?
I have connection to eduroam network, and I don't know how to "forget" it in Kindle Menu.

Also, this one is a simple username/password UI?
eduroam needs all kinds of parameters for Enterprise settings, so this PR is probably won't work for me :D

NiLuJe · 2024-06-28T16:04:28Z

It's the standard UI, and behaves roughly like the stock ones, i.e., unless it can connect to a previously setup preferred netwokr, you get shown a network list.

And, indeed, eduroam would require manual labor to setup ;).

(My only experience with eduroam was quite a few years ago on macOS, so things may be slightly less ridiculous nowadays. But, FWIW, I'd never done that on an eReader, it was usually faster to setup a Wi-Fi hotspot on my phone).

mergen3107 · 2024-06-28T16:11:10Z

unless it can connect to a previously setup preferred netwokr, you get shown a network list.

Can I see network list even with existing network?

I noticed I have a very weird thing. Kindle connects to a different network that I probably accidentally hit one day.

While in KOReader, I turn on Wi-Fi, then it connects to this stupid network and I need to quit and setup eduroam all over again :D

This PR could have helped me save a few steps.

I vaguely remember something about /var/local/ folder and wpa-supplicant files I needed to wipe to forget all networks. Are there any gentler ways to forget networks on Kindle? :D

NiLuJe · 2024-06-28T16:18:39Z

A long-press on the Wi-Fi menu entry will force the scan list to display (it won't prevent the connection attempt to go through, though, so you'll see the preferred network as "connected". Even though, on Kindle, it's sort of not actually entirely connected yet ^^).

I imagine you can forget about networks in the stock WiFi setting, though.

mergen3107 · 2024-06-28T17:04:01Z

A long-press on the Wi-Fi menu entry will force the scan list to display
Is this in KOReader?

mergen3107 · 2024-06-28T17:05:32Z

Lol, I figured out how to forget networks in Kindle. After it is connected, hit it again, and it will ask to forget the network xD

mergen3107 · 2024-07-02T14:27:09Z

I found a cosmetic bug.
I was at home, connected to home network OK.
Then went to school with eduroam, and it said that it is connecting to home network, but actually connected to eduroam OK.

notmarek · 2024-07-02T14:29:07Z

probably a kindle bug since the info is grabbed straight from lipc

…

On Tue 2. 7. 2024 at 16:27, mergen3107 ***@***.***> wrote: I found a cosmetic bug. I was at home, connected to home network OK. Then went to school with eduroam, and it said that it is connecting to home network, but actually connected to eduroam OK. — Reply to this email directly, view it on GitHub <#12056 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANZQHJWL4EPIZ7YJ46FIVXDZKK2FLAVCNFSM6AAAAABJUF7V3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTGM3DSMZWHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

mergen3107 · 2024-07-02T14:29:24Z

I still can't find a way to bring up a list of networks (Kindle Scribe).
Long pressing on the Wi-Fi Connection brings up a popup window that says

Wi-Fi is enabled, but you're currently not connected to a network.
How would you like to proceed?
Dismiss
Turn Wi-Fi off
Connect

~~However, that statement is wrong. Kindle is connected and I was able to update over the OTA and connected via sftp to PC.~~
(see below)

notmarek · 2024-07-02T14:29:33Z

I don't think there's a forget button in koreader, otherwise I would've implemented it too

…

On Fri 28. 6. 2024 at 19:05, mergen3107 ***@***.***> wrote: Lol, I figured out how to forget networks in Kindle. After it is connected, hit it again, and it will ask to forget the network xD — Reply to this email directly, view it on GitHub <#12056 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANZQHJUBKBUW2JGPW3JFBK3ZJWJXFAVCNFSM6AAAAABJUF7V3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGMZTOMBYGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

mergen3107 · 2024-07-02T14:30:00Z

probably a kindle bug since the info is grabbed straight from lipc

@notmarek
Should I play around with pause times in between commands?

mergen3107 · 2024-07-02T14:31:45Z

However, that statement is wrong.

Oops, it seems network actually did not connect the second time :D

mergen3107 · 2024-07-02T14:55:09Z

OK, so some mysteries. I don't remember if that starting happening with this PR though.
Sorry for the spam (I can also start a new ticket if you guys insist).

KOReader connects to eduroam first time in a day no problem.
However, if I try connect and disconnect in a short time in between it couldn't connect anymore and I need to go Kindle's menu to reconfigure it again (account and password after a 2-min timeout, mainly).
In some of those time when eduroam connection is failed KOReader connects to a different password-less network, which I never connected to before with Kindle at all.
Does KOReader fallback to that network or something?

NiLuJe · 2024-07-03T02:19:24Z

We don't do anything, it's all wifid.

* Kindle: Implement a NetworkMgr backend loosely based on WpaClient in order to allow feature-parity with hasWifiManager platforms. This involves dealing with the native wifid over lipc (the native IPC system, based on DBus), through custom Lua bindings (https://github.com/notmarek/openlipclua), since the stock ones lack support for the needed hasharray data type. * NetworkMgr: Clear up leftover hallucinations from koreader#10669, making `enableWifi` much simpler (and much more similar to `turnOnWifiAndWaitForConnection`). * NetworkMgr: Made it clearer that `turnOnWifi` implementations *must* deal with `complete_callback`, as part of the aforementioned changes mean that it's *always* wrapped in a connectivity check, and we need that for proper event signaling. * Android, Emu: Run `complete_callback` properly in `turnOnWifi`. * Kindle: Support `powerd:isCharged()` on the PW2 (yes, this is random, it just happened to be my test device :D). * NetworkMgr:disableWifi: Properly tear down any potential ongoing connection attempt (e.g., connectivity check). * NetworkMgr:promptWifi: Make the "wifi enabled but not connected" popup clearer if there's an ongoing connection attempt, and gray out the "Connect" button in this case (as it would only lead to another "connection already in progress" popup anyway). * NetworkMgr:reconnectOrShowNetworkMenu: Make *total* scanning failures fatal (they will lead to an immediate wifi teardown). * NetworkMgr:reconnectOrShowNetworkMenu: Clear up the long-press behavior (which *always* shows the network list popup) so that it doesn't weirdly break all the things (technical term!). * NetworkMgr:reconnectOrShowNetworkMenu: When we manage to connect to a preferred network on our own *before* showing the network list, make sure it is flagged as "connected" in said list. * NetworkMgr:reconnectOrShowNetworkMenu: Make connection failures fatal in non-interactive workflows (they'll lead to a wifi teardown). * NetworkSetting (the aforementioned network list widget): Clear NetworkMgr's "connection pending" flag on dismiss when nothing else will (i.e., when there's no connectivity check ticking).

Marek and others added 6 commits June 20, 2024 14:58

kindle - NetworkMgr:getCurrentNetwork

f0f60ec

render network list

0de297b

saving works

3cc8736

typo

b4cd763

Fix ci checks

29fa323

WebDav: Simplify path manipulations to fix wonky heuristics (koreader…

b5a822c

…#12038) This prevents the current directory from appearing in the listing.

NiLuJe mentioned this pull request Jun 20, 2024

Ship openlipclua koreader/koreader-base#1829

Merged

NiLuJe reviewed Jun 20, 2024

View reviewed changes

Comment thread frontend/device/kindle/device.lua Outdated

NiLuJe reviewed Jun 20, 2024

View reviewed changes

Comment thread frontend/device/kindle/device.lua Outdated

jonnyl2 and others added 8 commits June 21, 2024 14:53

Fix Arabic keyboard layout (ظ key) (koreader#12063)

844d139

Closes koreader#12005.

[NT] MenuWidget: add keyboard shortcuts for start/end (koreader#12065)

041ca07

translator: fix settings menu order (koreader#12051)

527fd05

remove comment and stray ;

70c8ab5

Fix save screenshot dialog wasn't modal (koreader#12067)

ad8e78c

Screenshot dialog could not be interacted with in Text editor. Closes koreader#12066.

Make sure we keep refreshing the menu properly on connect

e05082e

Destroy objects explicitly instead of waiting for a GC sweep

20c8334

It gets a biiit clunkier ;).

Fix kindleGetCurrentProfile

1e6f87e

This comment was marked as outdated.

Sign in to view

Marek and others added 6 commits June 22, 2024 10:52

fetch password for known networks

9132b18

fix get current network

b9a70c2

Try to simplify the madnesshappening in NetworkMgr:enableWifi

22d12be

Goodbye trailing whitespaces

109cd5a

Simplify that some more

143a91d

More enableWifi musings...

251374a

NiLuJe and others added 2 commits June 24, 2024 19:58

Bump android-luajit-launcher (koreader#12084)

b7fc048

Long time no update. A lot of changes.

NiLuJe added this to the 2024.06 milestone Jun 24, 2024

NiLuJe and others added 2 commits June 24, 2024 23:10

Address review comments

0f2222d

Update frontend/device/kindle/device.lua

b7aacd1

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

NiLuJe reviewed Jun 24, 2024

View reviewed changes

Comment thread frontend/device/kindle/device.lua

Frenzie approved these changes Jun 25, 2024

View reviewed changes

This comment was marked as spam.

Sign in to view

Merge branch 'notmarek-master'

b0f9d6e

Frenzie merged commit 4c4cfa2 into koreader:master Jun 25, 2024

Frenzie added the Kindle label Jun 25, 2024

mergen3107 mentioned this pull request Oct 14, 2024

Kindle Scribe - wrong network selected when in new place #12639

Closed

Frenzie mentioned this pull request Apr 4, 2025

Sync Reading Process Crashes on Kindle if no WiFi #13506

Open

Uh oh!

Uh oh!

Conversation

notmarek commented Jun 20, 2024 • edited by Frenzie Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

notmarek commented Jun 20, 2024

Uh oh!

notmarek commented Jun 22, 2024

Uh oh!

NiLuJe commented Jun 22, 2024

Uh oh!

notmarek commented Jun 22, 2024

Uh oh!

NiLuJe commented Jun 22, 2024

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as spam.

Uh oh!

NiLuJe commented Jun 25, 2024

Uh oh!

mergen3107 commented Jun 28, 2024

Uh oh!

NiLuJe commented Jun 28, 2024

Uh oh!

mergen3107 commented Jun 28, 2024

Uh oh!

NiLuJe commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergen3107 commented Jun 28, 2024

Uh oh!

mergen3107 commented Jun 28, 2024

Uh oh!

mergen3107 commented Jul 2, 2024

Uh oh!

notmarek commented Jul 2, 2024 via email

Uh oh!

mergen3107 commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

notmarek commented Jul 2, 2024 via email

Uh oh!

mergen3107 commented Jul 2, 2024

Uh oh!

mergen3107 commented Jul 2, 2024

Uh oh!

mergen3107 commented Jul 2, 2024

Uh oh!

NiLuJe commented Jul 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

notmarek commented Jun 20, 2024 •

edited by Frenzie

Loading

NiLuJe commented Jun 28, 2024 •

edited

Loading

mergen3107 commented Jul 2, 2024 •

edited

Loading