Skip to content

trim down libk2pdfopt#1837

Merged
Frenzie merged 5 commits into
koreader:masterfrom
benoit-pierre:pr/k2opt_trim
Jun 23, 2024
Merged

trim down libk2pdfopt#1837
Frenzie merged 5 commits into
koreader:masterfrom
benoit-pierre:pr/k2opt_trim

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Jun 23, 2024

Copy link
Copy Markdown
Member
  • only compile & export what's needed for koreader
  • compile a static tesseract library

Depends on koreader/libk2pdfopt#53.

Impact on release builds code (bss+data+text) and file sizes:

android-arm64 emulator kindlepw2
code -3.9 MB -3.9 MB -3.7 MB
file -739.3 KB -818.3 KB -603.4 KB

This change is Reviewable

Only compile & export what's needed for koreader: reduce code
size (bss+data+text) by ~3.5 MB and file size by ~315-405 KB.
It's only needed by libk2pdfopt: reduce code size (bss+data+text)
by ~270-380 KB and file size by ~276-409 KB.
Go through a dedicated cmake file, so it can be used by an external cmake project.
NOTE: `bmp_bytewidth` is not used by the LUA code,
but necessary for our `koreader-djvu` library.
Reduce code size (bss+data+text) by ~2-4 KB and file size by ~4-12 KB.
@benoit-pierre benoit-pierre marked this pull request as ready for review June 23, 2024 06:24
@Frenzie Frenzie merged commit b5fa5d9 into koreader:master Jun 23, 2024
@benoit-pierre benoit-pierre deleted the pr/k2opt_trim branch June 24, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants