Skip to content

Minor third-party bumps#1828

Merged
NiLuJe merged 3 commits into
koreader:masterfrom
NiLuJe:master
Jun 20, 2024
Merged

Minor third-party bumps#1828
NiLuJe merged 3 commits into
koreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe

@NiLuJe NiLuJe commented Jun 18, 2024

Copy link
Copy Markdown
Member

Nothing major in LuaJIT
And LPeg & LuaJSON because I noticed the lpeg update on Gentoo ;p.

I'm not even, sure we actually have anything that still uses laujson in front...


This change is Reviewable

@NiLuJe

NiLuJe commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

I'm not even, sure we actually have anything that still uses luajson in front...

Oh, quite a lot of stuff actually...

@NiLuJe

NiLuJe commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

I'm not even, sure we actually have anything that still uses luajson in front...

Oh, quite a lot of stuff actually...

And since we like shipping thirty different JSON parsers, I'll add that dksjon looks like a slightly less abandoned variant ;).

@NiLuJe

NiLuJe commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

And since we like shipping thirty different JSON parsers, I'll add that dksjon looks like a slightly less abandoned variant ;).

Snark aside, there's a potential cleanup opportunity to drop luajson in favor of lunajson (or, well, rapidjson even) for the few things using it in main.

(IIRC, we still need lpeg for lua-Spore, though. EDIT: Nope ^^.).

@pazos

pazos commented Jun 18, 2024

Copy link
Copy Markdown
Member

Snark aside, there's a potential cleanup opportunity to drop luajson in favor of lunajson (or, well, rapidjson even) for the few things using it in main.

Do you mean

require("json")

or yet another implementation ?

@NiLuJe

NiLuJe commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

Yeah, that's what tripped me up in saying we weren't using luajson anymore: I was looking for a require("luajson"), but that's indeed luajson ;).

@NiLuJe NiLuJe merged commit 66f19df into koreader:master Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants