Skip to content

ffi/sdl: tweak support for EMULATE_BW_SCREEN#1835

Merged
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/tweak_EMULATE_BW_SCREEN_handling
Jun 22, 2024
Merged

ffi/sdl: tweak support for EMULATE_BW_SCREEN#1835
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/tweak_EMULATE_BW_SCREEN_handling

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Jun 22, 2024

Copy link
Copy Markdown
Member

Check for a non-empty value.

Will make it easier to update kodev's run support for --simulate:

--- i/kodev
+++ w/kodev
@@ -582,6 +582,7 @@ TARGET:
     #       Just append --suppressions=${PWD/tools/valgrind_amd.supp to your valgrind command.
 
     # Defaults
+    screen_bw=
     screen_width=540
     screen_height=720
     export KODEBUG=1
@@ -685,6 +686,7 @@ TARGET:
                 device_model="${VALUE}"
                 case "${device_model}" in
                     kindle)
+                        screen_bw=1
                         screen_width=600
                         screen_height=800
                         screen_dpi=167
@@ -827,7 +829,7 @@ TARGET:
                 RETURN_VALUE=85
                 while [ "${RETURN_VALUE}" -eq 85 ]; do
                     # shellcheck disable=SC2086
-                    env EMULATE_READER_W="${screen_width}" EMULATE_READER_H="${screen_height}" EMULATE_READER_DPI="${screen_dpi}" \
+                    env EMULATE_BW_SCREEN="${screen_bw}" EMULATE_READER_W="${screen_width}" EMULATE_READER_H="${screen_height}" EMULATE_READER_DPI="${screen_dpi}" \
                         ${KOREADER_COMMAND}
                     RETURN_VALUE=$?
                 done

This change is Reviewable

Check for a non-empty value.
@Frenzie Frenzie merged commit f80dc33 into koreader:master Jun 22, 2024
@benoit-pierre benoit-pierre deleted the pr/tweak_EMULATE_BW_SCREEN_handling branch June 22, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants