Skip to content

Fix Arabic keyboard layout (ظ key) #12063

Merged
Frenzie merged 1 commit into
koreader:masterfrom
jonnyl2:ar-keyboard
Jun 21, 2024
Merged

Fix Arabic keyboard layout (ظ key) #12063
Frenzie merged 1 commit into
koreader:masterfrom
jonnyl2:ar-keyboard

Conversation

@jonnyl2

@jonnyl2 jonnyl2 commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

As reported in #12005: ث was duplicated; ظ was missing.

Fixed layout:

image

Closes #12005.


This change is Reviewable

@Frenzie Frenzie added this to the 2024.06 milestone Jun 21, 2024
@Frenzie Frenzie merged commit 844d139 into koreader:master Jun 21, 2024
@jonnyl2 jonnyl2 deleted the ar-keyboard branch June 21, 2024 14:44
@malgakhalil

Copy link
Copy Markdown

@jonnyl2
first of all thank you for your time and your effort to fix the issue
second in Ower arabic keyboard the keymaps are almost all the same but only one letter is not in her place soo can you fix it
Screenshot_20240706-073243~2
thank yu and sorry for disturbing you

@jonnyl2

jonnyl2 commented Jul 6, 2024

Copy link
Copy Markdown
Contributor Author

@malgakhalil: The full-size keyboard has the د key in the upper row as well (for example, see https://www.arabickeyboardonline.com/). However, I'm not a user of Arabic myself so I can't argue for one or the other layout. If there are good reasons why the key should be in the third row, please raise a new issue so other Arabic users and KOReader devs also get a chance to discuss it. Thank you.

@malgakhalil

malgakhalil commented Jul 11, 2024

Copy link
Copy Markdown

good solu thank you @jonnyl2
one more question i have installed the last koreader version but the letter ث still duplicated and you sad that the layout is fixed !!!

@benoit-pierre

Copy link
Copy Markdown
Member

The fix is not part of the latest stable release, it's available in the nightlies.

@malgakhalil

Copy link
Copy Markdown

@jonnyl2
ah okk
can you explain more i mean how to get the fixed layout
bcz I'm not pro in some stuffs
but if you give some help so instructions i can follow
and thanks for your humility

@jonnyl2

jonnyl2 commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

If you usually update KOReader on the app (OTA - over the air), you can switch to developer channel (Update -> Settings -> Update channel -> Development), and then update as normal.

Or you can download the latest nightly build here:
https://build.koreader.rocks/download/nightly/

@malgakhalil

Copy link
Copy Markdown

Screenshot_20240711-184759
thnxx @jonnyl2
its worked
does all other version are updated bcz i wont to modify it on my kobo also

@jonnyl2

jonnyl2 commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

Yes, all should be updated. Kobo definitely is.

@malgakhalil

Copy link
Copy Markdown

ok i will try thnxx
@jonnyl2
thank for your help
if you need anything just send me i will do my best
and btw im muslim if you want to discuss about islam im here
finally thnx a lot for your help

Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Aug 2, 2024
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arabic keyboard ث letter is doubled, ظ is missing

4 participants