Choose database for saving or updating entries from KeePassXC-Browser by varjolintu · Pull Request #2391 · keepassxreboot/keepassxc

varjolintu · 2018-10-17T13:45:30Z

When updating or creating credentials from KeePassXC-Browser an additional dialog is shown.

Description

If the user has multiple open databases and credentials are saved or updated from KeePassXC-Browser, a popup dialog is displayed where the correct one must be choosed (or cancel the operation).

The current active database is selected by default.

Motivation and context

Fixes #1791.

How has this been tested?

Manually. Because of the changed, I'll add some new tests for DatabaseTabWidget if necessary.

Screenshots (if appropriate):

Types of changes

✅ New feature (non-breaking change which adds functionality)

Checklist:

✅ I have read the CONTRIBUTING document. [REQUIRED]
✅ My code follows the code style of this project. [REQUIRED]
✅ All new and existing tests passed. [REQUIRED]
✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

droidmonkey · 2018-10-17T20:31:01Z

Can you also output the database name (if available), not just the file, in the dialog?

varjolintu · 2018-10-18T04:57:47Z

@droidmonkey It already does that. See line 677. But I guess you meant both at the same time?

droidmonkey · 2018-10-18T10:42:32Z

Yes sir.

[DB_NAME] (FILENAME)

varjolintu · 2018-10-18T13:56:14Z

@droidmonkey Fixed. Screenshot is also updated.

src/browser/BrowserEntrySaveDialog.cpp

droidmonkey · 2018-10-18T20:56:03Z

src/browser/BrowserEntrySaveDialog.cpp

+ QList<QListWidgetItem*> BrowserEntrySaveDialog::getSelected() const
+ {
+    return ui->itemsList->selectedItems();
+ }


Missing newline at end

src/browser/BrowserEntrySaveDialog.h

droidmonkey · 2018-10-18T20:56:29Z

src/browser/BrowserEntrySaveDialog.h

+    QList<QListWidgetItem *> getSelected() const;
+
+private:
+    QScopedPointer<Ui::BrowserEntrySaveDialog> ui;


droidmonkey · 2018-10-18T20:56:49Z

src/browser/BrowserEntrySaveDialog.h

+
+public:
+    explicit BrowserEntrySaveDialog(QWidget* parent = nullptr);
+    ~BrowserEntrySaveDialog();


droidmonkey · 2018-10-18T21:00:37Z

src/gui/DatabaseTabWidget.cpp

+    return widgetList;
+}
+
+QString DatabaseTabWidget::getTabName(DatabaseWidget* dbWidget, const bool includeFilename) const


It would be better to refactor so that the databaseWidget knows what it's filename is and you query it directly. We are perpetuating the terrible code that is databaseTabWidget...

droidmonkey · 2018-10-18T21:01:17Z

src/browser/BrowserEntrySaveDialog.cpp

+{
+    uint counter = 0;
+    int activeIndex = -1;
+    for (const auto i : databaseWidgets) {


const auto dbWidget

droidmonkey · 2018-10-18T21:01:46Z

src/browser/BrowserEntrySaveDialog.cpp

+    int activeIndex = -1;
+    for (const auto i : databaseWidgets) {
+        QListWidgetItem* item = new QListWidgetItem();
+        item->setText(dbTabWidget->getTabName(i, true));


As discussed in an earlier comment, I would rather this come directly from the databaseWidget itself. We should not be extending the databaseTabWidget anymore.

varjolintu · 2018-10-19T07:01:04Z

@droidmonkey Moved the file and tab name functionality to DatabaseWidget instead. Screenshot updated (also showing an unsaved database that is connected to KeePassXC-Browser).

- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]

varjolintu added the feature: Browser label Oct 17, 2018

varjolintu added this to the v2.4.0 milestone Oct 17, 2018

varjolintu requested review from TheZ3ro, droidmonkey, phoerious and weslly October 17, 2018 13:45

varjolintu force-pushed the entry_save_dialog branch from b5343c4 to 631f468 Compare October 17, 2018 13:56

varjolintu force-pushed the entry_save_dialog branch 3 times, most recently from 503c33d to 27ec2ac Compare October 18, 2018 13:53

droidmonkey requested changes Oct 18, 2018

View reviewed changes

varjolintu force-pushed the entry_save_dialog branch from 9258eaa to c175cdb Compare October 19, 2018 06:58

BrowserEntrySaveDialog

a661646

varjolintu force-pushed the entry_save_dialog branch from c175cdb to a661646 Compare October 19, 2018 08:12

droidmonkey approved these changes Oct 19, 2018

View reviewed changes

droidmonkey added the PR: Ready for Merge label Oct 19, 2018

weslly approved these changes Oct 19, 2018

View reviewed changes

droidmonkey merged commit b8d2d5d into keepassxreboot:develop Oct 19, 2018

varjolintu deleted the entry_save_dialog branch October 21, 2018 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Choose database for saving or updating entries from KeePassXC-Browser#2391

Choose database for saving or updating entries from KeePassXC-Browser#2391
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:entry_save_dialog

varjolintu commented Oct 17, 2018 •

edited

Loading

Uh oh!

droidmonkey commented Oct 17, 2018

Uh oh!

varjolintu commented Oct 18, 2018 •

edited

Loading

Uh oh!

droidmonkey commented Oct 18, 2018 •

edited

Loading

Uh oh!

varjolintu commented Oct 18, 2018

Uh oh!

Uh oh!

droidmonkey Oct 18, 2018

Uh oh!

Uh oh!

droidmonkey Oct 18, 2018

Uh oh!

droidmonkey Oct 18, 2018

Uh oh!

droidmonkey Oct 18, 2018

Uh oh!

droidmonkey Oct 18, 2018

Uh oh!

droidmonkey Oct 18, 2018 •

edited

Loading

Uh oh!

varjolintu commented Oct 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

varjolintu commented Oct 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

droidmonkey commented Oct 17, 2018

Uh oh!

varjolintu commented Oct 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

droidmonkey commented Oct 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varjolintu commented Oct 18, 2018

Uh oh!

Uh oh!

droidmonkey Oct 18, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

droidmonkey Oct 18, 2018

Choose a reason for hiding this comment

Uh oh!

droidmonkey Oct 18, 2018

Choose a reason for hiding this comment

Uh oh!

droidmonkey Oct 18, 2018

Choose a reason for hiding this comment

Uh oh!

droidmonkey Oct 18, 2018

Choose a reason for hiding this comment

Uh oh!

droidmonkey Oct 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

varjolintu commented Oct 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

varjolintu commented Oct 17, 2018 •

edited

Loading

varjolintu commented Oct 18, 2018 •

edited

Loading

droidmonkey commented Oct 18, 2018 •

edited

Loading

droidmonkey Oct 18, 2018 •

edited

Loading