Use custom data to save any browser integration related data by varjolintu · Pull Request #1497 · keepassxreboot/keepassxc

varjolintu · 2018-02-19T11:54:39Z

Description

Browser connection keys and Allow/Deny rules are stored to custom data instead of attributes.

Motivation and context

Fixes keepassxreboot/keepassxc-browser#11.

How has this been tested?

Tested manually with the latest KeePassXC-Browser.

Types of changes

✅ Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

✅ I have read the CONTRIBUTING document. [REQUIRED]
✅ My code follows the code style of this project. [REQUIRED]
✅ All new and existing tests passed. [REQUIRED]
✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

droidmonkey · 2018-02-20T00:59:54Z

This needs to be rebased and cleaned up after the Custom Data PR is merged.

phoerious · 2018-02-21T13:21:29Z

I wonder if there should be some transitional code for those who have used the old implementation. Maybe even check if we are using KDBX 4 already and then convert all string attributes to custom data, otherwise, keep using string attributes.

varjolintu · 2018-02-24T09:08:29Z

This PR still needs a way to view/delete the stored keys. So a little more work is needed.

varjolintu · 2018-02-26T10:26:10Z

Added the key view/removal to Browser Integration settings window and rebased.

varjolintu · 2018-03-03T06:55:38Z

This feature will be added #1591 to the PR.

droidmonkey · 2018-03-03T19:41:57Z

This also needs to convert existing attributes to custom data, or will you be supporting both?

varjolintu · 2018-03-04T05:26:07Z

@droidmonkey I'll do a feature that converts both KeePassHTTP and KeePassXC-Browser attributes to custom data. I will not support both of them.

varjolintu · 2018-03-05T07:05:13Z

Button added to Browser Integration settings page. Rebased.

varjolintu · 2018-09-26T04:38:05Z

@droidmonkey I agree. This should be asked automatically (but still leaving the manual button just in case). If the KeePassXC-Browser Settings attribute is found, the conversion popup dialog appears. I'll do the necessary fixes today.

varjolintu · 2018-09-26T12:14:56Z

I noticed that the keys are not converted to custom data, but instead still using the old KeePassXC-Browser entry method. Maybe this needs to be changed too.

droidmonkey · 2018-09-26T12:26:32Z

IMO the browser entry should be deleted and the attributes moved to the root folder custom data.

We can also store the default folder location (user choice) for new entries made from the plugin in that custom data. Let's think outside the box a little.

varjolintu · 2018-09-26T15:12:36Z

Key conversion done. (Please review the dialog text).

Every time database is opened, BrowserService class checks if there are any old attributes or old key entry. If found, a popup dialog is shown.

varjolintu · 2018-09-27T06:27:25Z

Key count added to the popup dialog. Checking for legacy settings has been moved to another function.

droidmonkey

Side note: when I remove connection keys from the database, the browser plugin remains connected to the database until it is locked. If I remove a key, I expect the browser plugin to lose connection immediately.

droidmonkey · 2018-10-04T13:42:25Z

src/browser/BrowserOptionDialog.cpp

+    if (QMessageBox::Yes != MessageBox::question(this,
+            tr("Delete the selected key?"),
+            tr("Do you really want to delete the selected key?\n"
+               "This may cause the affected plugins to malfunction."),


What does it mean to malfunction? I think the correct verbiage here is "This may prevent connection to the browser plugin."

Note that we warn when you remove an individual key, but when you click on "Disconnect all browsers" it just does it without any confirmation. Same with "Forget all remembered permissions" which is a little bit confusing, this button should probably say "Forget all site-specific settings on entries".

I agree. There should be confirmation for each of these actions.

droidmonkey · 2018-10-04T13:47:04Z

src/browser/BrowserService.cpp

-                                 tr("KeePassXC: Settings not available!"),
+    Database* db = getDatabase();
+    if (!db) {
+        QMessageBox::information(0, tr("KeePassXC: Settings not available!"),


Technically if you reach here you do not have an active database. I think this warning can be dropped.

droidmonkey · 2018-10-04T13:51:10Z

src/browser/BrowserService.cpp

+        return;
+    }
+
+    Database* db = m_dbTabWidget->currentDatabaseWidget()->database();


Why isn't "getDatabase()" used here?

Here is my problem with this settings dialog, application settings are meant to be global. So these buttons make no sense at all. Basically I have to have the correct database selected prior to hitting the settings button, which is an undiscoverable "feature".

Here are some options:

Move everything below "Sort matching credentials..." into the database settings

Add a drop-down selection list above the buttons that let's you select from the currently open databases.

To me, option 1 is the most acceptable because it makes sense. It is also where the KeeShare settings are going so that would be consistent.

A separate Browser Integration page should be added to the Database settings. Then it would be nice and clean.

droidmonkey · 2018-10-04T13:56:53Z

src/browser/BrowserService.cpp

+    auto dialogResult = QMessageBox::warning(nullptr,
+                                             tr("KeePassXC: Legacy browser integration settings detected"),
+                                             tr("Legacy browser integration settings have been detected.\n"
+                                                "Do you want to transfer the settings and stored keys to custom data?\n"


I would just say "Do you want to upgrade the settings to the latest standard?\nThis is necessary to maintain compatibility with the browser plugin."

varjolintu · 2018-10-09T11:06:02Z

An update:

Moved database specific settings from Browser Intergration settings to Database settings
Added confirmation popup dialog to the buttons before removing or converting any data
Cleaned the code from Browser Integration side

varjolintu · 2018-10-10T06:44:13Z

A final update:

Added a warning message (and disabled the buttons etc.) to Database settings browser page when Browser Integration is disabled.

varjolintu · 2018-10-24T14:07:23Z

One more update:

Only keys with a KeePassXC-Browser specific prefix are shown in the Database settings custom data list
Key prefix is stripped from the key string

…f attributes

- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]

varjolintu added the feature: Browser label Feb 19, 2018

varjolintu mentioned this pull request Feb 19, 2018

Use custom data to save browser connection keys keepassxreboot/keepassxc-browser#11

Closed

droidmonkey added the needs work label Feb 20, 2018

varjolintu force-pushed the feature/custom-data-browser branch 2 times, most recently from d569e33 to 06fadb4 Compare February 21, 2018 13:12

droidmonkey added this to the v2.3.0 milestone Feb 24, 2018

varjolintu force-pushed the feature/custom-data-browser branch from f1194d2 to fe5eb02 Compare February 26, 2018 10:25

varjolintu force-pushed the feature/custom-data-browser branch 2 times, most recently from e873c4d to a53196b Compare February 27, 2018 13:04

phoerious modified the milestones: v2.3.0, 2.3.1 Feb 27, 2018

varjolintu changed the base branch from release/2.3.0 to develop February 28, 2018 14:25

varjolintu force-pushed the feature/custom-data-browser branch from a53196b to 60d8670 Compare February 28, 2018 14:26

varjolintu mentioned this pull request Mar 3, 2018

Add a button in the settings to automatically rename every "KeePassHttp Settings" attributes to "KeePassXC-Browser Settings" #1591

Closed

varjolintu changed the base branch from develop to release/2.3.1 March 3, 2018 06:54

varjolintu force-pushed the feature/custom-data-browser branch from 60d8670 to aad4cd9 Compare March 3, 2018 06:55

phoerious modified the milestones: 2.3.1, v2.4.0 Mar 3, 2018

varjolintu force-pushed the feature/custom-data-browser branch from 1c7ee40 to 53165ea Compare March 5, 2018 07:04

varjolintu removed the needs work label Mar 5, 2018

varjolintu mentioned this pull request Mar 5, 2018

accept "KeePassHttp Settings" attribute keepassxreboot/keepassxc-browser#47

Closed

varjolintu requested a review from phoerious March 5, 2018 16:16

varjolintu force-pushed the feature/custom-data-browser branch from cc70244 to 64e4417 Compare September 26, 2018 15:11

varjolintu force-pushed the feature/custom-data-browser branch from 64e4417 to c923453 Compare September 27, 2018 06:26

droidmonkey requested changes Oct 4, 2018

View reviewed changes

varjolintu force-pushed the feature/custom-data-browser branch 2 times, most recently from 5465cbf to d382905 Compare October 9, 2018 11:04

varjolintu force-pushed the feature/custom-data-browser branch 5 times, most recently from 1e5c684 to 0e2b789 Compare October 10, 2018 06:43

droidmonkey force-pushed the feature/custom-data-browser branch from 0e2b789 to b9057b9 Compare October 23, 2018 19:25

varjolintu force-pushed the feature/custom-data-browser branch from 58f27fc to 0e9a618 Compare October 24, 2018 14:06

varjolintu force-pushed the feature/custom-data-browser branch from 0e9a618 to 008f41a Compare October 24, 2018 14:37

Browser connection keys and rules are stored in custom data instead o…

76095d0

…f attributes

droidmonkey force-pushed the feature/custom-data-browser branch from 008f41a to 76095d0 Compare October 24, 2018 14:49

droidmonkey approved these changes Oct 24, 2018

View reviewed changes

droidmonkey merged commit efdb43d into keepassxreboot:develop Oct 24, 2018

varjolintu deleted the feature/custom-data-browser branch October 24, 2018 14:51

gyli mentioned this pull request Mar 27, 2019

Use KeePassXC-Broswer custom data instead of KeePassHTTP attributes smorks/keepassnatmsg#28

Closed

phoerious added pr: new feature Pull request adds a new feature and removed new feature labels Nov 22, 2024

Uh oh!

Conversation

varjolintu commented Feb 19, 2018 • edited by droidmonkey Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and context

How has this been tested?

Types of changes

Checklist:

Uh oh!

droidmonkey commented Feb 20, 2018

Uh oh!

phoerious commented Feb 21, 2018

Uh oh!

varjolintu commented Feb 24, 2018

Uh oh!

varjolintu commented Feb 26, 2018

Uh oh!

varjolintu commented Mar 3, 2018

Uh oh!

droidmonkey commented Mar 3, 2018

Uh oh!

varjolintu commented Mar 4, 2018

Uh oh!

varjolintu commented Mar 5, 2018

Uh oh!

varjolintu commented Sep 26, 2018

Uh oh!

varjolintu commented Sep 26, 2018

Uh oh!

droidmonkey commented Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varjolintu commented Sep 26, 2018

Uh oh!

varjolintu commented Sep 27, 2018

Uh oh!

droidmonkey left a comment

Choose a reason for hiding this comment

Uh oh!

droidmonkey Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

varjolintu Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

droidmonkey Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

droidmonkey Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

varjolintu Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

droidmonkey Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

varjolintu commented Oct 9, 2018

Uh oh!

varjolintu commented Oct 10, 2018

Uh oh!

varjolintu commented Oct 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

varjolintu commented Feb 19, 2018 •

edited by droidmonkey

Loading

droidmonkey commented Sep 26, 2018 •

edited

Loading

varjolintu commented Oct 24, 2018 •

edited

Loading