Add option to list elements recursively in the cli#2345
Merged
phoerious merged 2 commits intokeepassxreboot:developfrom Oct 3, 2018
Merged
Add option to list elements recursively in the cli#2345phoerious merged 2 commits intokeepassxreboot:developfrom
phoerious merged 2 commits intokeepassxreboot:developfrom
Conversation
phoerious
requested changes
Oct 2, 2018
Member
phoerious
left a comment
There was a problem hiding this comment.
Thank you for your submission. There are a few things I need you to change.
src/cli/List.cpp
Outdated
| QObject::tr("Key file of the database."), | ||
| QObject::tr("path")); | ||
| parser.addOption(keyFile); | ||
| parser.addOption({{"R", "recursive"}, "Recursive mode, list elements recursively"}); |
Member
There was a problem hiding this comment.
This needs an explicit QStringList() lvalue as in the example above. The description also needs to be wrapped in QObject::tr().
src/cli/List.cpp
Outdated
| return EXIT_FAILURE; | ||
| } | ||
|
|
||
| bool recursive = parser.isSet({"R", "recursive"}); |
Member
There was a problem hiding this comment.
Re-use the explicit command line option from above.
phoerious
approved these changes
Oct 3, 2018
61747de to
56e478e
Compare
* Make the command line option an explicit QCommandLine option * Wrap the description in a QObject::tr for translation purposes
coelebs
added a commit
to coelebs/keepassxc
that referenced
this pull request
Nov 13, 2018
droidmonkey
added a commit
that referenced
this pull request
Mar 19, 2019
- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In keepassxc-cli it's possible to list the elements in the database but there was no way to list them recursively, this pull request add's that option.
The functionality to recursively print the database was already in the codebase. This pull request only enables the functionality to be used by the end user.
Motivation and context
Removes the need to use "extract" when doing simple scripting tasks.
How has this been tested?
Tested it with several commands:
keepasxc-cli ls database.kdbxLists only the top elements in the database
keepasxc-cli ls -R database.kdbxLists everything from the top element of the database
keepasxc-cli ls database.kdbx groupLists only the top elements of the specified group
keepasxc-cli ls -R database.kdbx groupLists everything from the specified group down
keepasxc-cli lsShows a help screen including the new option.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]