Fix updating reference passwords from KeePassXC-Browser#2218
Merged
droidmonkey merged 2 commits intokeepassxreboot:developfrom Jan 21, 2019
Merged
Fix updating reference passwords from KeePassXC-Browser#2218droidmonkey merged 2 commits intokeepassxreboot:developfrom
droidmonkey merged 2 commits intokeepassxreboot:developfrom
Conversation
4895589 to
a14c9e5
Compare
droidmonkey
requested changes
Aug 22, 2018
Member
droidmonkey
left a comment
There was a problem hiding this comment.
Does not check if the username is also a reference. This function can likely be made generic to update any chosen field and check for references appropriately.
Does this handle recursive references?
Member
|
Please rebase onto develop after 2.3.4 is merged in. |
4264ed6 to
d6cae74
Compare
Member
Author
|
The username is not overwritten when updating credentials. But you are correct that this might not work with recursive references. PR is closed..? |
Member
Author
|
Todo:
|
8a36db2 to
d19d61d
Compare
Member
Author
|
@droidmonkey Necessary changes done. |
Member
|
I'll run it through some tests and see if i can still break it |
d19d61d to
e1e3949
Compare
e1e3949 to
527c49a
Compare
droidmonkey
approved these changes
Jan 17, 2019
droidmonkey
added a commit
that referenced
this pull request
Mar 19, 2019
- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix updating reference passwords from KeePassXC-Browser.
Description
If an entry has a password field as a reference from another entry, updating credentials from KeePassXC-Browser overrides the reference with the new password.
This change detects the reference and updates the password to the original entry instead.
Motivation and context
This solves situations where the original entry doesn't have any URL set, but the clone(s) where the password is used as a reference does.
Fixes keepassxreboot/keepassxc-browser#271.
How has this been tested?
Manually. A test case has been also modified.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]