Show / Hide toolbar from KeePassXC Settings#1819
Merged
TheZ3ro merged 10 commits intokeepassxreboot:developfrom Jul 3, 2018
vsvyatski:develop
Merged
Show / Hide toolbar from KeePassXC Settings#1819TheZ3ro merged 10 commits intokeepassxreboot:developfrom vsvyatski:develop
TheZ3ro merged 10 commits intokeepassxreboot:developfrom
vsvyatski:develop
Conversation
Member
|
There is an open issue wanting that to move this into the settings page (which I agree with): #1618 (comment) |
Contributor
Author
|
@droidmonkey As I understand, this PR needs to be "extended" to allow that setting, doesn't it? |
Member
|
Yes |
Contributor
Author
|
@droidmonkey That is done. The UI was implemented exactly the way it was proposed there. |
droidmonkey
requested changes
Apr 10, 2018
Member
droidmonkey
left a comment
There was a problem hiding this comment.
Looks great, one minor change
| m_inactivityTimer->deactivate(); | ||
| } | ||
|
|
||
| m_ui->toolBar->setHidden(config()->get("GUI/HideToolbar").toBool()); |
Member
There was a problem hiding this comment.
add a second parameter to the get function of "false" or add it to the default config entries in config.cpp
droidmonkey
approved these changes
Apr 10, 2018
TheZ3ro
approved these changes
Jul 3, 2018
Contributor
|
Thanks @vsvyatski for the contribution! 🎉 |
droidmonkey
added a commit
that referenced
this pull request
Mar 19, 2019
- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have noticed that KeePassXC 2.3.1 has an empty context menu shown when one right-clicks on the main menu. It has a checkbox inside. If one selects/unselects the checkbox the application's main toolbar is shown/hidden. I believe this functionality is a leftover from the version 2.2.4 that was meant to be removed. In the 2.2.4 the context menu had the caption "Toolbar" and also there was View > Toolbar item in the main menu which is gone in 2.3.1. So I've just removed that context menu.
Motivation and context
How has this been tested?
It is a small UI bug, so it has been tested only manually. Test environment details are below:
KeePassXC - Version 2.3.1-snapshot
Build Type: Snapshot
Revision: ddc4b9b
Libraries:
Operating system: Manjaro Linux
CPU architecture: x86_64
Kernel: linux 4.14.31-1-MANJARO
Enabled extensions:
Screenshots (if appropriate):
Here is how it looked before this PR
BTW, the same thing was on Windows
This empty menu is now gone.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]