Skip to content

Allows a separate ID key for browser extension association#2185

Merged
droidmonkey merged 1 commit intokeepassxreboot:release/2.3.4from
varjolintu:browser_id_key_fix
Aug 13, 2018
Merged

Allows a separate ID key for browser extension association#2185
droidmonkey merged 1 commit intokeepassxreboot:release/2.3.4from
varjolintu:browser_id_key_fix

Conversation

@varjolintu
Copy link
Copy Markdown
Member

@varjolintu varjolintu commented Aug 7, 2018

Description

When connecting first time from KeePassXC-Browser to multiple databases within the same session, the same public key is used as an identification key. This causes the connections to use identical keys.

This PR allows the use of a separate idKey when saving the connection to KeePassXC. To ensure backward compatibility, the current public key will be used instead.

Motivation and context

Fixes using identical identification keys.
Related KeePassXC-Browser PR: keepassxreboot/keepassxc-browser#258.

How has this been tested?

Manually.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • ✅ My change requires a change to the documentation and I have updated it accordingly.

@droidmonkey droidmonkey merged commit d70a474 into keepassxreboot:release/2.3.4 Aug 13, 2018
@varjolintu varjolintu deleted the browser_id_key_fix branch August 14, 2018 04:36
droidmonkey added a commit that referenced this pull request Aug 22, 2018
- Show all URL schemes in entry view [#1768]
- Disable merge when database is locked [#1975]
- Fix intermittent crashes with favorite icon downloads [#1980]
- Provide potential crash warning to Qt 5.5.x users [#2211]
- Disable apply button when creating new entry/group to prevent data loss [#2204]
- Allow for 12 hour timeout to lock idle database [#2173]
- Multiple SSH Agent fixes [#1981, #2117]
- Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185]
- Fix browser proxy application not closing properly [#2142]
- Add real names and Patreon supporters to about dialog [#2214]
- Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214]
- Enhancements to release-tool to appsign intermediate build products [#2101]
@phoerious phoerious added pr: bugfix Pull request fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Browser pr: bugfix Pull request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants