Add browser extension links to settings page#2159
Merged
droidmonkey merged 1 commit intokeepassxreboot:release/2.3.4from Aug 20, 2018
Merged
Add browser extension links to settings page#2159droidmonkey merged 1 commit intokeepassxreboot:release/2.3.4from
droidmonkey merged 1 commit intokeepassxreboot:release/2.3.4from
Conversation
droidmonkey
approved these changes
Jul 28, 2018
Contributor
|
Instead of placing links to the various stores, what about creating a page like https://keepassxc.org/browser dedicated to the browser-extension project and link that instead? |
Member
Author
|
That could also work, yes. |
Member
|
I am going to approve it as-is for now, we can put together a "browser plugin" landing page for 2.4. This page should also include clear instructions and documentation for the whole process as well. |
droidmonkey
added a commit
that referenced
this pull request
Aug 22, 2018
- Show all URL schemes in entry view [#1768] - Disable merge when database is locked [#1975] - Fix intermittent crashes with favorite icon downloads [#1980] - Provide potential crash warning to Qt 5.5.x users [#2211] - Disable apply button when creating new entry/group to prevent data loss [#2204] - Allow for 12 hour timeout to lock idle database [#2173] - Multiple SSH Agent fixes [#1981, #2117] - Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185] - Fix browser proxy application not closing properly [#2142] - Add real names and Patreon supporters to about dialog [#2214] - Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214] - Enhancements to release-tool to appsign intermediate build products [#2101]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add browser extension links to browser integration settings page.
Description
Previously information about the new browser extension existed only in the FAQ or in the GitHub page. This makes the need of a browser extension more clear to the users.
Motivation and context
Fixes #2158.
How has this been tested?
Manually. Links open in the default browser.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]