Disable apply button to workaround data loss issue#2204
Merged
droidmonkey merged 2 commits intorelease/2.3.4from Aug 18, 2018
Merged
Disable apply button to workaround data loss issue#2204droidmonkey merged 2 commits intorelease/2.3.4from
droidmonkey merged 2 commits intorelease/2.3.4from
Conversation
* Workaround to prevent data loss if apply is hit but not OK or Cancel * Refactor required to fix this issue
phoerious
approved these changes
Aug 15, 2018
droidmonkey
added a commit
that referenced
this pull request
Aug 22, 2018
- Show all URL schemes in entry view [#1768] - Disable merge when database is locked [#1975] - Fix intermittent crashes with favorite icon downloads [#1980] - Provide potential crash warning to Qt 5.5.x users [#2211] - Disable apply button when creating new entry/group to prevent data loss [#2204] - Allow for 12 hour timeout to lock idle database [#2173] - Multiple SSH Agent fixes [#1981, #2117] - Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185] - Fix browser proxy application not closing properly [#2142] - Add real names and Patreon supporters to about dialog [#2214] - Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214] - Enhancements to release-tool to appsign intermediate build products [#2101]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Temporary workaround for #2191. The actual fix requires a refactor to how entries/groups are created and saved (ie, move that function away from DatabaseWidget class).
Also fixes divide by zero error that can occur in the database icon download (found during testing of this issue).
Motivation and context
If a user creates a new entry and only hits apply and then locks the database, the new entry is lost.
How has this been tested?
Corrected automatic tests and manually
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]