SSH Agent: Fix invalid iqmp output for RSA keys#1981
Merged
droidmonkey merged 1 commit intokeepassxreboot:release/2.3.4from Jun 27, 2018
Merged
SSH Agent: Fix invalid iqmp output for RSA keys#1981droidmonkey merged 1 commit intokeepassxreboot:release/2.3.4from
droidmonkey merged 1 commit intokeepassxreboot:release/2.3.4from
Conversation
This fixes loading RSA keys to Pageant.
Member
|
@hifi is this ready for merge? |
Contributor
Author
|
As far as I know but a review of the changes would be appreciated. |
droidmonkey
added a commit
that referenced
this pull request
Aug 22, 2018
- Show all URL schemes in entry view [#1768] - Disable merge when database is locked [#1975] - Fix intermittent crashes with favorite icon downloads [#1980] - Provide potential crash warning to Qt 5.5.x users [#2211] - Disable apply button when creating new entry/group to prevent data loss [#2204] - Allow for 12 hour timeout to lock idle database [#2173] - Multiple SSH Agent fixes [#1981, #2117] - Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185] - Fix browser proxy application not closing properly [#2142] - Add real names and Patreon supporters to about dialog [#2214] - Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214] - Enhancements to release-tool to appsign intermediate build products [#2101]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hex string inside a QByteArray apparently can't be converted into binary array without converting it to a string first. It works but only sometimes.
The changes to gcrypt arguments and sizes should be reviewed carefully. I read the manual(s) back and forth but still feel a little uneasy but the way they were before seemed wrong.
Motivation and context
Parsing of ASN1 keys had a flaw when converting gcrypt hex string output to QByteArray which happened only once in five times of key parsing.
This at least affects Windows users with Pageant. OpenSSH may tolerate inconsistencies in the private key better.
How has this been tested?
New test was added and manual tests were run on Linux and Windows with a bunch of different keys.
Types of changes
Checklist: