Allows a separate ID key for association#258
Merged
droidmonkey merged 1 commit intodevelopfrom Sep 11, 2018
Merged
Conversation
droidmonkey
approved these changes
Aug 15, 2018
droidmonkey
approved these changes
Sep 11, 2018
Member
droidmonkey
left a comment
There was a problem hiding this comment.
Corresponding KeePassXC fix merged and released in 2.3.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing associations to multiple databases within the same session, the same public key is used as an identification key. This causes the connections to use identical keys.
This PR solves it by modifying the keepassxc-protocol to allow a separate
idKeyused for association.Fixes #257.
Related KeePassXC PR: keepassxreboot/keepassxc#2185.