fix: feature flag for unexpected scaler param check by wozniakjan · Pull Request #7191 · kedacore/keda

wozniakjan · 2025-10-20T11:53:46Z

The check for unexpected scaler parameters is causing a flood of events in 2.18.0 release due to:

incomplete refactors
undocumented parameters
parameter is specified but contains "" as value
deprecated parameters where users were not forced/active to cleanup their ScaledObjects

This PR proposes adding KEDA_CHECK_UNEXPECTED_SCALERS_PARAMS env variable, which is disabled by default, so we can release 2.18.1 not causing too many events getting created until 1., 2. and 3. are addressed.

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on
- events for TypedConfig parsing keda-docs#1646
Commits are signed with Developer Certificate of Origin (DCO - learn more)

see also: #6763
see also: #7188
see also: #7179

github-actions · 2025-10-20T11:55:47Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

rickbrouwer · 2025-10-20T12:00:36Z

I'd like to specify a variation on when the message appears:

If a valid parameter is sent but without a value, it will also return the unmatched message. The message is in this case misleading/incorrect.

wozniakjan · 2025-10-20T12:04:57Z

If a valid parameter is sent but without a value, it will also return the unmatched message. The message is in this case misleading/incorrect.

that is a good point, I will for now include it in the list why this feature needs a bit more consideration

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

rickbrouwer · 2025-10-20T12:43:45Z

/run-e2e external*
Update: You can check the progress here

rickbrouwer · 2025-10-20T12:44:52Z

I'm running the external tests. This still contains unmatched messages. These should no longer appear when running the test.

wozniakjan · 2025-10-20T14:05:45Z

I'm running the external tests. This still contains unmatched messages. These should no longer appear when running the test.

what would be the best place to check for those events? I grepped through the logs of the latest e2e test execution from this PR and there, all occurrences appear to be unrelated to the bug and just references to git

$ gh -R kedacore/keda run view --job 53173749080 --log | grep 'unmatched'
Execute e2e tests       Run actions/checkout@***bd7***90***bbe5b***6***0ceea7***d***7597***64c9af68***  2025-10-20T13:05:14.6269323Z [command]/usr/bin/git branch --delete --force unmatched-v***
Execute e2e tests       Run actions/checkout@***bd7***90***bbe5b***6***0ceea7***d***7597***64c9af68***  2025-10-20T13:05:14.6380282Z Deleted branch unmatched-v*** (was ***4***476***8).
Execute e2e tests       Run actions/checkout@***bd7***90***bbe5b***6***0ceea7***d***7597***64c9af68***  2025-10-20T13:05:15.5793230Z   c***c688fb***b Fix incorrect 'unmatched input property' notification
Execute e2e tests       Run actions/checkout@***bd7***90***bbe5b***6***0ceea7***d***7597***64c9af68***  2025-10-20T13:05:15.5796646Z   e896***6a***65 Fix incorrect 'unmatched input property' notification (#7***76)

rickbrouwer · 2025-10-20T14:26:34Z

to check for those events? I grepped through the logs

Unmatched input property metricThreshold in scaler external-push

And this one is not in the logging now, so test passed :)

wozniakjan · 2025-10-20T14:28:35Z

And this one is not in the logging now, so test passed :)

perfect, I will wait for the consensus tomorrow and if this ends up being picked, I will create a PR to charts and docs

rickbrouwer · 2025-10-20T14:31:54Z

And this one is not in the logging now, so test passed :)

perfect, I will wait for the consensus tomorrow and if this ends up being picked, I will create a PR to charts and docs

Great. I'll also be at the KEDA community call tomorrow.

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

* Fix incorrect 'unmatched input property' notification (#7176) * Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Remove redundant parsing Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * use typedconfig once Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * static check Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update datadog_scaler_test.go Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update schemas Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update typedconfig Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update pkg/scalers/datadog_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: add missing error returns in kafka scaler error handling (#7182) * fix: add missing error returns in kafka scaler error handling Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> * docs: update changelog for PR #7182 Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> --------- Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Fix incorrect 'unmatched input property' notification (#7188) * Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * add azure cloud Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: feature flag for unexpected scaler param check (#7191) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Update prometheus dependency version (#7194) Updated prometheus dependency version to v0.54.0. Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: send raw metrics also during polling interval (#7198) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * . Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: leeyeonwoo <74847519+5iing@users.noreply.github.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

wozniakjan requested a review from a team as a code owner October 20, 2025 11:53

keda-automation requested a review from a team October 20, 2025 11:53

wozniakjan mentioned this pull request Oct 20, 2025

Release: 2.18.1 #7179

Closed

28 tasks

wozniakjan force-pushed the feature_flag_for_unexpected_scaler_param_check branch from 3404db0 to ecc873d Compare October 20, 2025 12:03

fix: feature flag for unexpected scaler param check

1acf8e1

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

wozniakjan force-pushed the feature_flag_for_unexpected_scaler_param_check branch from ecc873d to 1acf8e1 Compare October 20, 2025 12:08

rickbrouwer approved these changes Oct 20, 2025

View reviewed changes

zroubalik approved these changes Oct 21, 2025

View reviewed changes

rickbrouwer added the ok-to-merge This PR can be merged label Oct 22, 2025

wozniakjan merged commit c163477 into kedacore:main Oct 24, 2025
24 of 25 checks passed

wozniakjan mentioned this pull request Oct 24, 2025

events for TypedConfig parsing kedacore/keda-docs#1646

Merged

1 task

JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 29, 2025

fix: feature flag for unexpected scaler param check (kedacore#7191)

41ea353

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 29, 2025

fix: feature flag for unexpected scaler param check (kedacore#7191)

aa67a50

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025

fix: feature flag for unexpected scaler param check (kedacore#7191)

aca365d

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025

fix: feature flag for unexpected scaler param check (kedacore#7191)

6ad4e70

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026

fix: feature flag for unexpected scaler param check (kedacore#7191)

8a292e6

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: feature flag for unexpected scaler param check#7191

fix: feature flag for unexpected scaler param check#7191
wozniakjan merged 1 commit intokedacore:mainfrom
wozniakjan:feature_flag_for_unexpected_scaler_param_check

wozniakjan commented Oct 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

rickbrouwer commented Oct 20, 2025

Uh oh!

wozniakjan commented Oct 20, 2025

Uh oh!

rickbrouwer commented Oct 20, 2025 •

edited by github-actions bot

Loading

Uh oh!

rickbrouwer commented Oct 20, 2025

Uh oh!

wozniakjan commented Oct 20, 2025

Uh oh!

rickbrouwer commented Oct 20, 2025

Uh oh!

wozniakjan commented Oct 20, 2025

Uh oh!

rickbrouwer commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

wozniakjan commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

rickbrouwer commented Oct 20, 2025

Uh oh!

wozniakjan commented Oct 20, 2025

Uh oh!

rickbrouwer commented Oct 20, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Oct 20, 2025

Uh oh!

wozniakjan commented Oct 20, 2025

Uh oh!

rickbrouwer commented Oct 20, 2025

Uh oh!

wozniakjan commented Oct 20, 2025

Uh oh!

rickbrouwer commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wozniakjan commented Oct 20, 2025 •

edited

Loading

rickbrouwer commented Oct 20, 2025 •

edited by github-actions bot

Loading