fix: add missing error returns in kafka scaler error handling by 5iing · Pull Request #7182 · kedacore/keda

5iing · 2025-10-16T05:24:18Z

Summary

This PR fixes missing error returns in the Kafka scaler's error handling paths. Currently, three error cases only log errors but continue execution, which can lead to incorrect scaling behavior.

Changes

Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 (kafka_scaler.go:738-741)
Add error return in getTopicPartitions when topicMetadata.Err > 0 (kafka_scaler.go:765-768)
Add error return in getLagForPartition when block.Err > 0 (kafka_scaler.go:821-824)

Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior when Kafka API calls fail.

Test Results

All Kafka scaler tests pass:

$ go test -v ./pkg/scalers -run Kafka
=== RUN TestApacheKafkaGetBrokers
--- PASS: TestApacheKafkaGetBrokers (0.00s)
=== RUN TestApacheKafkaAuthParams
--- PASS: TestApacheKafkaAuthParams (0.00s)
=== RUN TestApacheKafkaGetMetricSpecForScaling
--- PASS: TestApacheKafkaGetMetricSpecForScaling (0.00s)
=== RUN TestKafkaAuthParamsInTriggerAuthentication
--- PASS: TestKafkaAuthParamsInTriggerAuthentication (0.00s)
=== RUN TestKafkaAuthParamsInScaledObject
--- PASS: TestKafkaAuthParamsInScaledObject (0.00s)
=== RUN TestKafkaOAuthbearerAuthParams
--- PASS: TestKafkaOAuthbearerAuthParams (0.00s)
=== RUN TestKafkaClientsOAuthTokenProvider
--- PASS: TestKafkaClientsOAuthTokenProvider (0.00s)
=== RUN TestKafkaGetMetricSpecForScaling
--- PASS: TestKafkaGetMetricSpecForScaling (0.00s)
PASS
ok github.com/kedacore/keda/v2/pkg/scalers (cached)

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Changelog has been updated and is aligned with our changelog requirements (will update after PR number is assigned)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com>

github-actions · 2025-10-16T05:24:25Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

Signed-off-by: leeyeonwoo <rexrex1105@gmail.com>

SpiritZhou · 2025-10-17T08:21:51Z

/run-e2e kafka
Update: You can check the progress here

dttung2905

LGTM. Thanks alot for the fix 🙏

5iing · 2025-10-21T01:22:37Z

Thank you for approving!

wozniakjan · 2025-10-22T09:14:54Z

/run-e2e kafka
Update: You can check the progress here

…re#7182) * fix: add missing error returns in kafka scaler error handling Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> * docs: update changelog for PR kedacore#7182 Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> --------- Signed-off-by: leeyeonwoo <rexrex1105@gmail.com>

…re#7182) * fix: add missing error returns in kafka scaler error handling Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> * docs: update changelog for PR kedacore#7182 Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> --------- Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

* Fix incorrect 'unmatched input property' notification (#7176) * Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Remove redundant parsing Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * use typedconfig once Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * static check Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update datadog_scaler_test.go Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update schemas Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update typedconfig Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update pkg/scalers/datadog_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: add missing error returns in kafka scaler error handling (#7182) * fix: add missing error returns in kafka scaler error handling Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> * docs: update changelog for PR #7182 Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> --------- Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Fix incorrect 'unmatched input property' notification (#7188) * Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * add azure cloud Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: feature flag for unexpected scaler param check (#7191) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Update prometheus dependency version (#7194) Updated prometheus dependency version to v0.54.0. Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: send raw metrics also during polling interval (#7198) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * . Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: leeyeonwoo <74847519+5iing@users.noreply.github.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>

…re#7182) * fix: add missing error returns in kafka scaler error handling Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> * docs: update changelog for PR kedacore#7182 Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> --------- Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

…re#7182) * fix: add missing error returns in kafka scaler error handling Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> * docs: update changelog for PR kedacore#7182 Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> --------- Signed-off-by: leeyeonwoo <rexrex1105@gmail.com>

5iing requested a review from a team as a code owner October 16, 2025 05:24

keda-automation requested a review from a team October 16, 2025 05:24

docs: update changelog for PR kedacore#7182

7b19bf6

Signed-off-by: leeyeonwoo <rexrex1105@gmail.com>

SpiritZhou approved these changes Oct 17, 2025

View reviewed changes

wozniakjan mentioned this pull request Oct 20, 2025

Release: 2.18.1 #7179

Closed

28 tasks

rickbrouwer approved these changes Oct 20, 2025

View reviewed changes

rickbrouwer added the ok-to-merge This PR can be merged label Oct 20, 2025

dttung2905 approved these changes Oct 20, 2025

View reviewed changes

wozniakjan approved these changes Oct 21, 2025

View reviewed changes

Merge branch 'main' into fix/kafka-error-handling

90c06b6

keda-automation requested review from a team October 22, 2025 01:22

wozniakjan enabled auto-merge (squash) October 22, 2025 09:15

JorTurFer approved these changes Oct 25, 2025

View reviewed changes

wozniakjan merged commit dbbf5ab into kedacore:main Oct 25, 2025
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add missing error returns in kafka scaler error handling#7182

fix: add missing error returns in kafka scaler error handling#7182
wozniakjan merged 3 commits intokedacore:mainfrom
5iing:fix/kafka-error-handling

5iing commented Oct 16, 2025 •

edited by wozniakjan

Loading

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

SpiritZhou commented Oct 17, 2025 •

edited by github-actions bot

Loading

Uh oh!

dttung2905 left a comment

Uh oh!

5iing commented Oct 21, 2025

Uh oh!

wozniakjan commented Oct 22, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

5iing commented Oct 16, 2025 • edited by wozniakjan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test Results

Checklist

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

SpiritZhou commented Oct 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dttung2905 left a comment

Choose a reason for hiding this comment

Uh oh!

5iing commented Oct 21, 2025

Uh oh!

wozniakjan commented Oct 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

5iing commented Oct 16, 2025 •

edited by wozniakjan

Loading

SpiritZhou commented Oct 17, 2025 •

edited by github-actions bot

Loading

wozniakjan commented Oct 22, 2025 •

edited by github-actions bot

Loading