fix: send raw metrics also during polling interval by zroubalik · Pull Request #7198 · kedacore/keda

zroubalik · 2025-10-24T13:04:12Z

Fix for raw metrrics stream #7094

Fixed the behavior to send metrics also during polling interval
To support this better a new Environment Variable: RAW_METRICS_MODE with support for:
- all or "" (empty): Send all raw metrics (both HPA and polling) - default
- hpa: Send raw metrics only from HPA requests
- pollinginterval: Send raw metrics only from polling interval
- Unknown values default to all

Checklist

Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on docs: Update raw metrics consumption details and add configuration options keda-docs#1647
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #7197

Relates to #7094

github-actions · 2025-10-24T13:04:25Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

Copilot

Pull Request Overview

This PR fixes the raw metrics streaming feature to send metrics during polling intervals in addition to HPA requests. It introduces a new RAW_METRICS_MODE environment variable to control when raw metrics are sent.

Adds configurable raw metrics modes (all, HPA-only, or polling-interval-only)
Implements logic to send raw metrics during ScaledObject polling intervals
Refactors raw metrics configuration into a dedicated file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
pkg/scaling/scale_handler_raw_metrics.go	Introduces raw metrics mode parsing and decision logic with new environment variable support
pkg/scaling/scale_handler.go	Updates raw metrics sending calls to use new mode-aware function and adds polling interval support
CHANGELOG.md	Documents the fix for raw metrics streaming during polling intervals

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

zroubalik · 2025-10-24T13:24:21Z

/run-e2e internal
Update: You can check the progress here

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

zroubalik · 2025-10-24T13:27:21Z

/run-e2e internal
Update: You can check the progress here

rickbrouwer · 2025-10-24T18:58:28Z

I am a nit picker on commit messages regarding spelling errors 😇
Is it possible to change metrrics to metrics?

zroubalik · 2025-10-27T08:27:47Z

I am a nit picker on commit messages regarding spelling errors 😇 Is it possible to change metrrics to metrics?

haha, thanks a lot!, fixed

…etter clarity Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

zroubalik · 2025-10-27T09:12:54Z

/run-e2e internal
Update: You can check the progress here

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

* Fix incorrect 'unmatched input property' notification (#7176) * Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Remove redundant parsing Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * use typedconfig once Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * static check Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update datadog_scaler_test.go Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update schemas Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update typedconfig Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update pkg/scalers/datadog_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: add missing error returns in kafka scaler error handling (#7182) * fix: add missing error returns in kafka scaler error handling Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> * docs: update changelog for PR #7182 Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> --------- Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Fix incorrect 'unmatched input property' notification (#7188) * Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * add azure cloud Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: feature flag for unexpected scaler param check (#7191) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Update prometheus dependency version (#7194) Updated prometheus dependency version to v0.54.0. Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: send raw metrics also during polling interval (#7198) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * . Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: leeyeonwoo <74847519+5iing@users.noreply.github.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

zroubalik requested a review from a team as a code owner October 24, 2025 13:04

keda-automation requested a review from a team October 24, 2025 13:04

zroubalik mentioned this pull request Oct 24, 2025

Release: 2.18.1 #7179

Closed

28 tasks

zroubalik force-pushed the raw branch from a9afce5 to 99c9988 Compare October 24, 2025 13:15

jkremser approved these changes Oct 24, 2025

View reviewed changes

zroubalik force-pushed the raw branch from 99c9988 to c49aad4 Compare October 24, 2025 13:18

zroubalik requested a review from Copilot October 24, 2025 13:20

Copilot AI reviewed Oct 24, 2025

View reviewed changes

fix: send raw metrrics also during polling interval

d7bf8d0

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

zroubalik force-pushed the raw branch from c49aad4 to d7bf8d0 Compare October 24, 2025 13:26

rickbrouwer approved these changes Oct 24, 2025

View reviewed changes

zroubalik changed the title ~~fix: send raw metrrics also during polling interval~~ fix: send raw metrics also during polling interval Oct 27, 2025

keda-automation requested a review from a team October 27, 2025 09:10

fix: update shouldSendRawMetrics function to use RawMetricsMode for b…

3095255

…etter clarity Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

zroubalik force-pushed the raw branch from 491dd2f to 3095255 Compare October 27, 2025 09:12

JorTurFer approved these changes Oct 27, 2025

View reviewed changes

wozniakjan approved these changes Oct 27, 2025

View reviewed changes

zroubalik merged commit 7c9ced6 into kedacore:main Oct 27, 2025
24 checks passed

JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 29, 2025

fix: send raw metrics also during polling interval (kedacore#7198)

490d5a3

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 29, 2025

fix: send raw metrics also during polling interval (kedacore#7198)

f609758

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025

fix: send raw metrics also during polling interval (kedacore#7198)

163404a

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025

fix: send raw metrics also during polling interval (kedacore#7198)

4ae9aa3

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026

fix: send raw metrics also during polling interval (kedacore#7198)

89092f1

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: send raw metrics also during polling interval#7198

fix: send raw metrics also during polling interval#7198
zroubalik merged 2 commits intokedacore:mainfrom
zroubalik:raw

zroubalik commented Oct 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

zroubalik commented Oct 24, 2025 •

edited by github-actions bot

Loading

Uh oh!

zroubalik commented Oct 24, 2025 •

edited by github-actions bot

Loading

Uh oh!

rickbrouwer commented Oct 24, 2025

Uh oh!

zroubalik commented Oct 27, 2025

Uh oh!

zroubalik commented Oct 27, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

zroubalik commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

zroubalik commented Oct 24, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zroubalik commented Oct 24, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Oct 24, 2025

Uh oh!

zroubalik commented Oct 27, 2025

Uh oh!

zroubalik commented Oct 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zroubalik commented Oct 24, 2025 •

edited

Loading

zroubalik commented Oct 24, 2025 •

edited by github-actions bot

Loading

zroubalik commented Oct 24, 2025 •

edited by github-actions bot

Loading

zroubalik commented Oct 27, 2025 •

edited by github-actions bot

Loading