Fix incorrect 'unmatched input property' notification by rickbrouwer · Pull Request #7176 · kedacore/keda

rickbrouwer · 2025-10-10T16:07:50Z

This PR fixes the 'unmatched input property' notification which in some cases is wrongly given.

There are currently 3 different cases when this can occur:

The matching can't handle some authModes by (*authentication.AuthMeta). Loki and Pulsar uses this. I've changed Loki to the new method. I've done a quick fix for Pulsar. Changing to authentication.Config for Pulsar and making it backwards compatible is a significant refactoring effort.
The matching can't handle properties that can have multiple values. Like in the Datadog scaler which has targetValue and queryvalue, like:

TargetValue   float64       `keda:"name=targetValue;queryValue, order=triggerMetadata, default=-1"`

The matching can't handle scalers that have parameters outside of TypedConfig if the scaler also uses TypedConfig, like the Datadog scaler (useClusterAgentProxy).

And a little bonus;

Replaced msgBacklog for msgBacklogThreshold in the Pulsar test because msgBacklog is unmatched.
The other change in the CHANGELOG.md is because the order is not correct and the static checks are falling over it

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #7174

Relates to #6763

github-actions · 2025-10-10T16:07:58Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

rickbrouwer · 2025-10-10T16:39:34Z

/run-e2e loki|datadog|pulsar
Update: You can check the progress here

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer · 2025-10-10T18:36:06Z

/run-e2e loki|datadog|pulsar
Update: You can check the progress here

pkg/scalers/datadog_scaler.go

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer · 2025-10-13T08:29:24Z

/run-e2e loki|datadog|pulsar
Update: You can check the progress here

rickbrouwer · 2025-10-13T08:32:36Z

Thanks for the review, @wozniakjan . Given the mentioned issue and the number of scalers likely affected by the various issues, I'd really like to nominate this PR for a patch release (2.18.1). We have skipped 2.18 due to this issue and are waiting for a patch release.

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer · 2025-10-13T10:06:33Z

Apparently more scalers have been affected. I need to find out what the additional issue is there.

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer · 2025-10-13T12:02:27Z

/run-e2e datadog
Update: You can check the progress here

wozniakjan · 2025-10-13T12:34:49Z

Given the mentioned issue and the number of scalers likely affected by the various issues, I'd really like to nominate this PR for a patch release (2.18.1). We have skipped 2.18 due to this issue and are waiting for a patch release.

Apparently more scalers have been affected. I need to find out what the additional issue is there.

good idea, I think we can get 2.18.1 out as soon as the regressions are addressed, feel free to add more items to #7179

zroubalik · 2025-10-13T12:39:28Z

Thanks for the review, @wozniakjan . Given the mentioned issue and the number of scalers likely affected by the various issues, I'd really like to nominate this PR for a patch release (2.18.1). We have skipped 2.18 due to this issue and are waiting for a patch release.

Agree, thanks for fixing this!

rickbrouwer · 2025-10-13T13:16:38Z

@wozniakjan

Okay, I've checked the latest report regarding the Prometheus scaler in the issue. In that case, the report is "correct." I've marked the PR as "ready for review" again.

rickbrouwer · 2025-10-13T14:21:21Z

By the way, the message now is:

Unmatched input property authModes in scaler ScaledObject

I personally find that message strange. I would rather expect the type scaler, such as 'prometheus', so that the message is

Unmatched input property authModes in scaler prometheus

I would therefore like to change:

message := fmt.Sprintf("Unmatched input property %s in scaler %s", key+suffix, sc.ScalableObjectType)
to
message := fmt.Sprintf("Unmatched input property %s in scaler %s", key+suffix, sc.TriggerType)

Agree?

zroubalik · 2025-10-13T14:43:16Z

By the way, the message now is:

Unmatched input property authModes in scaler ScaledObject

I personally find that message strange. I would rather expect the type scaler, such as 'prometheus', so that the message is

Unmatched input property authModes in scaler prometheus

I would therefore like to change:

message := fmt.Sprintf("Unmatched input property %s in scaler %s", key+suffix, sc.ScalableObjectType) to message := fmt.Sprintf("Unmatched input property %s in scaler %s", key+suffix, sc.TriggerType)

Agree?

yeah, the original one is obviously a mistake

I would like to really thank you for fixing this issue that quickly!

Copilot

Pull Request Overview

This PR fixes incorrect 'unmatched input property' notifications that were being generated in three different scenarios: handling authentication configurations that use *authentication.AuthMeta, properties with multiple values (like Datadog's targetValue/queryValue), and scalers with parameters outside TypedConfig when also using TypedConfig.

Key changes:

Modified typed configuration matching to return all parameter names instead of just the primary name
Updated Loki scaler to use the new authentication config pattern
Added AuthModes field to Pulsar scaler for better authentication handling
Refactored Datadog scaler to use unified TypedConfig approach with separate validation functions

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/scalers/scalersconfig/typed_config.go	Fixed parameter name matching to return all names instead of just primary name
pkg/scalers/loki_scaler.go	Migrated from AuthMeta to authentication.Config pattern
pkg/scalers/pulsar_scaler.go	Added AuthModes field to support authentication configuration
pkg/scalers/datadog_scaler.go	Refactored to use unified TypedConfig with separate validation functions
tests/scalers/pulsar/helper/helper.go	Fixed test to use correct parameter name
pkg/scalers/scalersconfig/typed_config_test.go	Updated test to handle unordered message validation
pkg/scalers/loki_scaler_test.go	Updated test to use new authentication methods
pkg/scalers/datadog_scaler_test.go	Refactored tests to use helper function for metadata creation
CHANGELOG.md	Added entry for the fix and reordered existing entries

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

pkg/scalers/datadog_scaler.go

zroubalik · 2025-10-13T14:44:06Z

You can also include the triggerName in the message (in case it is set)

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer · 2025-10-13T15:20:58Z

/run-e2e loki|datadog|pulsar|prometheus
Update: You can check the progress here

rickbrouwer · 2025-10-13T15:23:48Z

You can also include the triggerName in the message (in case it is set)

Yeah, I like that. I have changed it to:

Without triggerName: Unmatched input property metricName in scaler prometheus
With triggerName: Unmatched input property metricName in scaler prometheus (my-prometheus-trigger)

JorTurFer · 2025-10-13T21:14:33Z

awesome fix! thanks for the quick reaction 🙇

* Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Remove redundant parsing Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * use typedconfig once Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * static check Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update datadog_scaler_test.go Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update schemas Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update typedconfig Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update pkg/scalers/datadog_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Remove redundant parsing Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * use typedconfig once Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * static check Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update datadog_scaler_test.go Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update schemas Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update typedconfig Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update pkg/scalers/datadog_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

* Fix incorrect 'unmatched input property' notification (#7176) * Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Remove redundant parsing Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * use typedconfig once Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * static check Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update datadog_scaler_test.go Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update schemas Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update typedconfig Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update pkg/scalers/datadog_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: add missing error returns in kafka scaler error handling (#7182) * fix: add missing error returns in kafka scaler error handling Add missing error returns after error logging in getTopicPartitions and getLagForPartition functions to prevent incorrect behavior when errors occur. - Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0 - Add error return in getTopicPartitions when topicMetadata.Err > 0 - Add error return in getLagForPartition when block.Err > 0 Previously these functions only logged errors but continued execution, which could lead to incorrect scaling behavior. Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> * docs: update changelog for PR #7182 Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> --------- Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Fix incorrect 'unmatched input property' notification (#7188) * Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * add azure cloud Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: feature flag for unexpected scaler param check (#7191) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Update prometheus dependency version (#7194) Updated prometheus dependency version to v0.54.0. Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: send raw metrics also during polling interval (#7198) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * . Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> Signed-off-by: leeyeonwoo <rexrex1105@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: leeyeonwoo <74847519+5iing@users.noreply.github.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>

* Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Remove redundant parsing Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * use typedconfig once Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * static check Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update datadog_scaler_test.go Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update schemas Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update typedconfig Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update pkg/scalers/datadog_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

* Fix incorrect 'unmatched input property' notification Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Remove redundant parsing Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * use typedconfig once Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * static check Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update datadog_scaler_test.go Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update schemas Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * update typedconfig Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update pkg/scalers/datadog_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

keda-automation requested review from a team October 10, 2025 16:08

rickbrouwer force-pushed the issue-7174 branch 3 times, most recently from 6f408fa to 81bc176 Compare October 10, 2025 16:23

Fix incorrect 'unmatched input property' notification

c83eb54

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer force-pushed the issue-7174 branch from 81bc176 to c83eb54 Compare October 10, 2025 18:34

rickbrouwer marked this pull request as ready for review October 10, 2025 18:35

SpiritZhou approved these changes Oct 13, 2025

View reviewed changes

wozniakjan approved these changes Oct 13, 2025

View reviewed changes

pkg/scalers/datadog_scaler.go Outdated Show resolved Hide resolved

Remove redundant parsing

d9b380d

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

keda-automation requested review from a team October 13, 2025 07:53

fix

1522c8b

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

use typedconfig once

fd30bb5

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer marked this pull request as draft October 13, 2025 10:05

rickbrouwer added 4 commits October 13, 2025 13:01

static check

9602a55

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

Update test

b46cedd

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

Update datadog_scaler_test.go

92e41e2

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

update schemas

f47425f

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer force-pushed the issue-7174 branch from 9615f37 to f47425f Compare October 13, 2025 11:25

fix test

85526ea

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

wozniakjan mentioned this pull request Oct 13, 2025

Release: 2.18.1 #7179

Closed

28 tasks

rickbrouwer marked this pull request as ready for review October 13, 2025 13:03

zroubalik requested a review from Copilot October 13, 2025 14:43

Copilot AI reviewed Oct 13, 2025

View reviewed changes

pkg/scalers/datadog_scaler.go Outdated Show resolved Hide resolved

rickbrouwer and others added 2 commits October 13, 2025 17:16

update typedconfig

0f2f529

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

Update pkg/scalers/datadog_scaler.go

1c34d88

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

zroubalik approved these changes Oct 13, 2025

View reviewed changes

JorTurFer approved these changes Oct 13, 2025

View reviewed changes

JorTurFer merged commit e89626a into kedacore:main Oct 13, 2025
24 checks passed

rickbrouwer deleted the issue-7174 branch October 14, 2025 05:01

rickbrouwer mentioned this pull request Oct 18, 2025

Fix incorrect 'unmatched input property' notification #7188

Merged

3 tasks

reiichii mentioned this pull request Oct 23, 2025

Datadog Scaler: queryValue parameter not recognized after upgrade to v2.18 #7196

Closed

Conversation

rickbrouwer commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

rickbrouwer commented Oct 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Oct 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rickbrouwer commented Oct 13, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Oct 13, 2025

Uh oh!

rickbrouwer commented Oct 13, 2025

Uh oh!

rickbrouwer commented Oct 13, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan commented Oct 13, 2025

Uh oh!

zroubalik commented Oct 13, 2025

Uh oh!

rickbrouwer commented Oct 13, 2025

Uh oh!

rickbrouwer commented Oct 13, 2025

Uh oh!

zroubalik commented Oct 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

zroubalik commented Oct 13, 2025

Uh oh!

rickbrouwer commented Oct 13, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rickbrouwer commented Oct 10, 2025 •

edited

Loading

rickbrouwer commented Oct 10, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Oct 10, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Oct 13, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Oct 13, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Oct 13, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Oct 13, 2025 •

edited

Loading