Add error and event for mismatching input property#6763
Merged
JorTurFer merged 7 commits intokedacore:mainfrom Aug 21, 2025
Merged
Add error and event for mismatching input property#6763JorTurFer merged 7 commits intokedacore:mainfrom
JorTurFer merged 7 commits intokedacore:mainfrom
Conversation
dttung2905
reviewed
Jun 8, 2025
Contributor
dttung2905
left a comment
There was a problem hiding this comment.
Generally LGTM, just a small nit though
Member
|
/run-e2e |
wozniakjan
approved these changes
Jun 9, 2025
Member
wozniakjan
left a comment
There was a problem hiding this comment.
lgtm, thank you!
Maybe the event type deserves a little bit of discussion as mentioned here by @dttung2905 but I'm happy with either result of the discussion.
Contributor
Author
|
/run-e2e |
Member
rebase your branch, the error looks related with the changes for s290x |
zroubalik
approved these changes
Jul 7, 2025
0cf02d2 to
a28edd4
Compare
rickbrouwer
previously requested changes
Jul 10, 2025
Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com>
JorTurFer
approved these changes
Aug 7, 2025
Member
JorTurFer
left a comment
There was a problem hiding this comment.
Awesome improvement! Just a small comment inline
dttung2905
approved these changes
Aug 8, 2025
Member
|
/skip-e2e |
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
auto-merge was automatically disabled
August 21, 2025 07:37
Head branch was pushed to by a user without write access
JorTurFer
approved these changes
Aug 21, 2025
jmickey
pushed a commit
to jmickey/keda
that referenced
this pull request
Aug 22, 2025
* Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update pkg/scalers/scalersconfig/typed_config_test.go Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> --------- Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: zhenghanzhou <zhenghanzhou@microsoft.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
* Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update pkg/scalers/scalersconfig/typed_config_test.go Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> --------- Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: zhenghanzhou <zhenghanzhou@microsoft.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>
This was referenced Oct 9, 2025
This was referenced Oct 15, 2025
Closed
4 tasks
alt-dima
pushed a commit
to alt-dima/keda
that referenced
this pull request
Dec 13, 2025
* Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update pkg/scalers/scalersconfig/typed_config_test.go Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> --------- Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: zhenghanzhou <zhenghanzhou@microsoft.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5
pushed a commit
to tangobango5/keda
that referenced
this pull request
Dec 22, 2025
* Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update pkg/scalers/scalersconfig/typed_config_test.go Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> --------- Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: zhenghanzhou <zhenghanzhou@microsoft.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
tangobango5
pushed a commit
to tangobango5/keda
that referenced
this pull request
Feb 13, 2026
* Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> * Update pkg/scalers/scalersconfig/typed_config_test.go Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> --------- Signed-off-by: zhenghanzhou <zhenghanzhou@microsoft.com> Signed-off-by: Zhenghan Zhou <iammrzhouzhenghan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: zhenghanzhou <zhenghanzhou@microsoft.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #
Relates to # #6721