Versions using layouts and bootstrap by dgrammatiko · Pull Request #5654 · joomla/joomla-cms

dgrammatiko · 2015-01-09T20:18:02Z

Use of layouts for field contenthistory

This is a redone for #4561. Now versions are using layouts and there are two sets:
One on the root/layouts this is for B/C
And another on the templates isis and protostar this is using bootstrap modal

Actual rendering:

Isis:

Protostar:

B/C

None

Testing

Try to re edit an article on backend and front end (make sure that versions are enabled and you have few versions available)

wilsonge · 2015-01-10T00:48:42Z

Note to committers DO NOT merge this for 3.4. Wait until me and @phproberto have worked out the final desired form for a rendering class.

dgrammatiko · 2015-01-10T08:50:54Z

@wilsonge I am not trying to change your (and @phproberto ’s) timelines here!
My idea here was that if introducing: user, media and versions fields using layouts and bootstrap and also have #4661, #4645, #4563 and #5652 merged for 3.4 then the team could advertise that Joomla dropped almost totally Mootools in core.
BUT that could happen ONLY IF the fields DO NOT introduce a wrong approach which then will become a pain in the @$$ to try to maintain, update etc.
Also I don’t know what are the USP s for 3.4, but I assume that advertising a total transition to jQuery could be a nice feature (amongst the others)

Bottom line: if you want me to put it on hold (e.g. close it for now) I will do so

wilsonge · 2015-01-11T20:20:12Z

I completely understand the reasons for this! And I support killing off mootools as well. The issue for me is how we intialise and render the JLayout. The framework View package from 2.0 will likely include this renderer class Michael wrote for Jissues (see ). We had a JLayout implementation here https://github.com/joomla-projects/cms-naked/blob/master/libraries/cms/renderer/jlayout.php and were thinking about using that.

But my point is that whilst we still are really unsure about how any rendering system will work in Joomla I'm really reluctant to start doing everything before we have a 'accepted' solution. Because otherwise we start getting inconsistencies and b/c breaks. I'll try and get @phproberto to comment on this before you actually close it. But my opinion is to (reluctantly) hold it .

phproberto · 2015-01-12T12:30:44Z

Thanks @wilsonge for taking care of this. I've moved all my github notifications to another folder and it's harder for me to notice things like this.

Yes. I think this should be moved to the v3.5 release. I've just had a phone call with Javier to prepare the v3.5 enviroment. I think we are going to have the same setup than v3.4 so we will have a milestone + a tag for PRs related to it. Once we have settled where & how is v3.5 code going to be managed @wilsonge and I can have the definitive renderer ready and then start telling people how integrate things like this PR.

I don't think that this PR will need a lot of changes, just use the new rendering system. I agree that it makes no sense to introduce something now to then change it on v3.5.

So I think we can keep this PR open until in around 2 weeks we have things settled. Then point it to the right place with the right instructions.

Thanks @DGT41 !!

dgrammatiko · 2015-01-12T13:52:13Z

@wilsonge @phproberto Excellent! FYI there is also a media field layout, but I forgot to push the code here, so you don’t have to redo that one as well 😄. As soon as you settle the 3.5-dev repo I will bring it there!

One more think that needs your attention is #5652 which is a redo of the current implementation with a little twist to have bootstrap modal in the equation. And the question, as well there, is the same shall it wait for 3.5, or can it go in 3.4?

Fedik · 2015-06-14T12:12:47Z

test works good

anibalsanchez · 2015-06-14T18:53:33Z

#Test OK

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

roland-d · 2015-10-03T16:36:37Z

@wilsonge Have you figured things out as to what to do with this PR? Can this be merged into 3.5 or should it wait longer?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

wilsonge · 2015-10-03T23:57:16Z

If we implement the stuff Roberto mentioned in #7948 (comment) then I'm happy (this also applies for #5655)

dgrammatiko · 2015-10-04T12:48:18Z

To test this try to edit an article in isis, hathor, protostar and beez

zero-24 · 2015-10-28T15:21:43Z

libraries/cms/form/field/contenthistory.php

is there a reason to use $renderLayout and not $layout as e.g. here: https://github.com/joomla/joomla-cms/pull/7702/files#diff-f4e4dfd1f5119bfe9d55b7c74570c7a6R42 ?

zero-24 · 2015-10-28T16:16:41Z

Expected my comment here. Hathor is broken:

and in beez we have no option to use the versions anyway 😄 (bevor and after the patch)

protostar and isis looks good to me.

dgrammatiko · 2015-10-28T16:30:24Z

@zero-24 Fixed!

zero-24 · 2015-10-28T16:38:19Z

@DGT41 i don't see any change (on github)? Are you sure you commit the change for $renderLayout and $layout. Did you also catch that hathor problem?

zero-24 · 2015-11-01T10:16:42Z

I have tested this item 🔴 unsuccessfully on f45ad43

hmm i have still the same problems with hathor here :( Sorry for the delay @DGT41

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

coolcat-creations · 2015-11-01T16:41:35Z

I have tested this item 🔴 unsuccessfully on f45ad43

I have also issues in Hathor - it´s cut off, when the window is resized. And despite i don´t think anyone would use this on mobile - it seems to be broken also. (screens following)

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

coolcat-creations · 2015-11-01T16:41:54Z

joomla-cms-bot · 2015-11-02T14:51:10Z

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @zero-24

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

dgrammatiko · 2015-11-02T14:54:16Z

@designbengel Hathor and Beez are not really compatible with bootstrap. Let them use mootools…
So this PR now converts the content history modal to bootstrap ONLY for Isis and Protostar

zero-24 · 2015-11-02T15:00:26Z

I have tested this item ✅ successfully on 9c5bef6

Works now or lets better say it is broken the same way as bevor for hathor. 😃

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

joomla-cms-bot · 2015-11-02T23:55:54Z

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @zero-24

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

zero-24 · 2015-11-03T08:57:36Z

I have tested this item ✅ successfully on c1596fb

Still works with hathor and isis as well as protostar. for testing this #8248 needs to be applyed as well.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

@phproberto

commit 027c213 Author: dgt41 <d.grammatiko@gmail.com> Date: Sun Oct 4 15:44:39 2015 +0300 Include @phproberto s recommendations commit 2fe6482 Author: dgt41 <d.grammatiko@gmail.com> Date: Mon Jun 8 17:19:52 2015 +0300 Remove mootools from front end commit 2dedd2d Author: dgt41 <d.grammatiko@gmail.com> Date: Mon Jun 8 16:51:40 2015 +0300 JCLOSE doesn't exist commit aa229fe Author: dgt41 <d.grammatiko@gmail.com> Date: Wed Jun 3 17:53:08 2015 +0300 sync proper usage of JHtml comments default layout mootools for B/C commit cc9240f Author: dgt41 <d.grammatiko@gmail.com> Date: Wed Apr 29 02:55:29 2015 +0300 footer commit 279354b Author: dgt41 <d.grammatiko@gmail.com> Date: Fri Jan 9 22:10:51 2015 +0200 Versions using layouts and bootstrap

joomla-cms-bot · 2015-11-05T14:09:46Z

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @zero-24

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

phproberto · 2015-11-05T16:53:54Z

I have tested this item ✅ successfully on bc4331d

Works perfectly. Requires the modal CSS fixes from #5871

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

coolcat-creations · 2015-11-05T18:30:48Z

At squeezing the window there is some stuff cut off.

waader · 2015-11-05T18:37:33Z

I have tested this item ✅ successfully on bc4331d

As @designbengel noted: there are cut off´s when reducing the viewport, but on the other hand they are also present in the mootools version. So being pragmatic I would suggest to go with the current version and maybe improve here and there later.

I tested with IE8 and current FF, Chrome and IE but with no mobile phone.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

joomla-cms-bot · 2015-11-05T18:38:47Z

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @phproberto, @waader, @zero-24

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

dgrammatiko · 2015-11-05T18:40:52Z

Added a span with class hidden phone to make the buttons fit the mobile view. Preview:

@waader @designbengel can you confirm that is fixed now?

waader · 2015-11-05T18:46:47Z

Great! Before retesting ... the checkbox on left side of each row is also "hidden". Maybe you have another idea to get that fixed?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

joomla-cms-bot · 2015-11-05T18:51:27Z

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @phproberto, @waader, @zero-24

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

dgrammatiko · 2015-11-05T18:53:11Z

@waader I didn’t realize that in order to compare two versions you need to be able to select them. Now should be ok

coolcat-creations · 2015-11-05T19:03:27Z

I have tested this item ✅ successfully on ba74815

now everything is nice.
Suggestion: There is a close button at the bottom. In the banner section it´s a cancel button. maybe same wording for all modals?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5654.}

waader · 2015-11-05T19:07:43Z

Now it's definitely better than the mootools version. Thanks!

Versions using layouts and bootstrap

wilsonge · 2015-11-06T01:38:02Z

Merged - two successful tests from @waader and @designbengel

jissues-bot added the PR-staging label Jan 9, 2015

dgrammatiko mentioned this pull request Jan 22, 2015

Media form field uses mootools modal #5861

Closed

dgrammatiko mentioned this pull request Mar 27, 2015

Introduce modal footer with close button for bootstrap modals #6595

Closed

dgrammatiko mentioned this pull request May 12, 2015

Layout for the field repeatable #6917

Closed

This was referenced Jun 9, 2015

Move editor plugin buttons modals to Bootstrap #5652

Closed

Load mootools modal in layouts only if needed #7167

Merged

zero-24 added the RTC This Pull Request is Ready To Commit label Jun 14, 2015

dgrammatiko mentioned this pull request Jun 18, 2015

[New feature] Editor xtd buttons as native tinyMCE buttons #7170

Closed

zero-24 modified the milestone: Joomla! 3.4.4 Jul 2, 2015

Kubik-Rubik modified the milestones: Joomla! 3.5.0, Joomla! 3.4.4 Jul 7, 2015

dgrammatiko mentioned this pull request Aug 16, 2015

Can't Override CMS JForm Fields #5904

Closed

dgrammatiko mentioned this pull request Aug 24, 2015

Move Content Modal History from mootools to bootstrap #7764

Closed

dgrammatiko mentioned this pull request Oct 1, 2015

A simple class that can be used to render HTML elements #7948

Closed

zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 5, 2015

zero-24 reviewed Oct 28, 2015
View reviewed changes

coolcat-creations mentioned this pull request Nov 1, 2015

Move form field user to layouts and use Bootstrap modal #5655

Merged

dgrammatiko added 4 commits November 5, 2015 16:09

Hathor back to mootools

b6174d3

@phproberto's recomendations

488b996

getInput exception

bc4331d

buttons won't fit mobile size

f8a2150

checkbox needs to be available for mobiles

ba74815

wilsonge added a commit that referenced this pull request Nov 6, 2015

Merge pull request #5654 from dgt41/_field_content_history

2cfcc7c

Versions using layouts and bootstrap

wilsonge merged commit 2cfcc7c into joomla:staging Nov 6, 2015

dgrammatiko deleted the _field_content_history branch November 6, 2015 03:09

Uh oh!

Conversation

dgrammatiko commented Jan 9, 2015

Use of layouts for field contenthistory

Actual rendering:

B/C

Testing

Uh oh!

wilsonge commented Jan 10, 2015

Uh oh!

dgrammatiko commented Jan 10, 2015

Uh oh!

wilsonge commented Jan 11, 2015

Uh oh!

phproberto commented Jan 12, 2015

Uh oh!

dgrammatiko commented Jan 12, 2015

Uh oh!

Fedik commented Jun 14, 2015

Uh oh!

anibalsanchez commented Jun 14, 2015

Uh oh!

roland-d commented Oct 3, 2015

Uh oh!

wilsonge commented Oct 3, 2015

Uh oh!

dgrammatiko commented Oct 4, 2015

Uh oh!

zero-24 Oct 28, 2015

Choose a reason for hiding this comment

Uh oh!

dgrammatiko Oct 28, 2015

Choose a reason for hiding this comment

Uh oh!

zero-24 commented Oct 28, 2015

Uh oh!

dgrammatiko commented Oct 28, 2015

Uh oh!

zero-24 commented Oct 28, 2015

Uh oh!

zero-24 commented Nov 1, 2015

Uh oh!

coolcat-creations commented Nov 1, 2015

Uh oh!

coolcat-creations commented Nov 1, 2015

Uh oh!

joomla-cms-bot commented Nov 2, 2015

Uh oh!

dgrammatiko commented Nov 2, 2015

Uh oh!

zero-24 commented Nov 2, 2015

Uh oh!

joomla-cms-bot commented Nov 2, 2015

Uh oh!

zero-24 commented Nov 3, 2015

Uh oh!

joomla-cms-bot commented Nov 5, 2015

Uh oh!

phproberto commented Nov 5, 2015

Uh oh!

coolcat-creations commented Nov 5, 2015

Uh oh!

waader commented Nov 5, 2015

Uh oh!

joomla-cms-bot commented Nov 5, 2015

Uh oh!

dgrammatiko commented Nov 5, 2015

Uh oh!

waader commented Nov 5, 2015

Uh oh!

joomla-cms-bot commented Nov 5, 2015

Uh oh!

dgrammatiko commented Nov 5, 2015

Uh oh!

coolcat-creations commented Nov 5, 2015

Uh oh!

waader commented Nov 5, 2015

Uh oh!

wilsonge commented Nov 6, 2015

Uh oh!