Move form field user to layouts and use Bootstrap modal by dgrammatiko · Pull Request #5655 · joomla/joomla-cms

dgrammatiko · 2015-01-09T21:00:30Z

Move form field user to layouts and use Bootstrap modal

This is a redo of #4514 with some code from @phproberto and @wilsonge PR: #3231
Now user field is using layouts and there are two sets:
One on the root/layouts this is for B/C (mootools modal)
And another on the templates isis this is using bootstrap modal

Actual rendering:

Isis:

B/C

None

Testing

Try to re edit an article on backend, go to publishing tab and select a user.

richard67 · 2015-01-09T22:43:34Z

@test Success. Works as desired, and Hathor, too. Modal allows in both templates changing the creator, and filtering by category works, too, in both.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

richard67 · 2015-01-09T23:48:52Z

P.S.: Hathor of course with mootools modal.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

wilsonge · 2015-01-10T00:47:51Z

Note to committers DO NOT merge this for 3.4. Wait until me and @phproberto have worked out the final desired form for a rendering class.

gunjanpatel · 2015-01-10T12:08:19Z

After applying patch I can see boostrapped modal window.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

dgrammatiko · 2015-01-10T12:47:29Z

@richard67 @gunjanpatel thanks for the tests, but as @wilsonge stated in his comment this might have to wait a little bit more...

richard67 · 2015-01-10T12:51:06Z

@DGT41 Yes, I've seen ... was easy to test and I had a bit time so I tested quickly ... which then seemed to make @wilsonge panic a bit that it could be merged too soon ;-)
What confused me a bit is that here you use the bootstrapped modal only for the isis, but in the other PR for the version property you have for both isis and Hathor a bootstrapped one. Was this by purpose?

dgrammatiko · 2015-01-10T12:58:08Z

@richard67 Actually is isis and protostar not hathor and yes in this one I didn’t copy the layout to html folder of protostar as it is not used (i think so, but I might be wrong) in front end 😃

richard67 · 2015-01-10T13:01:29Z

@DGT41 Ahhh, sure, I was wrong with the other PR. Thanks for clarification.

n9iels · 2015-03-21T17:40:40Z

@test works fine for me! thanks for removing this mootools object :-)
At this moments, tree successful tests. Can somebody please set this PR as RTC?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

zero-24 · 2015-04-01T16:16:14Z

@wilsonge

Note to committers DO NOT merge this for 3.4. Wait until me and @phproberto have worked out the final desired form for a rendering class.

What is the state here?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

dgrammatiko · 2015-06-06T11:46:26Z

@zero-24 can we move this to RTC?

zero-24 · 2015-06-06T22:32:25Z

@wilsonge is your comment above (10 Jan 205) #5655 (comment) still valid? Else i think we can move to RTC here @DGT41 😄

wilsonge · 2015-06-06T22:57:45Z

It's definitely a 3.5 thing anyhow. You can mark it as RTC but hold off merging it for now. I'm still chatting to Roberto about JLayouts atm

zero-24 · 2015-06-06T23:19:23Z

Thanks @wilsonge RTC but hold off merging it for now 😄

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

anibalsanchez · 2015-06-14T18:51:42Z

#Test OK

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

roland-d · 2015-10-03T16:37:36Z

@wilsonge Have you figured things out as to what to do with this PR? Can this be merged into 3.5 or should it wait longer?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

zero-24 · 2015-10-28T16:09:45Z

I have tested this item ✅ successfully on 0723af2

Works good to me. Thanks.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

coolcat-creations · 2015-11-01T16:52:13Z

Successful in isis, In Hathor similar to #5654, ...

coolcat-creations · 2015-11-01T16:54:17Z

btw: why is Hathor used?

dgrammatiko · 2015-11-02T15:09:28Z

But Hathor here is still using the mootools modal, so in essence nothing really changed there. Maybe Hathor needs some love or someone kicking it out of Joomla. Both will work...

zero-24 · 2015-11-02T15:16:21Z

or someone kicking it out of Joomla.

@DGT41 @mbabker did it allready here: joomla-x/joomla-pythagoras#56 😄

joomla-cms-bot · 2015-11-02T23:50:59Z

This PR has received new commits.

CC: @anibalsanchez, @gunjanpatel, @n9iels, @richard67, @zero-24

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

zero-24 · 2015-11-03T09:14:42Z

I have tested this item ✅ successfully on 589eff4

Works great. For testing you need aslso apply this: #8248

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

@phproberto

commit 77470a4 Author: dgt41 <d.grammatiko@gmail.com> Date: Wed Oct 28 04:33:40 2015 +0200 Footer + close commit 90208d5 Author: dgt41 <d.grammatiko@gmail.com> Date: Wed Oct 28 04:25:22 2015 +0200 Add listener for hide event commit f7dbaf8 Author: dgt41 <d.grammatiko@gmail.com> Date: Sun Oct 25 02:27:14 2015 +0300 CS commit 9d6dc9c Author: dgt41 <d.grammatiko@gmail.com> Date: Sat Oct 24 21:27:12 2015 +0300 clear some unneeded dev vars commit d47d060 Author: dgt41 <d.grammatiko@gmail.com> Date: Sat Oct 24 21:12:25 2015 +0300 better commit 9f6856b Author: dgt41 <d.grammatiko@gmail.com> Date: Sat Oct 24 20:53:19 2015 +0300 Ensure compatibility with repeatable commit dde0a44 Author: dgt41 <d.grammatiko@gmail.com> Date: Fri Oct 23 00:22:57 2015 +0300 Fix the clear button commit ff08309 Author: dgt41 <d.grammatiko@gmail.com> Date: Fri Oct 23 00:14:38 2015 +0300 protostar override commit b46a2a0 Author: dgt41 <d.grammatiko@gmail.com> Date: Fri Oct 23 00:13:02 2015 +0300 escape the data attribute commit 9f0ec06 Author: dgt41 <d.grammatiko@gmail.com> Date: Fri Oct 23 00:02:08 2015 +0300 Use data attributes commit 8d4f7bc Author: dgt41 <d.grammatiko@gmail.com> Date: Mon Oct 5 16:26:53 2015 +0300 docblock corrections, reduce the vars passed to layout commit 911863d Author: dgt41 <d.grammatiko@gmail.com> Date: Sun Oct 4 23:29:12 2015 +0300 layouts fine tuning commit 56918a0 Author: dgt41 <d.grammatiko@gmail.com> Date: Sun Oct 4 16:42:14 2015 +0300 Implement @phproberto s recommendations commit 79ba129 Author: dgt41 <d.grammatiko@gmail.com> Date: Wed Jun 3 16:51:19 2015 +0300 sync jModalClose() proper Jhtml call remove jQuery bootstrap calls commit 16b275e Author: dgt41 <d.grammatiko@gmail.com> Date: Wed Apr 29 02:43:46 2015 +0300 footer commit 7e23e5e Author: dgt41 <d.grammatiko@gmail.com> Date: Fri Jan 9 23:51:32 2015 +0200 CS commit a1663f5 Author: dgt41 <d.grammatiko@gmail.com> Date: Fri Jan 9 00:50:17 2015 +0200 for review and comments

joomla-cms-bot · 2015-11-05T14:11:43Z

This PR has received new commits.

CC: @anibalsanchez, @gunjanpatel, @n9iels, @richard67, @zero-24

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

phproberto · 2015-11-05T14:37:00Z

This is what a I see on Isis. Note the filter overlapping the modal:

coolcat-creations · 2015-11-05T14:48:05Z

I don´t know if thats a local issue? But the patch causes a broken layout...

phproberto · 2015-11-05T14:50:43Z

I think that's a local issue yes @designbengel . Patch works here except that small filter thing.

coolcat-creations · 2015-11-05T15:04:37Z

ok i´ll install a new environment, thanks

phproberto · 2015-11-05T16:49:02Z

I have tested this item ✅ successfully on 5077c77

This works without when #5871 is merged

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

phproberto · 2015-11-05T16:50:34Z

I mean this requires the fixes applied in #5871 that affect all the modal windows

coolcat-creations · 2015-11-05T18:23:27Z

I have tested this item ✅ successfully on 5077c77

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

zero-24 · 2015-11-05T21:22:02Z

Thanks 👍 RTC now

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5655.}

Move form field user to layouts and use Bootstrap modal

infograf768 · 2015-12-13T17:30:30Z

REGRESSION: see #8669

jissues-bot added the PR-staging label Jan 9, 2015

dgrammatiko mentioned this pull request Jan 22, 2015

Media form field uses mootools modal #5861

Closed

phproberto added this to the Joomla! 3.5.0 milestone Feb 2, 2015

wilsonge assigned phproberto Mar 21, 2015

dgrammatiko mentioned this pull request Mar 27, 2015

Introduce modal footer with close button for bootstrap modals #6595

Closed

This was referenced May 6, 2015

Field types that have JS logic (User, Calendar, etc) break when used with Repeatable form field type #6882

Closed

Layout for the field repeatable #6917

Closed

dgrammatiko unassigned phproberto Jun 6, 2015

zero-24 added the RTC This Pull Request is Ready To Commit label Jun 6, 2015

dgrammatiko mentioned this pull request Jun 13, 2015

Load mootools modal in layouts only if needed #7167

Merged

dgrammatiko mentioned this pull request Jun 18, 2015

[New feature] Editor xtd buttons as native tinyMCE buttons #7170

Closed

dgrammatiko mentioned this pull request Aug 16, 2015

Can't Override CMS JForm Fields #5904

Closed

dgrammatiko mentioned this pull request Oct 1, 2015

A simple class that can be used to render HTML elements #7948

Closed

wilsonge mentioned this pull request Oct 3, 2015

Versions using layouts and bootstrap #5654

Merged

dgrammatiko added 4 commits November 5, 2015 16:10

@phproberto's recomendations

97980ef

Make parent body not scrollable when modal shown

10ab729

getInput exception

5077c77

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 5, 2015

wilsonge added a commit that referenced this pull request Nov 5, 2015

Merge pull request #5655 from dgt41/_form_user

38aac08

Move form field user to layouts and use Bootstrap modal

wilsonge merged commit 38aac08 into joomla:staging Nov 5, 2015

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 5, 2015

dgrammatiko deleted the _form_user branch November 5, 2015 22:08

infograf768 mentioned this pull request Dec 13, 2015

Regression - Missing Error message - Com_messages #8669

Closed

infograf768 mentioned this pull request Jan 29, 2016

REGRESSION user notes userid #8667

Closed

OctavianC mentioned this pull request Mar 25, 2016

JFormFieldUser broken since 3.5.0 #9593

Closed

dgrammatiko mentioned this pull request Jun 10, 2016

New formfield Modal_User : using BS modal with no B/C issue #10772

Closed

Uh oh!

Conversation

dgrammatiko commented Jan 9, 2015